refactor: address review feedback (dedup expressionUser, drop as-any cast)

Agent-Logs-Url: https://github.com/objectstack-ai/objectui/sessions/9bbb4b9a-dc45-41ea-b03e-55d3172b7dde

Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>

Author: Copilot

packages/app-shell/src/console/AppContent.tsx

@@ -146,7 +146,7 @@ export function AppContent({ extraRoutes, extraRoutesNoApp }: AppContentProps =
     // `objectName` (set per view) so action buttons mounted inside an
     // ObjectView can omit it.
     runner.registerHandler('navigate_create', async (action: any) => {
-      const ctx = (runner as any).context ?? {};
+      const ctx = runner.getContext?.() ?? {};
       const result = resolveNavigateCreateUrl({
         action,
         context: ctx,
@@ -158,7 +158,7 @@ export function AppContent({ extraRoutes, extraRoutesNoApp }: AppContentProps =
     });
 
     runner.registerHandler('navigate_edit', async (action: any) => {
-      const ctx = (runner as any).context ?? {};
+      const ctx = runner.getContext?.() ?? {};
       const result = resolveNavigateEditUrl({
         action,
         context: ctx,

packages/app-shell/src/utils/recordFormNavigation.ts

@@ -93,10 +93,15 @@ export interface NavigationActionDef {
  * Optional context typically supplied by an `ActionRunner` (e.g. when the
  * action button is mounted inside an `ObjectView`, the view registers its
  * `objectName` and `baseUrl` on the runner so action JSON can omit them).
+ *
+ * Tolerant of additional unknown keys because the upstream
+ * `ActionRunner.getContext()` returns a generic `ActionContext` with an
+ * open index signature; we only read the two fields we care about.
  */
 export interface NavigationActionContext {
   objectName?: string;
   baseUrl?: string;
+  [key: string]: unknown;
 }
 
 export type NavigationActionResult =

packages/app-shell/src/views/RecordFormPage.tsx

@@ -120,18 +120,30 @@ export function RecordFormPage({ mode }: RecordFormPageProps) {
     goBack();
   }, [goBack]);
 
+  // Authenticated-user descriptor — shared by the ExpressionEvaluator (used
+  // for field-visibility expression evaluation) and the ExpressionProvider
+  // wrapping the form (which exposes the same descriptor to descendant
+  // expression consumers). Memoised on the underlying user identity so a
+  // re-render that doesn't change the user does not invalidate downstream
+  // memoisations.
+  const expressionUser = useMemo(
+    () =>
+      user
+        ? { name: user.name, email: user.email, role: user.role ?? 'user' }
+        : { name: 'Anonymous', email: '', role: 'guest' },
+    [user],
+  );
+
   // Build expression evaluator for field-visibility expressions, mirroring
   // the global ModalForm setup in AppContent.
   const expressionEvaluator = useMemo(
     () =>
       new ExpressionEvaluator({
-        user: user
-          ? { name: user.name, email: user.email, role: user.role ?? 'user' }
-          : {},
+        user: user ? expressionUser : {},
         app: { name: appName },
         data: {},
       }),
-    [user, appName],
+    [user, expressionUser, appName],
   );
 
   // Resolve the field list using the same visibility-aware logic as the
@@ -182,10 +194,6 @@ export function RecordFormPage({ mode }: RecordFormPageProps) {
     );
   }
 
-  const expressionUser = user
-    ? { name: user.name, email: user.email, role: user.role ?? 'user' }
-    : { name: 'Anonymous', email: '', role: 'guest' };
-
   return (
     <ExpressionProvider user={expressionUser} app={{ name: appName }} data={{}}>
       <div