Fix code review issues: add missing type annotations, fix property names, remove duplicate types and type assertions

Co-authored-by: huangyiirene <7665279+huangyiirene@users.noreply.github.com>

Author: Copilot

packages/components/src/renderers/complex/data-table.tsx

@@ -39,71 +39,6 @@ import {
 
 type SortDirection = 'asc' | 'desc' | null;
 
-/**
- * Column configuration for the data table.
- * @interface Column
- */
-interface Column {
-  /** Display name of the column */
-  header: string;
-  /** Key to access the data field in each row object */
-  accessorKey: string;
-  /** Optional CSS classes for the column header */
-  className?: string;
-  /** Optional CSS classes for the column cells */
-  cellClassName?: string;
-  /** Width of the column (e.g., '80px' or 80) */
-  width?: string | number;
-  /** Whether sorting is enabled for this column (default: true) */
-  sortable?: boolean;
-  /** Whether filtering is enabled for this column (default: true) */
-  filterable?: boolean;
-  /** Whether column resizing is enabled (default: true) */
-  resizable?: boolean;
-}
-
-/**
- * Schema definition for the enterprise data table component.
- * Supports sorting, pagination, search, row selection, CSV export, and row actions.
- * @interface DataTableSchema
- */
-interface DataTableSchema {
-  /** Optional caption text displayed above the table */
-  caption?: string;
-  /** Array of column definitions */
-  columns: Column[];
-  /** Array of data objects to display. Each object should have an 'id' field for stable row identification */
-  data: any[];
-  /** Enable/disable pagination (default: true) */
-  pagination?: boolean;
-  /** Number of rows per page (default: 10) */
-  pageSize?: number;
-  /** Enable/disable search across all columns (default: true) */
-  searchable?: boolean;
-  /** Enable/disable row selection with checkboxes (default: false) */
-  selectable?: boolean;
-  /** Enable/disable column sorting (default: true) */
-  sortable?: boolean;
-  /** Enable/disable CSV export button (default: false) */
-  exportable?: boolean;
-  /** Show/hide edit and delete action buttons for each row (default: false) */
-  rowActions?: boolean;
-  /** Enable/disable column resizing by dragging (default: true) */
-  resizableColumns?: boolean;
-  /** Enable/disable column reordering by dragging (default: true) */
-  reorderableColumns?: boolean;
-  /** Callback function triggered when the edit button is clicked */
-  onRowEdit?: (row: any) => void;
-  /** Callback function triggered when the delete button is clicked */
-  onRowDelete?: (row: any) => void;
-  /** Callback function triggered when row selection changes, receives array of selected rows */
-  onSelectionChange?: (selectedRows: any[]) => void;
-  /** Callback function triggered when columns are reordered */
-  onColumnsReorder?: (columns: Column[]) => void;
-  /** Optional CSS classes for the table container */
-  className?: string;
-}
-
 /**
  * Enterprise-level data table component with Airtable-like features.
  * 

packages/components/src/renderers/complex/table.tsx

@@ -14,7 +14,7 @@ import {
 
 // A simple data-driven table
 ComponentRegistry.register('table', 
-  ({ schema, className, ...props }) => (
+  ({ schema, className, ...props }: { schema: TableSchema; className?: string; [key: string]: any }) => (
     <Table className={className} {...props}>
       {schema.caption && <TableCaption>{schema.caption}</TableCaption>}
       <TableHeader>

packages/components/src/renderers/complex/timeline.tsx

@@ -79,7 +79,7 @@ function formatDate(dateString: string, format?: string): string {
 
 ComponentRegistry.register(
   'timeline',
-  ({ schema, className, ...props }) => {
+  ({ schema, className, ...props }: { schema: TimelineSchema; className?: string; [key: string]: any }) => {
     const {
       variant = 'vertical',
       items = [],

packages/components/src/renderers/disclosure/accordion.tsx

@@ -10,7 +10,7 @@ import { renderChildren } from '../../lib/utils';
 
 ComponentRegistry.register('accordion', 
   ({ schema, className, ...props }: { schema: AccordionSchema; className?: string; [key: string]: any }) => (
-    <Accordion type={schema.type || 'single'} collapsible={schema.collapsible} className={className} {...props}>
+    <Accordion type={schema.accordionType || 'single'} collapsible={schema.collapsible} className={className} {...props}>
       {schema.items?.map((item, index: number) => (
         <AccordionItem key={item.value || index} value={item.value || `item-${index}`}>
           <AccordionTrigger>{item.title}</AccordionTrigger>

packages/components/src/renderers/form/calendar.tsx

@@ -8,7 +8,7 @@ ComponentRegistry.register('calendar',
       mode={schema.mode || "single"}
       selected={schema.value || schema.defaultValue}
       className={className}
-      {...props as any}
+      {...props}
     />
   ),
   {

packages/components/src/renderers/form/toggle.tsx

@@ -12,7 +12,7 @@ ComponentRegistry.register('toggle',
       aria-label={schema.ariaLabel}
       {...props}
     >
-      {schema.label || renderChildren(schema.body || schema.children)}
+      {schema.label || renderChildren(schema.children)}
     </Toggle>
   ),
   {

packages/components/src/renderers/navigation/sidebar.tsx

@@ -37,7 +37,7 @@ ComponentRegistry.register('sidebar-provider',
 );
 
 ComponentRegistry.register('sidebar', 
-  ({ schema, ...props }) => (
+  ({ schema, ...props }: { schema: SidebarSchema; [key: string]: any }) => (
     <Sidebar {...props}>{renderChildren(schema.body)}</Sidebar>
   ),
   {

packages/components/src/renderers/overlay/context-menu.tsx

@@ -43,7 +43,7 @@ const renderContextMenuItems = (items: any[]) => {
 };
 
 ComponentRegistry.register('context-menu', 
-  ({ schema, className, ...props }) => (
+  ({ schema, className, ...props }: { schema: ContextMenuSchema; className?: string; [key: string]: any }) => (
     <ContextMenu modal={schema.modal} {...props}>
       <ContextMenuTrigger asChild>
           {/* Usually a Right Click area */}

packages/components/src/renderers/overlay/dropdown-menu.tsx

@@ -44,7 +44,7 @@ const renderMenuItems = (items: any[]) => {
 };
 
 ComponentRegistry.register('dropdown-menu', 
-  ({ schema, className, ...props }) => (
+  ({ schema, className, ...props }: { schema: DropdownMenuSchema; className?: string; [key: string]: any }) => (
     <DropdownMenu modal={schema.modal} defaultOpen={schema.defaultOpen} {...props}>
       <DropdownMenuTrigger asChild>
          {renderChildren(schema.trigger)}