Skip to content

Commit 471a5af

Browse files
committed
Refactor imports in ObjectGalleryIntegration test; consolidate ListView and ObjectGallery imports for cleaner code structure
1 parent df4dab0 commit 471a5af

4 files changed

Lines changed: 5 additions & 11 deletions

File tree

apps/console/src/__tests__/ObjectGalleryIntegration.test.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,7 @@
22
import { describe, it, expect, vi, beforeEach } from 'vitest';
33
import { render, screen, act, waitFor } from '@testing-library/react';
44
import '@testing-library/jest-dom';
5-
import { ListView } from '@object-ui/plugin-list';
6-
import { ObjectGallery } from '@object-ui/plugin-list/ObjectGallery';
5+
import { ListView, ObjectGallery } from '@object-ui/plugin-list';
76
import { ComponentRegistry } from '@object-ui/core';
87
import { SchemaRendererProvider } from '@object-ui/react';
98

packages/plugin-list/src/ListView.tsx

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -256,11 +256,6 @@ export const ListView: React.FC<ListViewProps> = ({
256256
<div className="relative flex-1 max-w-md">
257257
<Search className="absolute left-2 top-1/2 -translate-y-1/2 h-4 w-4 text-muted-foreground" />
258258
<Input
259-
schema={viewComponentSchema}
260-
{...props}
261-
data={data} // Pass data to children to avoid double-fetch
262-
loading={loading}
263-
264259
placeholder={`Search ${schema.objectName}...`}
265260
value={searchTerm}
266261
onChange={(e) => handleSearchChange(e.target.value)}

packages/plugin-list/src/index.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,10 @@
99
import { ComponentRegistry } from '@object-ui/core';
1010
import { ListView } from './ListView';
1111
import { ViewSwitcher } from './ViewSwitcher';
12-
import './ObjectGallery';
12+
import { ObjectGallery } from './ObjectGallery';
1313
import type { ListViewSchema } from '@object-ui/types';
1414

15-
export { ListView, ViewSwitcher };
15+
export { ListView, ViewSwitcher, ObjectGallery };
1616
export type { ListViewProps } from './ListView';
1717
export type { ViewSwitcherProps, ViewType } from './ViewSwitcher';
1818

packages/plugin-timeline/src/index.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -285,9 +285,9 @@ import { ObjectTimeline } from './ObjectTimeline';
285285
import { useSchemaContext } from '@object-ui/react';
286286

287287
// Register object-timeline component
288-
export const ObjectTimelineRenderer: React.FC<{ schema: any }> = ({ schema }) => {
288+
export const ObjectTimelineRenderer: React.FC<any> = ({ schema, ...props }) => {
289289
const { dataSource } = useSchemaContext();
290-
return <ObjectTimeline schema={schema} dataSource={dataSource} />;
290+
return <ObjectTimeline schema={schema} dataSource={dataSource} {...props} />;
291291
};
292292

293293
ComponentRegistry.register('object-timeline', ObjectTimelineRenderer, {

0 commit comments

Comments
 (0)