Commit 4a51e77
refactor(fields,layout,plugin-detail,plugin-grid,collaboration,plugin-charts,plugin-form,providers,runner,sdui-parser)!: burn ledger batch 7 — 14 symbols stop wearing spec names (#3224)
objectui#3161, objectstack#4115 ledger batch 7 — the long tail, one or two
entries per package. All ten packages leave the ledger (17 -> 3 collisions,
11 -> 1 packages; what remains is batch 8's @object-ui/types trio, untouched).
Verdicts, per SYMBOL rather than per cluster:
@object-ui/fields
- isFileIdToken -> re-export. The local copy was character-for-character
identical to the spec's function while its comment claimed to "mirror" it,
so every behaviour test passed against it and only reference identity could
tell the two apart (objectui#3003, re-proved on isAggregatedViewContainer in
objectui#3169). The regex is a wire decision: widen it server-side while a
copy here keeps the old bound and every new id reads as "not a reference".
- FieldWidgetProps -> FieldWidgetComponentProps (spec's is the DECLARED
widget-plugin props contract). The two disagree on the validation-message
key — spec `error`, objectui `errorMessage` — filed as objectui#3222; the
`[key: string]: any` that hid it is objectui#3221.
@object-ui/layout
- PageHeaderProps -> PageHeaderComponentProps, the name app-shell already
chose for the same split in objectui#3169, reused rather than re-invented.
- Page -> PageNodeRenderer. The spec's Page is the authored page
DOCUMENT; this renders types' PageNodeSchema, the SDUI NODE that
objectui#3074 had already renamed off PageSchema. Unregistered and `& any`:
objectui#3223.
@object-ui/plugin-detail
- FeedFilterMode -> re-export (a hand copy of the spec enum, in a file that
already imported FeedItemType from the same spec subpath).
- ObjectFieldLike -> ObjectDefFieldLike. The spec's is the i18n duck type
translateObject walks, and it ends in `[key: string]: any` — deriving would
trade a precise three-key layout contract for a bag (objectstack#4075 from
the spec's side).
@object-ui/plugin-grid
- ColumnSummaryConfig -> ColumnSummarySetting, derived as
NonNullable<ListColumn['summary']>. The spec owns that name for the OBJECT
form ALONE, so the local declaration wore it for a strictly WIDER type: code
written here accepted 'sum', the same name imported from the spec rejects
it. The eleven-member union beside it is the spec's ColumnSummary enum now
instead of a hand copy under a comment promising lockstep, which turns the
total Record<ColumnSummaryType, string> label map into the thing that
reports a divergence.
- isMultiValueField -> hasMultiValueShape, delegating to the spec function it
used to shadow. The two had different PRECONDITIONS (the spec's requires a
def with a `type`; this one is called with `objectFields?.[name]`), which is
worse than a plain fork: an import swapped between the modules keeps
compiling and changes behaviour only on the missing-field path.
@object-ui/collaboration
- RealtimeConfig -> RealtimeSubscriptionConfig (spec's is the app-level
realtime declaration; this is one browser socket's dial settings). Zero
shared declared keys — measured against the spec's own schema shape at
runtime, because the spec declares that schema as a PASSTHROUGH object and a
type-level key comparison against a bag answers nothing.
@object-ui/plugin-charts
- ChartConfig -> ChartContainerConfig. The one collision in this batch that
had already produced ambiguity in read code: AdvancedChartImpl declared
`config?: ChartConfig` meaning the shadcn per-series style map, lines from
comments reading "Spec `ChartConfig.yAxis`" meaning the authored document.
@object-ui/plugin-form
- FormSection -> FormSectionContainer. Deliberately NOT batch 6's ListView
exemption: ListViewProps.schema takes the spec-derived metadata as one prop,
so that renderer restates nothing, while FormSectionContainerProps takes the
same metadata FLATTENED into individual props — a rival vocabulary. `columns`
stays `1|2|3|4` rather than binding the spec key, which accepts the string
forms and normalises them in its own pipe; the pin fails if that changes.
@object-ui/providers
- Theme -> ThemePreference, derived from the spec's ThemeMode input plus the
legacy 'system' spelling. Neither of the two shapes the triage note
predicted: it was Theme['mode'] wearing Theme's name, i.e. a string union
standing where the spec has a whole document. ThemeMode, the spec's own name
for it, is a spec export too — the objectui#3169 rule again.
@object-ui/runner
- App -> RunnerApp (spec owns App for the authored application metadata AND
the App.create() builder). A default export, so no consumer churn.
@object-ui/sdui-parser
- ValidationResult -> ManifestValidationResult, per the
<what was validated>Validation<Error|Result> convention registered on
objectstack#4115; core took SchemaNodeValidationResult in batch 4.
Renames are by identifier boundary, per package, no global replace; not one
string literal changed (the `form-section` CSS class, component keys, error
names). Docs that named the renamed public types are updated with them
(content/docs, skills/objectui).
Verification: `--ledger` regenerated and set-diffed — removed is exactly these
14, added empty, @object-ui/types byte-identical. Guard green; turbo type-check
78/78 (full repo); full suite 834 files / 9746 tests passed, 0 failed; ESLint on
changed files 0 errors. plugin-detail/plugin-grid/plugin-form gained a
tsconfig.typetests.json chained off type-check (their test trees are still in
TEST_DEBT, so nothing would have compiled the new pins — objectui#3181);
collaboration gained a tsconfig.test.json with its first test file.
Five mutation directions, all red: re-forking isFileIdToken byte-for-byte
(guard by name+file, and the reference-identity assertion — while all 20+
behaviour assertions in file-value.test.ts stayed green); restoring the original
hand-written Theme (guard); re-forking the derived ColumnSummaryType with one
member dropped (the runtime spec-vocabulary test names the missing member, and
the typetests pin fails); leaving a burned name in DEBT (rotting ratchet);
unchaining a tsconfig.typetests.json (type-check coverage ratchet). A sixth
records a known hole: renaming ThemePreference back to `Theme` while KEEPING the
derivation passes the guard — derivation is derivation, batch 5's
ConflictResolutionStrategy trap — and is caught only by the tripwire test, which
is why every rename here has one.
Claude-Session: https://claude.ai/code/session_01PRJtkgUAaVG11FsJQbvZWA
Co-authored-by: Claude <noreply@anthropic.com>1 parent c5ccbd5 commit 4a51e77
109 files changed
Lines changed: 1565 additions & 297 deletions
File tree
- .changeset
- content/docs
- guide
- layout
- examples/byo-backend-console/src
- packages
- app-shell/src/utils
- collaboration
- src
- __tests__
- fields
- src
- __tests__
- widgets
- layout
- src
- __tests__
- plugin-charts/src
- __tests__
- plugin-detail
- src
- __tests__
- synth
- plugin-form
- src
- __tests__
- plugin-grid
- src
- __tests__
- components
- hooks
- providers
- src
- __tests__
- runner
- src
- __tests__
- sdui-parser
- src
- __tests__
- scripts
- skills/objectui/guides
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
176 | 176 | | |
177 | 177 | | |
178 | 178 | | |
179 | | - | |
| 179 | + | |
180 | 180 | | |
181 | 181 | | |
182 | | - | |
183 | | - | |
| 182 | + | |
| 183 | + | |
184 | 184 | | |
185 | 185 | | |
186 | 186 | | |
| |||
197 | 197 | | |
198 | 198 | | |
199 | 199 | | |
200 | | - | |
| 200 | + | |
201 | 201 | | |
202 | 202 | | |
203 | 203 | | |
| |||
206 | 206 | | |
207 | 207 | | |
208 | 208 | | |
209 | | - | |
| 209 | + | |
210 | 210 | | |
211 | 211 | | |
212 | 212 | | |
| |||
435 | 435 | | |
436 | 436 | | |
437 | 437 | | |
438 | | - | |
| 438 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
28 | | - | |
| 28 | + | |
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
179 | 179 | | |
180 | 180 | | |
181 | 181 | | |
182 | | - | |
| 182 | + | |
183 | 183 | | |
184 | 184 | | |
185 | 185 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
47 | | - | |
| 47 | + | |
48 | 48 | | |
49 | 49 | | |
50 | 50 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
33 | | - | |
| 33 | + | |
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
| 43 | + | |
43 | 44 | | |
44 | 45 | | |
45 | 46 | | |
| |||
Lines changed: 98 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
25 | | - | |
| 25 | + | |
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
12 | | - | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
13 | 27 | | |
14 | 28 | | |
15 | 29 | | |
| |||
62 | 76 | | |
63 | 77 | | |
64 | 78 | | |
65 | | - | |
| 79 | + | |
66 | 80 | | |
67 | 81 | | |
68 | 82 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
0 commit comments