Skip to content

Commit 5b44548

Browse files
Copilothotlong
andcommitted
fix: use turbo build in playwright webServer and add build step to CI e2e job
The e2e CI job was failing because the webServer command ran `pnpm --filter @object-ui/console build` which runs tsc directly. tsc failed (exit code 2) because workspace packages' dist/ directories didn't exist (the build job runs on a separate VM and artifacts aren't shared). Changes: - playwright.config.ts: Use `turbo run build` which properly builds dependencies before the console (respects ^build dependency chain) - ci.yml: Add explicit build step before Playwright tests, so the webServer's turbo build is a cache hit (~320ms) Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
1 parent d756e97 commit 5b44548

2 files changed

Lines changed: 4 additions & 1 deletion

File tree

.github/workflows/ci.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -145,6 +145,9 @@ jobs:
145145
- name: Install dependencies
146146
run: pnpm install --frozen-lockfile
147147

148+
- name: Build packages and console
149+
run: pnpm turbo run build --filter='./packages/*' --filter='./apps/console'
150+
148151
- name: Install Playwright browsers
149152
run: pnpm exec playwright install --with-deps chromium
150153

playwright.config.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ export default defineConfig({
6262
* caused by build-time errors (broken imports, missing polyfills, etc.).
6363
*/
6464
webServer: {
65-
command: 'pnpm --filter @object-ui/console build && pnpm --filter @object-ui/console preview --port 4173',
65+
command: 'pnpm turbo run build --filter=@object-ui/console && pnpm --filter @object-ui/console preview --port 4173',
6666
url: 'http://localhost:4173',
6767
reuseExistingServer: !process.env.CI,
6868
timeout: 180 * 1000,

0 commit comments

Comments
 (0)