Merge pull request #1027 from objectstack-ai/copilot/remove-core-composestacks-implementation

Author: hotlong

ROADMAP.md

@@ -1166,7 +1166,7 @@ The `FlowDesigner` is a canvas-based flow editor that bridges the gap between th
 
 ### P2.6 Plugin Modularization & Dynamic Management
 
-> **Status:** Phase 1 complete — Plugin class standard, install/uninstall API, example plugin classes. Phase 1.5 complete — composeStacks, plugin isolation, duplicate merge removal.
+> **Status:** Phase 1 complete — Plugin class standard, install/uninstall API, example plugin classes. Phase 1.5 complete — composeStacks unified to `@objectstack/spec`, plugin isolation, duplicate merge removal.
 
 Plugin architecture refactoring to support true modular development, plugin isolation, and dynamic plugin install/uninstall at runtime.
 
@@ -1188,11 +1188,10 @@ Plugin architecture refactoring to support true modular development, plugin isol
 - [x] Remove duplicate `mergeActionsIntoObjects()` from root config and console shared config
 - [x] Remove duplicate `mergeViewsIntoObjects()` from root config and console shared config (moved into `composeStacks`)
 - [x] Refactor root `objectstack.config.ts` and `apps/console/objectstack.shared.ts` to use `composeStacks()`
-- [x] Unit tests for `composeStacks()` (15 tests covering merging, dedup, views, actions, cross-stack, conflict detection)
 - [x] Eliminate `defineStack()` double-pass hack — single `composeStacks()` call produces final config with runtime properties (listViews, actions) preserved. `defineStack()` Zod validation stripped these fields, requiring a second `composeStacks` pass to restore them.
 - [x] Use `composed.apps` unified flow in console shared config — replaced manual `[...crmApps, ...(todoConfig.apps || []), ...]` spreading with CRM navigation patch applied to composed output
 - [x] Use `composed.reports` in console shared config — replaced `...(crmConfig.reports || [])` with `...(composed.reports || [])` to include reports from all stacks
-- [x] **composeStacks responsibility split:** `@object-ui/core` composeStacks handles runtime mapping (merging views→objects listViews, actions→objects) while `@objectstack/spec` composeStacks handles protocol-level composition (broader field concatenation, manifest selection, i18n). ObjectUI apps use the core version for single-pass config with runtime properties preserved.
+- [x] **composeStacks unified to `@objectstack/spec`:** Removed `@object-ui/core` composeStacks implementation and its 15-test suite (coverage now lives upstream in `@objectstack/spec`). All config composition now uses `composeStacks` from `@objectstack/spec` (protocol-level: object dedup, array concatenation, actions→objects mapping, manifest selection, i18n). Runtime-specific `mergeViewsIntoObjects` adapter extracted to `@object-ui/core` and applied post-composition at call sites. A deprecated re-export of `composeStacks` is kept in `@object-ui/core` for backward compatibility.
 
 **Phase 2 — Dynamic Plugin Loading (Planned)**
 - [ ] Hot-reload / lazy loading of plugins for development
@@ -1242,7 +1241,7 @@ Plugin architecture refactoring to support true modular development, plugin isol
 - [x] **P1: Chart Widget Server-Side Aggregation** — Fixed chart widgets (bar/line/area/pie/donut/scatter) downloading all raw data and aggregating client-side. Added optional `aggregate()` method to `DataSource` interface (`AggregateParams`, `AggregateResult` types) enabling server-side grouping/aggregation via analytics API (e.g. `GET /api/v1/analytics/{resource}?category=…&metric=…&agg=…`). `ObjectChart` now prefers `dataSource.aggregate()` when available, falling back to `dataSource.find()` + client-side aggregation for backward compatibility. Implemented `aggregate()` in `ValueDataSource` (in-memory), `ApiDataSource` (HTTP), and `ObjectStackAdapter` (analytics API with client-side fallback). Only detail widgets (grid/table/list) continue to fetch full data. 9 new tests.
 - [x] **P1: Spec-Aligned CRM I18n** — Fixed CRM internationalization not taking effect on the console. Root cause: CRM metadata used plain string labels instead of spec-aligned `I18nLabel` objects. Fix: (1) Updated CRM app/dashboard/navigation metadata to use `I18nLabel` objects (`{ key, defaultValue }`) per spec. (2) Updated `NavigationItem` and `NavigationArea` types to support I18nLabel. (3) Added `resolveLabel()` helper in NavigationRenderer. (4) Updated `resolveI18nLabel()` to accept `t()` function for translation. (5) Added `loadLanguage` callback in I18nProvider for API-based translation loading. (6) Added `/api/v1/i18n/:lang` endpoint to mock server. Console contains zero CRM-specific code.
 - [x] **P0: Opportunity List View & ObjectDef Column Enrichment** — Fixed ObjectGrid not using objectDef field metadata for type-aware rendering when columns are `string[]` or `ListColumn[]` without full options. (1) Schema resolution always fetches full schema from DataSource for field type metadata. (2) String[] column path enriched with objectDef types, options (with colors), currency, precision for proper CurrencyCellRenderer, SelectCellRenderer (colored badges), PercentCellRenderer, DateCellRenderer. (3) ListColumn[] fieldMeta deep-merged with objectDef field properties (select options with colors, currency code, precision). (4) Opportunity view columns upgraded from bare `string[]` to `ListColumn[]` with explicit types, alignment, and summary aggregation. 9 new tests.
-- [x] **P1: Actions Merge into Object Definitions** — Fixed action buttons never showing in Console/Studio because example object definitions lacked `actions` field. Initially added `mergeActionsIntoObjects()` helper with longest-prefix name matching. Later refactored: all actions now declare explicit `objectName`, and merging is handled by `composeStacks()` in `@object-ui/core`. Created todo task actions (6: complete, start, clone, defer, set_reminder, assign) and kitchen-sink showcase actions (3: change_status, assign_owner, archive). All CRM/Todo/Kitchen Sink objects now serve `actions` in metadata. Fixes #840.
+- [x] **P1: Actions Merge into Object Definitions** — Fixed action buttons never showing in Console/Studio because example object definitions lacked `actions` field. Initially added `mergeActionsIntoObjects()` helper with longest-prefix name matching. Later refactored: all actions now declare explicit `objectName`, and merging is handled by `composeStacks()` from `@objectstack/spec`. Created todo task actions (6: complete, start, clone, defer, set_reminder, assign) and kitchen-sink showcase actions (3: change_status, assign_owner, archive). All CRM/Todo/Kitchen Sink objects now serve `actions` in metadata. Fixes #840.
 - [x] **P1: Unified Debug/Metadata Entry — Remove Redundant Metadata Button** — Removed the visible `<MetadataToggle>` button from RecordDetailView, DashboardView, PageView, and ReportView headers. End users no longer see a "</> Metadata" button that had no practical purpose. The MetadataInspector panel is now only accessible via `?__debug` URL parameter (auto-opens when debug mode is active). ObjectView retains its admin-only Design Tools menu entry for metadata inspection. This unifies the debug entry point and improves end-user UX by removing redundant UI elements.
 
 ### Ecosystem & Marketplace

apps/console/objectstack.shared.ts

@@ -1,5 +1,6 @@
 import type { ObjectStackDefinition } from '@objectstack/spec';
-import { composeStacks } from '@object-ui/core';
+import { composeStacks } from '@objectstack/spec';
+import { mergeViewsIntoObjects } from '@object-ui/core';
 import crmConfigImport from '@object-ui/example-crm/objectstack.config';
 import todoConfigImport from '@object-ui/example-todo/objectstack.config';
 import kitchenSinkConfigImport from '@object-ui/example-kitchen-sink/objectstack.config';
@@ -17,14 +18,20 @@ const crmConfig = resolveDefault<ObjectStackDefinition>(crmConfigImport);
 const todoConfig = resolveDefault<ObjectStackDefinition>(todoConfigImport);
 const kitchenSinkConfig = resolveDefault<ObjectStackDefinition>(kitchenSinkConfigImport);
 
-// Single-pass composition: composeStacks handles object deduplication (override),
-// views→objects mapping, and actions→objects assignment via objectName.
-// No defineStack() validation pass — it would strip runtime properties (listViews,
-// actions) from objects, requiring a double-pass hack to restore them.
-const composed = composeStacks(
-  [crmConfig, todoConfig, kitchenSinkConfig] as Record<string, any>[],
-  { objectConflict: 'override' },
-);
+const allConfigs = [crmConfig, todoConfig, kitchenSinkConfig];
+
+// Aggregate seed data from all manifest.data arrays (spec selects one manifest,
+// so we collect data from all stacks before composing).
+const allData = allConfigs.flatMap((c: any) => c.manifest?.data || c.data || []);
+
+// Protocol-level composition via @objectstack/spec: handles object dedup,
+// array concatenation, actions→objects mapping, and manifest selection.
+const composed = composeStacks(allConfigs as any[], { objectConflict: 'override' }) as any;
+
+// Adapter: merge views[].listViews into object definitions for the runtime.
+if (composed.objects && composed.views) {
+  composed.objects = mergeViewsIntoObjects(composed.objects, composed.views);
+}
 
 // Patch CRM App Navigation to include Report using a supported navigation type
 // (type: 'url' passes schema validation while still routing correctly via React Router)
@@ -80,7 +87,7 @@ export const sharedConfig = {
     version: '0.1.0',
     type: 'app',
     name: '@object-ui/console',
-    data: composed.manifest.data,
+    data: allData,
   },
   plugins: [],
   datasources: [

objectstack.config.ts

@@ -19,7 +19,8 @@ import { ObjectQLPlugin } from '@objectstack/objectql';
 import { InMemoryDriver } from '@objectstack/driver-memory';
 import { HonoServerPlugin } from '@objectstack/plugin-hono-server';
 import { ConsolePlugin } from '@object-ui/console';
-import { composeStacks } from '@object-ui/core';
+import { composeStacks } from '@objectstack/spec';
+import { mergeViewsIntoObjects } from '@object-ui/core';
 import { CRMPlugin } from './examples/crm/plugin';
 import { TodoPlugin } from './examples/todo/plugin';
 import { KitchenSinkPlugin } from './examples/kitchen-sink/plugin';
@@ -33,11 +34,18 @@ const allConfigs = plugins.map((p) => {
   return (raw as any).default || raw;
 });
 
-// Single-pass composition: composeStacks handles object deduplication,
-// views→objects mapping, and actions→objects assignment via objectName.
-// No defineStack() validation pass needed — it would strip runtime properties
-// (listViews, actions) from objects, requiring a second merge pass to restore them.
-const composed = composeStacks(allConfigs, { objectConflict: 'override' });
+// Aggregate seed data from all manifest.data arrays (spec selects one manifest,
+// so we collect data from all stacks before composing).
+const allData = allConfigs.flatMap((c: any) => c.manifest?.data || c.data || []);
+
+// Protocol-level composition via @objectstack/spec: handles object dedup,
+// array concatenation, actions→objects mapping, and manifest selection.
+const composed = composeStacks(allConfigs as any[], { objectConflict: 'override' }) as any;
+
+// Adapter: merge views[].listViews into object definitions for the runtime.
+if (composed.objects && composed.views) {
+  composed.objects = mergeViewsIntoObjects(composed.objects, composed.views);
+}
 
 const mergedApp = {
   ...composed,
@@ -47,7 +55,7 @@ const mergedApp = {
     version: '0.0.0',
     description: 'ObjectUI monorepo development workspace',
     type: 'app',
-    data: composed.manifest.data,
+    data: allData,
   },
 };
 

packages/core/src/index.ts

@@ -26,5 +26,13 @@ export * from './data-scope/index.js';
 export * from './errors/index.js';
 export * from './utils/debug.js';
 export * from './utils/debug-collector.js';
-export * from './utils/compose-stacks.js';
+export * from './utils/merge-views-into-objects.js';
 export * from './protocols/index.js';
+
+/**
+ * @deprecated Import `composeStacks` from `@objectstack/spec` instead.
+ *
+ * This re-export is kept only for backward compatibility and will be removed
+ * in the next major version of `@object-ui/core`.
+ */
+export { composeStacks } from '@objectstack/spec';