Merge pull request #920 from objectstack-ai/copilot/fix-row-click-issue

Author: hotlong

ROADMAP.md

@@ -1191,6 +1191,14 @@ The `FlowDesigner` is a canvas-based flow editor that bridges the gap between th
 
 **Tests:** All 32 ObjectView tests and 29 useNavigationOverlay tests pass.
 
+### App.tsx handleRowClick Overriding All Navigation Modes (February 2026)
+
+**Root Cause:** `App.tsx` defined a `handleRowClick` that hardcoded `setSearchParams({recordId})` (drawer-only behavior) and passed it unconditionally to `<ObjectView>` via `onRowClick={handleRowClick}`. This overrode the internal `navOverlay.handleClick` in Console's `ObjectView`, preventing page/modal/split/popover/new_window navigation modes from working.
+
+**Fix:** Removed `handleRowClick` from `App.tsx` and the `onRowClick` prop from both `<ObjectView>` route elements. Updated Console `ObjectView` to always use `navOverlay.handleClick` (3 locations) instead of falling back to the external `onRowClick` prop. Removed the unused `onRowClick` prop from the `ObjectView` function signature.
+
+**Tests:** All 42 ObjectView tests and 33 useNavigationOverlay tests pass (3 new tests added).
+
 ### ListView Multi-Navigation Mode Support — split/popover/page/new_window (February 2026)
 
 **Root Cause:** While `drawer`/`modal` modes worked in the Console ObjectView, the remaining 4 navigation modes had gaps:

apps/console/src/App.tsx

@@ -1,4 +1,4 @@
-import { BrowserRouter, Routes, Route, Navigate, useNavigate, useLocation, useSearchParams } from 'react-router-dom';
+import { BrowserRouter, Routes, Route, Navigate, useNavigate, useLocation } from 'react-router-dom';
 import { useState, useEffect, useCallback, lazy, Suspense, useMemo, type ReactNode } from 'react';
 import { ModalForm } from '@object-ui/plugin-form';
 import { Empty, EmptyTitle, EmptyDescription, Button } from '@object-ui/components';
@@ -90,7 +90,6 @@ export function AppContent() {
   // App Selection
   const navigate = useNavigate();
   const location = useLocation();
-  const [, setSearchParams] = useSearchParams();
   const { appName } = useParams();
   const { apps, objects: allObjects, loading: metadataLoading } = useMetadata();
 
@@ -230,18 +229,6 @@ export function AppContent() {
     setIsDialogOpen(true);
   };
 
-  const handleRowClick = (record: any) => {
-     const id = record._id || record.id;
-     if (id) {
-        // Open Drawer
-        setSearchParams(prev => {
-            const next = new URLSearchParams(prev);
-            next.set('recordId', id);
-            return next;
-        });
-     }
-  };
-
   const handleAppChange = (newAppName: string) => {
       navigate(`/apps/${newAppName}`);
   };
@@ -347,7 +334,6 @@ export function AppContent() {
                 dataSource={dataSource} 
                 objects={allObjects} 
                 onEdit={handleEdit} 
-                onRowClick={handleRowClick}
             />
         } />
 
@@ -357,7 +343,6 @@ export function AppContent() {
                 dataSource={dataSource} 
                 objects={allObjects} 
                 onEdit={handleEdit} 
-                onRowClick={handleRowClick}
             />
         } />
 

apps/console/src/__tests__/ObjectView.test.tsx

@@ -934,4 +934,39 @@ describe('ObjectView Component', () => {
         // ViewConfigPanel should be open in edit mode
         expect(screen.getByTestId('view-config-panel')).toBeInTheDocument();
     });
+
+    it('navigates to record detail in page mode even if an onRowClick prop is passed (prop is ignored)', () => {
+        const externalRowClick = vi.fn();
+        const objectsWithPage = [{
+            ...mockObjects[0],
+            navigation: { mode: 'page' as const },
+        }];
+        mockUseParams.mockReturnValue({ objectName: 'opportunity' });
+        render(<ObjectView dataSource={mockDataSource} objects={objectsWithPage} onEdit={vi.fn()} onRowClick={externalRowClick} />);
+        fireEvent.click(screen.getByTestId('list-row-click'));
+        expect(mockNavigate).toHaveBeenCalledWith('record/rec-1');
+        expect(externalRowClick).not.toHaveBeenCalled();
+    });
+
+    it('navigates to record detail when no navigation config and no onRowClick', () => {
+        mockUseParams.mockReturnValue({ objectName: 'opportunity' });
+        render(<ObjectView dataSource={mockDataSource} objects={mockObjects} onEdit={vi.fn()} />);
+        fireEvent.click(screen.getByTestId('list-row-click'));
+        expect(mockNavigate).toHaveBeenCalledWith('record/rec-1');
+    });
+
+    it('opens drawer overlay instead of navigating for drawer navigation mode', () => {
+        const objectsWithDrawer = [{
+            ...mockObjects[0],
+            navigation: { mode: 'drawer' as const },
+        }];
+        mockUseParams.mockReturnValue({ objectName: 'opportunity' });
+        const dataSourceWithFindOne = {
+            ...mockDataSource,
+            findOne: vi.fn().mockResolvedValue({ _id: 'rec-1', id: 'rec-1', name: 'Test' }),
+        };
+        render(<ObjectView dataSource={dataSourceWithFindOne} objects={objectsWithDrawer} onEdit={vi.fn()} />);
+        fireEvent.click(screen.getByTestId('list-row-click'));
+        expect(mockNavigate).not.toHaveBeenCalledWith(expect.stringContaining('record/'));
+    });
 });

apps/console/src/components/ObjectView.tsx

@@ -245,7 +245,7 @@ function DrawerDetailContent({ objectDef, recordId, dataSource, onEdit }: {
     );
 }
 
-export function ObjectView({ dataSource, objects, onEdit, onRowClick }: any) {
+export function ObjectView({ dataSource, objects, onEdit }: any) {
     const navigate = useNavigate();
     const { objectName, viewId } = useParams();
     const [searchParams, setSearchParams] = useSearchParams();
@@ -484,7 +484,7 @@ export function ObjectView({ dataSource, objects, onEdit, onRowClick }: any) {
     }, [drawerRecordId]);
 
     // Render multi-view content via ListView plugin (for kanban, calendar, etc.)
-    const renderListView = useCallback(({ schema: listSchema, dataSource: ds, onEdit: editHandler, onRowClick: rowClickHandler, className }: any) => {
+    const renderListView = useCallback(({ schema: listSchema, dataSource: ds, onEdit: editHandler, className }: any) => {
         const key = `${objectName}-${activeView.id}-${refreshKey}`;
         const viewDef = activeView;
 
@@ -638,9 +638,9 @@ export function ObjectView({ dataSource, objects, onEdit, onRowClick }: any) {
                 schema={fullSchema}
                 className={className}
                 onEdit={editHandler}
-                onRowClick={rowClickHandler || ((record: any) => {
+                onRowClick={(record: any) => {
                     navOverlay.handleClick(record);
-                })}
+                }}
                 dataSource={ds}
             />
         );
@@ -832,9 +832,9 @@ export function ObjectView({ dataSource, objects, onEdit, onRowClick }: any) {
                                         activeViewId={activeViewId}
                                         onViewChange={handleViewChange}
                                         onEdit={(record: any) => onEdit?.(record)}
-                                        onRowClick={onRowClick || ((record: any) => {
+                                        onRowClick={(record: any) => {
                                             navOverlay.handleClick(record);
-                                        })}
+                                        }}
                                         renderListView={renderListView}
                                         onCreateView={handleCreateView}
                                         onViewAction={handleViewAction}
@@ -870,9 +870,9 @@ export function ObjectView({ dataSource, objects, onEdit, onRowClick }: any) {
                             activeViewId={activeViewId}
                             onViewChange={handleViewChange}
                             onEdit={(record: any) => onEdit?.(record)}
-                            onRowClick={onRowClick || ((record: any) => {
+                            onRowClick={(record: any) => {
                                 navOverlay.handleClick(record);
-                            })}
+                            }}
                             renderListView={renderListView}
                             onCreateView={handleCreateView}
                             onViewAction={handleViewAction}