|
| 1 | +import { describe, it, expect } from 'vitest'; |
| 2 | +import { MANAGED_BY_BUCKETS } from '@object-ui/types'; |
| 3 | +import { |
| 4 | + resolveCrudAffordances, |
| 5 | + isWriteOptedIn, |
| 6 | + isSystemWritable, |
| 7 | + isObjectInlineEditable, |
| 8 | +} from './managedBy'; |
| 9 | + |
| 10 | +describe('resolveCrudAffordances (shared source of truth)', () => { |
| 11 | + it('defaults to the platform bucket (full CRUD) when managedBy is unset', () => { |
| 12 | + expect(resolveCrudAffordances({})).toEqual({ |
| 13 | + create: true, import: true, edit: true, delete: true, exportCsv: true, |
| 14 | + }); |
| 15 | + expect(resolveCrudAffordances(null)).toEqual(resolveCrudAffordances({ managedBy: 'platform' })); |
| 16 | + }); |
| 17 | + |
| 18 | + it('config: New/Edit/Delete + export, no import', () => { |
| 19 | + expect(resolveCrudAffordances({ managedBy: 'config' })).toEqual({ |
| 20 | + create: true, import: false, edit: true, delete: true, exportCsv: true, |
| 21 | + }); |
| 22 | + }); |
| 23 | + |
| 24 | + it('system / append-only / better-auth: export-only by default', () => { |
| 25 | + for (const managedBy of ['system', 'append-only', 'better-auth']) { |
| 26 | + expect(resolveCrudAffordances({ managedBy })).toEqual({ |
| 27 | + create: false, import: false, edit: false, delete: false, exportCsv: true, |
| 28 | + }); |
| 29 | + } |
| 30 | + }); |
| 31 | + |
| 32 | + it('userActions overrides the bucket default (ADR-0103 writable system)', () => { |
| 33 | + const aff = resolveCrudAffordances({ managedBy: 'system', userActions: { create: true, edit: true, delete: true } }); |
| 34 | + expect(aff).toMatchObject({ create: true, edit: true, delete: true, import: false }); |
| 35 | + }); |
| 36 | + |
| 37 | + it('unknown bucket falls back to platform (defensive)', () => { |
| 38 | + expect(resolveCrudAffordances({ managedBy: 'totally-unknown' }).edit).toBe(true); |
| 39 | + }); |
| 40 | + |
| 41 | + it('#2614 object form: carries predicates, keys off enabled, boolean path unchanged', () => { |
| 42 | + const withPreds = resolveCrudAffordances({ |
| 43 | + managedBy: 'platform', |
| 44 | + userActions: { edit: { enabled: true, disabledWhen: 'record.locked == true' } }, |
| 45 | + }); |
| 46 | + expect(withPreds.edit).toBe(true); |
| 47 | + expect(withPreds.editPredicates).toEqual({ disabledWhen: 'record.locked == true' }); |
| 48 | + // enabled omitted → falls back to the bucket default (platform edit = true) |
| 49 | + expect(resolveCrudAffordances({ managedBy: 'platform', userActions: { edit: { disabledWhen: 'x' } } }).edit).toBe(true); |
| 50 | + // boolean form leaves predicates absent |
| 51 | + expect(resolveCrudAffordances({ managedBy: 'system', userActions: { edit: true } }).editPredicates).toBeUndefined(); |
| 52 | + }); |
| 53 | +}); |
| 54 | + |
| 55 | +describe('isWriteOptedIn', () => { |
| 56 | + it('true only for boolean true or { enabled: true }', () => { |
| 57 | + expect(isWriteOptedIn(true)).toBe(true); |
| 58 | + expect(isWriteOptedIn({ enabled: true })).toBe(true); |
| 59 | + expect(isWriteOptedIn(false)).toBe(false); |
| 60 | + expect(isWriteOptedIn({ enabled: false })).toBe(false); |
| 61 | + expect(isWriteOptedIn({ disabledWhen: 'x' })).toBe(false); |
| 62 | + expect(isWriteOptedIn(undefined)).toBe(false); |
| 63 | + expect(isWriteOptedIn(null)).toBe(false); |
| 64 | + }); |
| 65 | +}); |
| 66 | + |
| 67 | +describe('isSystemWritable (ADR-0103)', () => { |
| 68 | + it('true only for a system object that opened create, edit, or delete', () => { |
| 69 | + expect(isSystemWritable({ managedBy: 'system', userActions: { create: true } })).toBe(true); |
| 70 | + expect(isSystemWritable({ managedBy: 'system', userActions: { edit: { enabled: true } } })).toBe(true); |
| 71 | + expect(isSystemWritable({ managedBy: 'system', userActions: { delete: true } })).toBe(true); |
| 72 | + }); |
| 73 | + it('false for engine-owned system and for other buckets even with userActions', () => { |
| 74 | + expect(isSystemWritable({ managedBy: 'system' })).toBe(false); |
| 75 | + expect(isSystemWritable({ managedBy: 'system', userActions: { edit: false } })).toBe(false); |
| 76 | + // append-only / better-auth are never "system-writable" regardless of userActions |
| 77 | + expect(isSystemWritable({ managedBy: 'append-only', userActions: { create: true } })).toBe(false); |
| 78 | + expect(isSystemWritable({ managedBy: 'better-auth', userActions: { edit: true } })).toBe(false); |
| 79 | + expect(isSystemWritable({ managedBy: 'platform' })).toBe(false); |
| 80 | + expect(isSystemWritable(null)).toBe(false); |
| 81 | + }); |
| 82 | +}); |
| 83 | + |
| 84 | +describe('isObjectInlineEditable', () => { |
| 85 | + it('mirrors the resolved edit affordance (replaces the old NON_EDITABLE_BUCKETS set)', () => { |
| 86 | + // Non-editable buckets by default... |
| 87 | + for (const managedBy of ['system', 'append-only', 'better-auth']) { |
| 88 | + expect(isObjectInlineEditable({ managedBy })).toBe(false); |
| 89 | + } |
| 90 | + // ...editable buckets and opened-up system objects. |
| 91 | + expect(isObjectInlineEditable({ managedBy: 'platform' })).toBe(true); |
| 92 | + expect(isObjectInlineEditable({ managedBy: 'config' })).toBe(true); |
| 93 | + expect(isObjectInlineEditable({ managedBy: 'system', userActions: { edit: true } })).toBe(true); |
| 94 | + // an explicit edit:false disables even on an otherwise-editable bucket |
| 95 | + expect(isObjectInlineEditable({ managedBy: 'platform', userActions: { edit: false } })).toBe(false); |
| 96 | + }); |
| 97 | +}); |
| 98 | + |
| 99 | +describe('MANAGED_BY_BUCKETS', () => { |
| 100 | + it('is the closed 5-bucket union in canonical order', () => { |
| 101 | + expect(MANAGED_BY_BUCKETS).toEqual(['platform', 'config', 'system', 'append-only', 'better-auth']); |
| 102 | + }); |
| 103 | +}); |
0 commit comments