Skip to content

Commit 6eb291b

Browse files
committed
refactor(ObjectForm): remove lifecycle logging and unnecessary console statements
1 parent 61e9d05 commit 6eb291b

File tree

2 files changed

+1
-25
lines changed

2 files changed

+1
-25
lines changed

packages/plugin-form/src/ObjectForm.tsx

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -65,14 +65,6 @@ export const ObjectForm: React.FC<ObjectFormProps> = ({
6565
const [loading, setLoading] = useState(true);
6666
const [error, setError] = useState<Error | null>(null);
6767

68-
// Track component lifecycle
69-
useEffect(() => {
70-
console.log('[ObjectForm] MOUNT - objectName:', schema.objectName, 'hasDataSource:', !!dataSource);
71-
return () => {
72-
console.log('[ObjectForm] UNMOUNT - objectName:', schema.objectName);
73-
};
74-
}, []);
75-
7668
// Check if using inline fields (fields defined as objects, not just names)
7769
const hasInlineFields = schema.customFields && schema.customFields.length > 0;
7870

@@ -91,12 +83,9 @@ export const ObjectForm: React.FC<ObjectFormProps> = ({
9183
if (!dataSource) {
9284
throw new Error('DataSource is required when using ObjectQL schema fetching (inline fields not provided)');
9385
}
94-
console.log('[ObjectForm] Fetching object schema for:', schema.objectName);
9586
const schemaData = await dataSource.getObjectSchema(schema.objectName);
96-
console.log('[ObjectForm] Got schema data:', schemaData?.name, 'fields count:', Object.keys(schemaData?.fields || {}).length);
9787
setObjectSchema(schemaData);
9888
} catch (err) {
99-
console.error('[ObjectForm] Failed to fetch object schema:', err);
10089
setError(err as Error);
10190
}
10291
};
@@ -279,7 +268,6 @@ export const ObjectForm: React.FC<ObjectFormProps> = ({
279268
}
280269
});
281270

282-
console.log('[ObjectForm] Generated fields:', generatedFields.length, 'for objectSchema:', objectSchema?.name);
283271
setFormFields(generatedFields);
284272
setLoading(false);
285273
}, [objectSchema, schema.fields, schema.customFields, schema.readOnly, schema.mode, hasInlineFields]);
@@ -375,7 +363,6 @@ export const ObjectForm: React.FC<ObjectFormProps> = ({
375363
}
376364

377365
// Render loading state
378-
console.log('[ObjectForm] Render check - loading:', loading, 'formFields:', formFields.length, 'objectSchema:', !!objectSchema, 'error:', !!error);
379366
if (loading) {
380367
return (
381368
<div className="p-8 text-center">

packages/plugin-form/src/index.tsx

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -29,17 +29,6 @@ ComponentRegistry.register('object-form', ObjectFormRenderer, {
2929
]
3030
});
3131

32-
// Alias for view namespace - this allows using { type: 'view:form' } in schemas
33-
ComponentRegistry.register('form', ObjectFormRenderer, {
34-
namespace: 'view',
35-
label: 'Data Form',
36-
category: 'view',
37-
inputs: [
38-
{ name: 'objectName', type: 'string', label: 'Object Name', required: true },
39-
{ name: 'fields', type: 'array', label: 'Fields' },
40-
{ name: 'mode', type: 'enum', label: 'Mode', enum: ['create', 'edit', 'view'] },
41-
]
42-
});
43-
4432
// Note: 'form' type is handled by @object-ui/components Form component
4533
// This plugin only handles 'object-form' which integrates with ObjectQL/ObjectStack
34+
// Do NOT register as 'form' - that would conflict with the low-level Form renderer

0 commit comments

Comments
 (0)