|
| 1 | +/** |
| 2 | + * MetadataFormDialog Tests |
| 3 | + * |
| 4 | + * Tests for the generic create/edit dialog driven by the metadata type |
| 5 | + * registry's `formFields` configuration. |
| 6 | + */ |
| 7 | + |
| 8 | +import { describe, it, expect, vi, beforeEach } from 'vitest'; |
| 9 | +import { render, screen, fireEvent, waitFor } from '@testing-library/react'; |
| 10 | +import '@testing-library/jest-dom'; |
| 11 | +import { MetadataFormDialog } from '../components/MetadataFormDialog'; |
| 12 | + |
| 13 | +beforeEach(() => { |
| 14 | + vi.clearAllMocks(); |
| 15 | +}); |
| 16 | + |
| 17 | +describe('MetadataFormDialog', () => { |
| 18 | + const defaultProps = { |
| 19 | + open: true, |
| 20 | + onOpenChange: vi.fn(), |
| 21 | + mode: 'create' as const, |
| 22 | + typeLabel: 'Dashboard', |
| 23 | + onSubmit: vi.fn().mockResolvedValue(undefined), |
| 24 | + }; |
| 25 | + |
| 26 | + describe('create mode', () => { |
| 27 | + it('should render dialog with create title', () => { |
| 28 | + render(<MetadataFormDialog {...defaultProps} />); |
| 29 | + expect(screen.getByText('New Dashboard')).toBeInTheDocument(); |
| 30 | + }); |
| 31 | + |
| 32 | + it('should render default form fields when no formFields provided', () => { |
| 33 | + render(<MetadataFormDialog {...defaultProps} />); |
| 34 | + expect(screen.getByTestId('metadata-field-name')).toBeInTheDocument(); |
| 35 | + expect(screen.getByTestId('metadata-field-label')).toBeInTheDocument(); |
| 36 | + expect(screen.getByTestId('metadata-field-description')).toBeInTheDocument(); |
| 37 | + }); |
| 38 | + |
| 39 | + it('should render custom form fields from formFields prop', () => { |
| 40 | + const formFields = [ |
| 41 | + { key: 'name', label: 'Name', required: true }, |
| 42 | + { key: 'title', label: 'Title', required: false }, |
| 43 | + ]; |
| 44 | + render(<MetadataFormDialog {...defaultProps} formFields={formFields} />); |
| 45 | + expect(screen.getByTestId('metadata-field-name')).toBeInTheDocument(); |
| 46 | + expect(screen.getByTestId('metadata-field-title')).toBeInTheDocument(); |
| 47 | + expect(screen.queryByTestId('metadata-field-description')).not.toBeInTheDocument(); |
| 48 | + }); |
| 49 | + |
| 50 | + it('should show Create button text', () => { |
| 51 | + render(<MetadataFormDialog {...defaultProps} />); |
| 52 | + expect(screen.getByTestId('metadata-form-submit-btn')).toHaveTextContent('Create'); |
| 53 | + }); |
| 54 | + |
| 55 | + it('should disable submit when required fields are empty', () => { |
| 56 | + render(<MetadataFormDialog {...defaultProps} />); |
| 57 | + expect(screen.getByTestId('metadata-form-submit-btn')).toBeDisabled(); |
| 58 | + }); |
| 59 | + |
| 60 | + it('should enable submit when required fields are filled', () => { |
| 61 | + render(<MetadataFormDialog {...defaultProps} />); |
| 62 | + fireEvent.change(screen.getByTestId('metadata-field-name'), { |
| 63 | + target: { value: 'my_dash' }, |
| 64 | + }); |
| 65 | + fireEvent.change(screen.getByTestId('metadata-field-label'), { |
| 66 | + target: { value: 'My Dash' }, |
| 67 | + }); |
| 68 | + expect(screen.getByTestId('metadata-form-submit-btn')).not.toBeDisabled(); |
| 69 | + }); |
| 70 | + |
| 71 | + it('should call onSubmit with form values when submitted', async () => { |
| 72 | + const mockSubmit = vi.fn().mockResolvedValue(undefined); |
| 73 | + render(<MetadataFormDialog {...defaultProps} onSubmit={mockSubmit} />); |
| 74 | + |
| 75 | + fireEvent.change(screen.getByTestId('metadata-field-name'), { |
| 76 | + target: { value: 'my_dash' }, |
| 77 | + }); |
| 78 | + fireEvent.change(screen.getByTestId('metadata-field-label'), { |
| 79 | + target: { value: 'My Dashboard' }, |
| 80 | + }); |
| 81 | + fireEvent.click(screen.getByTestId('metadata-form-submit-btn')); |
| 82 | + |
| 83 | + await waitFor(() => { |
| 84 | + expect(mockSubmit).toHaveBeenCalledWith( |
| 85 | + expect.objectContaining({ |
| 86 | + name: 'my_dash', |
| 87 | + label: 'My Dashboard', |
| 88 | + }), |
| 89 | + ); |
| 90 | + }); |
| 91 | + }); |
| 92 | + |
| 93 | + it('should call onOpenChange(false) after successful submit', async () => { |
| 94 | + const mockOpenChange = vi.fn(); |
| 95 | + render( |
| 96 | + <MetadataFormDialog |
| 97 | + {...defaultProps} |
| 98 | + onOpenChange={mockOpenChange} |
| 99 | + />, |
| 100 | + ); |
| 101 | + |
| 102 | + fireEvent.change(screen.getByTestId('metadata-field-name'), { |
| 103 | + target: { value: 'test' }, |
| 104 | + }); |
| 105 | + fireEvent.change(screen.getByTestId('metadata-field-label'), { |
| 106 | + target: { value: 'Test' }, |
| 107 | + }); |
| 108 | + fireEvent.click(screen.getByTestId('metadata-form-submit-btn')); |
| 109 | + |
| 110 | + await waitFor(() => { |
| 111 | + expect(mockOpenChange).toHaveBeenCalledWith(false); |
| 112 | + }); |
| 113 | + }); |
| 114 | + |
| 115 | + it('should close dialog when Cancel is clicked', () => { |
| 116 | + const mockOpenChange = vi.fn(); |
| 117 | + render( |
| 118 | + <MetadataFormDialog |
| 119 | + {...defaultProps} |
| 120 | + onOpenChange={mockOpenChange} |
| 121 | + />, |
| 122 | + ); |
| 123 | + fireEvent.click(screen.getByTestId('metadata-form-cancel-btn')); |
| 124 | + expect(mockOpenChange).toHaveBeenCalledWith(false); |
| 125 | + }); |
| 126 | + }); |
| 127 | + |
| 128 | + describe('edit mode', () => { |
| 129 | + const editProps = { |
| 130 | + ...defaultProps, |
| 131 | + mode: 'edit' as const, |
| 132 | + initialValues: { name: 'existing_dash', label: 'Existing Dashboard', description: 'Old desc' }, |
| 133 | + }; |
| 134 | + |
| 135 | + it('should render dialog with edit title', () => { |
| 136 | + render(<MetadataFormDialog {...editProps} />); |
| 137 | + expect(screen.getByText('Edit Dashboard')).toBeInTheDocument(); |
| 138 | + }); |
| 139 | + |
| 140 | + it('should show Save button text', () => { |
| 141 | + render(<MetadataFormDialog {...editProps} />); |
| 142 | + expect(screen.getByTestId('metadata-form-submit-btn')).toHaveTextContent('Save'); |
| 143 | + }); |
| 144 | + |
| 145 | + it('should pre-fill form fields with initial values', () => { |
| 146 | + render(<MetadataFormDialog {...editProps} />); |
| 147 | + expect(screen.getByTestId('metadata-field-name')).toHaveValue('existing_dash'); |
| 148 | + expect(screen.getByTestId('metadata-field-label')).toHaveValue('Existing Dashboard'); |
| 149 | + expect(screen.getByTestId('metadata-field-description')).toHaveValue('Old desc'); |
| 150 | + }); |
| 151 | + |
| 152 | + it('should disable fields with disabledOnEdit in edit mode', () => { |
| 153 | + const formFields = [ |
| 154 | + { key: 'name', label: 'Name', required: true, disabledOnEdit: true }, |
| 155 | + { key: 'label', label: 'Label', required: true }, |
| 156 | + ]; |
| 157 | + render( |
| 158 | + <MetadataFormDialog |
| 159 | + {...editProps} |
| 160 | + formFields={formFields} |
| 161 | + />, |
| 162 | + ); |
| 163 | + expect(screen.getByTestId('metadata-field-name')).toBeDisabled(); |
| 164 | + expect(screen.getByTestId('metadata-field-label')).not.toBeDisabled(); |
| 165 | + }); |
| 166 | + }); |
| 167 | + |
| 168 | + describe('textarea fields', () => { |
| 169 | + it('should render textarea for fields with type textarea', () => { |
| 170 | + const formFields = [ |
| 171 | + { key: 'name', label: 'Name', required: true }, |
| 172 | + { key: 'description', label: 'Description', type: 'textarea' as const }, |
| 173 | + ]; |
| 174 | + render(<MetadataFormDialog {...defaultProps} formFields={formFields} />); |
| 175 | + const desc = screen.getByTestId('metadata-field-description'); |
| 176 | + expect(desc.tagName).toBe('TEXTAREA'); |
| 177 | + }); |
| 178 | + }); |
| 179 | + |
| 180 | + describe('when dialog is closed', () => { |
| 181 | + it('should not render dialog content when open is false', () => { |
| 182 | + render(<MetadataFormDialog {...defaultProps} open={false} />); |
| 183 | + expect(screen.queryByTestId('metadata-form-dialog')).not.toBeInTheDocument(); |
| 184 | + }); |
| 185 | + }); |
| 186 | +}); |
0 commit comments