refactor: address code review - rename variables, extract mapFieldTypeToFilterType helper

Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>

Author: Copilot

packages/fields/src/widgets/LookupField.tsx

@@ -56,6 +56,27 @@ function recordToOption(
   return { value: val, label: String(label), description, ...record };
 }
 
+/**
+ * Map a LookupColumnDef.type to a filter input type for the filter bar.
+ * Returns undefined if the field type is not filterable.
+ */
+function mapFieldTypeToFilterType(
+  fieldType: string,
+): RecordPickerFilterColumn['type'] | undefined {
+  const mapping: Record<string, RecordPickerFilterColumn['type']> = {
+    text: 'text',
+    number: 'number',
+    currency: 'number',
+    percent: 'number',
+    select: 'select',
+    status: 'select',
+    date: 'date',
+    datetime: 'date',
+    boolean: 'boolean',
+  };
+  return mapping[fieldType];
+}
+
 /**
  * Lookup field for selecting related records.
  * Supports single and multi-select with search.
@@ -111,8 +132,7 @@ export function LookupField({ value, onChange, field, readonly, ...props }: Fiel
     const cols: RecordPickerFilterColumn[] = [];
     for (const c of lookupColumns) {
       if (typeof c === 'object' && c.type) {
-        const filterType = (['text', 'number', 'select', 'date', 'boolean'] as const)
-          .find(t => t === c.type || (c.type === 'currency' && t === 'number') || (c.type === 'percent' && t === 'number'));
+        const filterType = mapFieldTypeToFilterType(c.type);
         if (filterType) {
           cols.push({
             field: c.field,

packages/fields/src/widgets/RecordPickerDialog.tsx

@@ -279,7 +279,7 @@ export function RecordPickerDialog({
 
   // Fetch records
   const fetchRecords = useCallback(
-    async (search?: string, page = 1, sort?: { field: string; direction: 'asc' | 'desc' } | null, filterOverride?: Record<string, any>) => {
+    async (search?: string, page = 1, sort?: { field: string; direction: 'asc' | 'desc' } | null, customFilter?: Record<string, any>) => {
       if (!dataSource || !objectName) return;
 
       setLoading(true);
@@ -297,9 +297,9 @@ export function RecordPickerDialog({
           params.$orderby = { [sort.field]: sort.direction };
         }
         // Inject filters (lookup_filters + filter bar values)
-        const activeFilter = filterOverride !== undefined ? filterOverride : mergedFilter;
-        if (activeFilter && Object.keys(activeFilter).length > 0) {
-          params.$filter = activeFilter;
+        const effectiveFilter = customFilter !== undefined ? customFilter : mergedFilter;
+        if (effectiveFilter && Object.keys(effectiveFilter).length > 0) {
+          params.$filter = effectiveFilter;
         }
 
         const result = await dataSource.find(objectName, params);