Skip to content

Commit 7d06684

Browse files
committed
fix: update data fetching logic in createHandlers; adjust ag-grid-react version and improve test configurations
1 parent 80fa066 commit 7d06684

10 files changed

Lines changed: 39 additions & 45 deletions

File tree

apps/console/src/mocks/server.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,8 @@ function createHandlers(baseUrl: string, kernel: ObjectKernel, driver: InMemoryD
164164
// Use driver directly
165165
// Try simple find first
166166
const records = await driver.find(params.objectName as string, {
167-
filters: [['_id', '=', params.id]]
167+
object: params.objectName as string,
168+
where: [['_id', '=', params.id]]
168169
});
169170
// Manual filter to ensure we get the correct record if driver ignores filters
170171
const record = records ? records.find((r: any) => r.id === params.id || r._id === params.id) : null;

packages/components/src/renderers/data-display/list.tsx

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,10 @@
66
* LICENSE file in the root directory of this source tree.
77
*/
88

9-
import { ComponentRegistry } from '@object-ui/core';
10-
import compact from 'lodash/compact';
119
import { ComponentRegistry } from '@object-ui/core';
1210
import type { ListSchema } from '@object-ui/types';
1311
import { useDataScope } from '@object-ui/react';
14-
import { renderChildren } from '../../lib/utils';
15-
import { cn } from '../../lib/utils';
12+
import { renderChildren, cn } from '../../lib/utils';
1613

1714
ComponentRegistry.register('list',
1815
({ schema, className, ...props }: { schema: ListSchema; className?: string; [key: string]: any }) => {

packages/fields/src/widgets/MasterDetailField.tsx

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -128,31 +128,4 @@ export function MasterDetailField({
128128
</Button>
129129
</div>
130130
);
131-
} disabled={readonly || props.disabled}
132-
>
133-
<X className="w-4 h-4" />
134-
</Button>
135-
</div>
136-
</div>
137-
))}
138-
</div>
139-
140-
{!readonly && (
141-
<Button
142-
type="button"
143-
variant="outline"
144-
size="sm"
145-
onClick={handleAdd}
146-
className="w-full"
147-
>
148-
<Plus className="w-4 h-4 mr-2" />
149-
Add Related Record
150-
</Button>
151-
)}
152-
153-
<p className="text-xs text-muted-foreground">
154-
{items.length} {items.length === 1 ? 'record' : 'records'}
155-
</p>
156-
</div>
157-
);
158131
}

packages/fields/vite.config.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ export default defineConfig({
4343
},
4444
test: {
4545
globals: true,
46-
environment: 'happy-dom',
46+
environment: 'jsdom',
4747
setupFiles: ['../../vitest.setup.ts'],
4848
passWithNoTests: true,
4949
},

packages/plugin-aggrid/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@
4949
"@types/react-dom": "^19.2.3",
5050
"@vitejs/plugin-react": "^4.2.1",
5151
"ag-grid-community": "^32.3.9",
52-
"ag-grid-react": "^35.0.1",
52+
"ag-grid-react": "^32.3.9",
5353
"typescript": "^5.9.3",
5454
"vite": "^7.3.1",
5555
"vite-plugin-dts": "^4.5.4"

packages/plugin-calendar/src/ObjectCalendar.msw.test.tsx

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -56,17 +56,15 @@ const server = setupServer(...handlers);
5656
// --- Test Suite ---
5757

5858
describe('ObjectCalendar with MSW', () => {
59-
if (!process.env.OBJECTSTACK_API_URL) {
60-
beforeAll(() => server.listen());
61-
afterEach(() => server.resetHandlers());
62-
afterAll(() => server.close());
63-
}
64-
65-
const dataSource = new ObjectStackAdapter({
66-
baseUrl: BASE_URL,
67-
});
59+
beforeAll(() => server.listen());
60+
afterEach(() => server.resetHandlers());
61+
afterAll(() => server.close());
6862

6963
it('fetches events and renders them', async () => {
64+
const dataSource = new ObjectStackAdapter({
65+
baseUrl: BASE_URL,
66+
});
67+
7068
render(
7169
<ObjectCalendar
7270
schema={{

packages/plugin-calendar/vite.config.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,5 +49,7 @@ export default defineConfig({
4949
},
5050
test: {
5151
passWithNoTests: true,
52+
globals: true,
53+
environment: 'jsdom',
5254
},
5355
});

packages/plugin-timeline/vite.config.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,5 +47,7 @@ export default defineConfig({
4747
},
4848
test: {
4949
passWithNoTests: true,
50+
globals: true,
51+
environment: 'jsdom',
5052
},
5153
});

pnpm-lock.yaml

Lines changed: 15 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vitest.setup.ts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,3 +7,11 @@
77
*/
88

99
import '@testing-library/jest-dom';
10+
11+
// Polyfill ResizeObserver for Radix UI (Shadcn) components
12+
global.ResizeObserver = class ResizeObserver {
13+
observe() {}
14+
unobserve() {}
15+
disconnect() {}
16+
};
17+

0 commit comments

Comments
 (0)