Merge pull request #1196 from objectstack-ai/copilot/merge-objectmanagerpage-into-metadata

Author: hotlong

CHANGELOG.md

@@ -7,6 +7,20 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Changed
+
+- **Merged ObjectManagerPage into MetadataManagerPage pipeline** (`@object-ui/console`): Removed the standalone `ObjectManagerPage` component. Object management is now fully handled by the generic `MetadataManagerPage` (list view) and `MetadataDetailPage` (detail view) pipeline. The object type config in `metadataTypeRegistry` uses `listComponent: ObjectManagerListAdapter` for the custom list UI and `pageSchemaFactory: buildObjectDetailPageSchema` for the detail page, eliminating redundant page code and centralizing all metadata management through a single architecture.
+
+- **`listComponent` extension point on MetadataTypeConfig** (`@object-ui/console`): New optional `listComponent` field allows metadata types to inject a fully custom list component into `MetadataManagerPage`, replacing the default card/grid rendering. The page shell (header, back button, title) is still rendered by the generic manager. `MetadataListComponentProps` interface provides `config`, `basePath`, `metadataType`, and `isAdmin` to the custom component.
+
+- **Routes unified to `/system/metadata/object`** (`@object-ui/console`): All entry points (sidebar, QuickActions, SystemHubPage hub cards) now point to `/system/metadata/object` instead of `/system/objects`. Legacy `/system/objects` routes redirect to the new path for backward compatibility.
+
+### Removed
+
+- **`ObjectManagerPage`** (`@object-ui/console`): Deleted `pages/system/ObjectManagerPage.tsx`. All object management functionality is now delivered through the `ObjectManagerListAdapter` + `MetadataManagerPage`/`MetadataDetailPage` pipeline.
+
+- **`customRoute` on object type config** (`@object-ui/console`): The object metadata type no longer uses `customRoute: '/system/objects'`. It now routes through the standard metadata pipeline at `/system/metadata/object`.
+
 ### Fixed
 
 - **Protocol bridges** (`@object-ui/core`): Updated `DndProtocol`, `KeyboardProtocol`, and `NotificationProtocol` to align with `@objectstack/spec` v4 type changes where `ariaLabel`, `label`, `title`, and `message` fields are now plain strings instead of i18n translation objects (`{ key, defaultValue }`).

ROADMAP.md

@@ -943,8 +943,11 @@ Enterprise-grade visual designers for managing object definitions and configurin
 - [x] `boolean` field type — renders Shadcn Switch toggle with Yes/No label
 
 **MetadataDetailPage & Provider Enhancements:**
-- [x] Auto-redirect for custom page types (object → `/system/objects/:name`)
+- [x] Auto-redirect for custom page types (object → `/system/objects/:name`) — removed; object now uses metadata pipeline
 - [x] `getItemsByType(type)` method on MetadataProvider for dynamic registry access
+- [x] Object type merged into MetadataManagerPage pipeline — `ObjectManagerPage` removed, replaced by `ObjectManagerListAdapter` via `listComponent` extension point
+- [x] `listComponent` extension point on MetadataTypeConfig for injecting custom list UIs
+- [x] All entry points (sidebar, QuickActions, hub cards) unified to `/system/metadata/object`
 
 **Technical Debt Cleanup:**
 - [x] Unified icon resolver — consolidated 3 duplicated ICON_MAP/resolveIcon into shared `getIcon` utility

apps/console/src/App.tsx

@@ -1,4 +1,4 @@
-import { BrowserRouter, Routes, Route, Navigate, useNavigate, useLocation } from 'react-router-dom';
+import { BrowserRouter, Routes, Route, Navigate, useNavigate, useLocation, useParams } from 'react-router-dom';
 import { useState, useEffect, useCallback, lazy, Suspense, useMemo, type ReactNode } from 'react';
 import { ModalForm } from '@object-ui/plugin-form';
 import { Empty, EmptyTitle, EmptyDescription, Button } from '@object-ui/components';
@@ -47,7 +47,6 @@ const ForgotPasswordPage = lazy(() => import('./pages/ForgotPasswordPage').then(
 // System Admin Pages (lazy — rarely accessed)
 const SystemHubPage = lazy(() => import('./pages/system/SystemHubPage').then(m => ({ default: m.SystemHubPage })));
 const AppManagementPage = lazy(() => import('./pages/system/AppManagementPage').then(m => ({ default: m.AppManagementPage })));
-const ObjectManagerPage = lazy(() => import('./pages/system/ObjectManagerPage').then(m => ({ default: m.ObjectManagerPage })));
 const MetadataManagerPage = lazy(() => import('./pages/system/MetadataManagerPage').then(m => ({ default: m.MetadataManagerPage })));
 const MetadataDetailPage = lazy(() => import('./pages/system/MetadataDetailPage').then(m => ({ default: m.MetadataDetailPage })));
 const UserManagementPage = lazy(() => import('./pages/system/UserManagementPage').then(m => ({ default: m.UserManagementPage })));
@@ -61,7 +60,6 @@ const ProfilePage = lazy(() => import('./pages/system/ProfilePage').then(m => ({
 const HomePage = lazy(() => import('./pages/home/HomePage').then(m => ({ default: m.HomePage })));
 const HomeLayout = lazy(() => import('./pages/home/HomeLayout').then(m => ({ default: m.HomeLayout })));
 
-import { useParams } from 'react-router-dom';
 import { ThemeProvider } from './components/theme-provider';
 import { ConsoleToaster } from './components/ConsoleToaster';
 
@@ -294,8 +292,8 @@ export function AppContent() {
           <Route path="create-app" element={<CreateAppPage />} />
           <Route path="system" element={<SystemHubPage />} />
           <Route path="system/apps" element={<AppManagementPage />} />
-          <Route path="system/objects" element={<ObjectManagerPage />} />
-          <Route path="system/objects/:objectName" element={<ObjectManagerPage />} />
+          <Route path="system/objects" element={<Navigate to="/system/metadata/object" replace />} />
+          <Route path="system/objects/:objectName" element={<ObjectRedirect />} />
           <Route path="system/users" element={<UserManagementPage />} />
           <Route path="system/organizations" element={<OrgManagementPage />} />
           <Route path="system/roles" element={<RoleManagementPage />} />
@@ -390,8 +388,8 @@ export function AppContent() {
         {/* System Administration Routes */}
         <Route path="system" element={<SystemHubPage />} />
         <Route path="system/apps" element={<AppManagementPage />} />
-        <Route path="system/objects" element={<ObjectManagerPage />} />
-        <Route path="system/objects/:objectName" element={<ObjectManagerPage />} />
+        <Route path="system/objects" element={<Navigate to="/system/metadata/object" replace />} />
+        <Route path="system/objects/:objectName" element={<ObjectRedirect />} />
         <Route path="system/users" element={<UserManagementPage />} />
         <Route path="system/organizations" element={<OrgManagementPage />} />
         <Route path="system/roles" element={<RoleManagementPage />} />
@@ -476,6 +474,19 @@ function RootRedirect() {
     return <Navigate to="/home" replace />;
 }
 
+/**
+ * Redirect helper for legacy `/system/objects/:objectName` routes.
+ * Preserves the `objectName` URL param so that
+ * `/system/objects/account` → `/system/metadata/object/account`.
+ */
+function ObjectRedirect() {
+  const { objectName } = useParams<{ objectName?: string }>();
+  const target = objectName
+    ? `/system/metadata/object/${objectName}`
+    : '/system/metadata/object';
+  return <Navigate to={target} replace />;
+}
+
 /**
  * SystemRoutes — Top-level system admin routes accessible without any app context.
  * Provides a minimal layout with system navigation sidebar.
@@ -486,8 +497,8 @@ function SystemRoutes() {
       <Routes>
         <Route path="/" element={<SystemHubPage />} />
         <Route path="apps" element={<AppManagementPage />} />
-        <Route path="objects" element={<ObjectManagerPage />} />
-        <Route path="objects/:objectName" element={<ObjectManagerPage />} />
+        <Route path="objects" element={<Navigate to="/system/metadata/object" replace />} />
+        <Route path="objects/:objectName" element={<ObjectRedirect />} />
         <Route path="users" element={<UserManagementPage />} />
         <Route path="organizations" element={<OrgManagementPage />} />
         <Route path="roles" element={<RoleManagementPage />} />

apps/console/src/__tests__/MetadataDetailPage.test.tsx

@@ -247,7 +247,7 @@ describe('MetadataDetailPage', () => {
         </MemoryRouter>,
       );
       fireEvent.click(screen.getByTestId('back-to-list-btn'));
-      expect(mockNavigate).toHaveBeenCalledWith('/system/objects');
+      expect(mockNavigate).toHaveBeenCalledWith('/system/metadata/object');
     });
   });
 });