Skip to content

Commit 7f6f08b

Browse files
authored
Merge pull request #383 from objectstack-ai/copilot/fix-all-build-and-test
2 parents 090d1d1 + 1088690 commit 7f6f08b

File tree

4 files changed

+7
-6
lines changed

4 files changed

+7
-6
lines changed

packages/components/src/renderers/complex/data-table.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -491,18 +491,18 @@ const DataTableRenderer = ({ schema }: { schema: DataTableSchema }) => {
491491
key={rowId}
492492
data-state={isSelected ? 'selected' : undefined}
493493
className={cn(
494-
// @ts-ignore
494+
// @ts-expect-error - onRowClick might not be in schema type definition
495495
schema.onRowClick && "cursor-pointer"
496496
)}
497497
onClick={(e) => {
498-
// @ts-ignore
498+
// @ts-expect-error - onRowClick might not be in schema type definition
499499
if (schema.onRowClick && !e.defaultPrevented) {
500500
// Simple heuristic to avoid triggering on interactive elements if they didn't stop propagation
501501
const target = e.target as HTMLElement;
502502
if (target.closest('button') || target.closest('[role="checkbox"]') || target.closest('a')) {
503503
return;
504504
}
505-
// @ts-ignore
505+
// @ts-expect-error - onRowClick might not be in schema type definition
506506
schema.onRowClick(row);
507507
}
508508
}}

packages/plugin-kanban/src/ObjectKanban.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ export const ObjectKanban: React.FC<ObjectKanbanProps> = ({
101101
if (!Array.isArray(rawData)) return [];
102102

103103
// Support cardTitle property from schema (passed by ObjectView)
104-
// @ts-ignore - cardTitle might not be in KanbanSchema type definition yet
104+
// Fallback to legacy titleField for backwards compatibility
105105
let titleField = schema.cardTitle || (schema as any).titleField;
106106

107107
// Fallback: Try to infer from object definition

packages/plugin-kanban/vitest.config.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
/// <reference types="vitest" />
22
import { defineConfig } from 'vite';
33
import react from '@vitejs/plugin-react';
4-
import path from 'path';
54

65
export default defineConfig({
76
plugins: [react()],

packages/plugin-timeline/src/ObjectTimeline.test.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,8 @@ describe('ObjectTimeline', () => {
6262
expect(mockDataSource.find).toHaveBeenCalled();
6363
});
6464

65-
expect(screen.getByText('Event 1')).toBeDefined();
65+
await waitFor(() => {
66+
expect(screen.getByText('Event 1')).toBeDefined();
67+
});
6668
});
6769
});

0 commit comments

Comments
 (0)