Skip to content

Commit 81f9baf

Browse files
Copilothotlong
andcommitted
fix: address code review feedback (error logging, a11y description, spelling)
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
1 parent ec07e70 commit 81f9baf

3 files changed

Lines changed: 6 additions & 5 deletions

File tree

apps/console/src/components/DashboardView.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ export function DashboardView({ dataSource }: { dataSource?: any }) {
3737
const { dashboards } = useMetadata();
3838
const dashboard = dashboards?.find((d: any) => d.name === dashboardName);
3939

40-
// Local schema state for live preview — initialised from metadata
40+
// Local schema state for live preview — initialized from metadata
4141
const [editSchema, setEditSchema] = useState<DashboardSchema | null>(null);
4242

4343
const handleOpenDrawer = useCallback(() => {

apps/console/src/components/DesignDrawer.tsx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,9 @@ export function DesignDrawer({
6060
await dataSource.update(collection, recordName, toSave);
6161
return true;
6262
}
63-
} catch {
64-
// Save errors are non-blocking
63+
} catch (err) {
64+
console.warn('[DesignDrawer] Auto-save failed:', err);
65+
// Save errors are non-blocking; user can retry via Ctrl+S
6566
}
6667
return false;
6768
},
@@ -101,7 +102,7 @@ export function DesignDrawer({
101102
<SheetHeader className="px-4 py-3 border-b shrink-0">
102103
<SheetTitle>{title}</SheetTitle>
103104
<SheetDescription className={description ? '' : 'sr-only'}>
104-
{description || `Edit panel for ${title}`}
105+
{description || `Visual editor — configure and preview ${title}`}
105106
</SheetDescription>
106107
</SheetHeader>
107108
<div className="flex-1 overflow-auto p-4">

apps/console/src/components/PageView.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ export function PageView() {
2828
const { pages } = useMetadata();
2929
const page = pages?.find((p: any) => p.name === pageName);
3030

31-
// Local schema state for live preview — initialised from metadata
31+
// Local schema state for live preview — initialized from metadata
3232
const [editSchema, setEditSchema] = useState<PageSchema | null>(null);
3333

3434
const handleOpenDrawer = useCallback(() => {

0 commit comments

Comments
 (0)