Commit 845bd8d
fix(types,detail): derive five spec-named symbols instead of forking them (objectstack#4115)
Burns the first five names off the spec-symbol DEBT ledger (149 -> 144).
None of these were "one spec release away from drifting" — all five had
already drifted, and two were live defects:
- PageVariableSchema (zod/layout.zod.ts) omitted `source`, the entire
ADR-0049 write-binding, so a spec-authored master/detail page parsed
into a variable nothing could ever write; its `type` enum was also
missing `record_id`, rejecting spec-valid record-picker variables. The
sibling PageTypeSchema three lines below was already a spec re-export,
with a comment describing this exact failure — one mirror was fixed and
its neighbour left broken.
- FeedItemType carried 7 of the spec's 13 members. The six missing kinds
(file, sharing, note, record_create, record_delete, approval) had no
icon and no colour in RecordActivityTimeline, so a server emitting any
of them produced an unrenderable feed item. Both maps are
`Record<FeedItemType, …>`, so widening the union surfaced the gap as a
compile error; the six entries are filled in here.
- PermissionAction was 8 of 11, missing `execute`/`manage`/`configure`.
- ObjectIndex lacked `fulltext`, `unique: 'global'` and `partial`.
- PageVariable (TS) was member-for-member identical to spec's — a second
place to drift from and nothing else. Note its own Zod counterpart had
drifted while it had not.
The ledger is regenerated with `--ledger`, not hand-edited; the diff is
exactly these five names, so no other package's debt was dropped.
Mutation-tested both directions: re-forking a burned-down name fails the
guard by name, and leaving a burned name in the ledger fails it as stale.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>1 parent d2551ba commit 845bd8d
7 files changed
Lines changed: 70 additions & 48 deletions
File tree
- packages
- plugin-detail/src
- types/src
- zod
- scripts
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
25 | 29 | | |
26 | 30 | | |
27 | 31 | | |
| |||
73 | 77 | | |
74 | 78 | | |
75 | 79 | | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
76 | 84 | | |
77 | 85 | | |
78 | 86 | | |
| |||
81 | 89 | | |
82 | 90 | | |
83 | 91 | | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
84 | 98 | | |
85 | 99 | | |
86 | 100 | | |
| |||
91 | 105 | | |
92 | 106 | | |
93 | 107 | | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
94 | 114 | | |
95 | 115 | | |
96 | 116 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
987 | 987 | | |
988 | 988 | | |
989 | 989 | | |
990 | | - | |
| 990 | + | |
| 991 | + | |
| 992 | + | |
| 993 | + | |
| 994 | + | |
| 995 | + | |
| 996 | + | |
| 997 | + | |
991 | 998 | | |
992 | | - | |
993 | | - | |
994 | | - | |
995 | | - | |
996 | | - | |
997 | | - | |
998 | | - | |
999 | | - | |
1000 | | - | |
1001 | | - | |
1002 | | - | |
1003 | | - | |
1004 | | - | |
1005 | | - | |
1006 | | - | |
1007 | | - | |
1008 | | - | |
1009 | | - | |
| 999 | + | |
| 1000 | + | |
1010 | 1001 | | |
1011 | 1002 | | |
1012 | 1003 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
460 | 460 | | |
461 | 461 | | |
462 | 462 | | |
463 | | - | |
464 | | - | |
465 | | - | |
| 463 | + | |
| 464 | + | |
| 465 | + | |
| 466 | + | |
| 467 | + | |
466 | 468 | | |
467 | | - | |
468 | | - | |
469 | | - | |
470 | | - | |
471 | | - | |
472 | | - | |
473 | | - | |
474 | | - | |
475 | | - | |
476 | | - | |
| 469 | + | |
| 470 | + | |
477 | 471 | | |
478 | 472 | | |
479 | 473 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
24 | | - | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
25 | 33 | | |
26 | 34 | | |
27 | 35 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
321 | 321 | | |
322 | 322 | | |
323 | 323 | | |
324 | | - | |
| 324 | + | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
325 | 331 | | |
326 | | - | |
| 332 | + | |
| 333 | + | |
327 | 334 | | |
328 | 335 | | |
329 | 336 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | | - | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
21 | 24 | | |
22 | 25 | | |
23 | 26 | | |
| |||
245 | 248 | | |
246 | 249 | | |
247 | 250 | | |
248 | | - | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
249 | 260 | | |
250 | | - | |
251 | | - | |
252 | | - | |
253 | | - | |
254 | | - | |
| 261 | + | |
255 | 262 | | |
256 | 263 | | |
257 | 264 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
148 | 148 | | |
149 | 149 | | |
150 | 150 | | |
151 | | - | |
152 | 151 | | |
153 | 152 | | |
154 | 153 | | |
| |||
169 | 168 | | |
170 | 169 | | |
171 | 170 | | |
172 | | - | |
173 | 171 | | |
174 | 172 | | |
175 | 173 | | |
176 | 174 | | |
177 | 175 | | |
178 | | - | |
179 | | - | |
180 | | - | |
181 | 176 | | |
182 | 177 | | |
183 | 178 | | |
| |||
0 commit comments