Skip to content

Commit 8855eca

Browse files
Copilothotlong
andcommitted
style: address review comments in test files
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
1 parent 8554235 commit 8855eca

File tree

3 files changed

+10
-2
lines changed

3 files changed

+10
-2
lines changed

ROADMAP.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -366,6 +366,14 @@ ObjectUI is a universal Server-Driven UI (SDUI) engine built on React + Tailwind
366366
- [x] Auto-save property changes to backend via DesignDrawer
367367
- [x] Add Vitest tests (15 DashboardRenderer design mode + 9 DashboardEditor external selection + 8 DashboardView integration = 32 new tests)
368368

369+
**Phase 7 — Non-Modal Drawer & Property Panel UX Fix:**
370+
- [x] `SheetContent` — added `hideOverlay` prop to conditionally skip the full-screen backdrop overlay
371+
- [x] `DesignDrawer``modal={false}` + `hideOverlay` so preview widgets are clickable while drawer is open
372+
- [x] `DashboardEditor` — property panel renders above widget grid (stacked `flex-col` layout) for immediate visibility in narrow drawer
373+
- [x] `DashboardEditor` — property panel uses full width (removed fixed `w-72`) for better readability in drawer context
374+
- [x] Preview click → editor property panel linkage now works end-to-end (select, switch, deselect)
375+
- [x] Add 11 new tests (7 DashboardDesignInteraction integration + 4 DashboardEditor.propertyPanelLayout)
376+
369377
### P1.11 Console — Schema-Driven View Config Panel Migration
370378

371379
> Migrated the Console ViewConfigPanel from imperative implementation (~1655 lines) to Schema-Driven architecture using `ConfigPanelRenderer` + `useConfigDraft` + `ConfigPanelSchema`, reducing to ~170 lines declarative wrapper + schema factory.

apps/console/src/__tests__/DashboardDesignInteraction.test.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ const { editorCalls, rendererCalls } = vi.hoisted(() => ({
1717
editorCalls: {
1818
selectedWidgetId: null as string | null,
1919
onWidgetSelect: null as ((id: string | null) => void) | null,
20-
lastSchema: null as any,
20+
lastSchema: null as unknown,
2121
},
2222
rendererCalls: {
2323
designMode: false,

packages/plugin-designer/src/__tests__/DashboardEditor.propertyPanelLayout.test.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ describe('DashboardEditor property panel layout', () => {
3636
const widgetCard = screen.getByTestId('dashboard-widget-w1');
3737

3838
// Property panel should appear before the widget cards in DOM order
39-
// (compareDocumentPosition returns bitmask, bit 4 = DOCUMENT_POSITION_FOLLOWING)
39+
// compareDocumentPosition bit 4 (DOCUMENT_POSITION_FOLLOWING) means widgetCard comes after propertyPanel
4040
const position = propertyPanel.compareDocumentPosition(widgetCard);
4141
expect(position & Node.DOCUMENT_POSITION_FOLLOWING).toBeTruthy();
4242
});

0 commit comments

Comments
 (0)