Skip to content

Commit 89fa8a1

Browse files
Copilothotlong
andcommitted
fix: address code review feedback - remove unused import and fix JSDoc
- Remove unused SpecTheme import from theme.ts - Fix ActionParamFieldType JSDoc to accurately describe spec alignment Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
1 parent 36fc0f6 commit 89fa8a1

2 files changed

Lines changed: 2 additions & 3 deletions

File tree

packages/types/src/theme.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,6 @@ import type {
8989
Animation,
9090
ZIndex,
9191
ThemeMode,
92-
Theme as SpecTheme,
9392
} from '@objectstack/spec/ui';
9493

9594
/**

packages/types/src/ui-action.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,8 @@ export type ActionType =
5858

5959
/**
6060
* Field type for action parameters
61-
* Extended from @objectstack/spec/ui ActionParamSchema.type to include
62-
* ObjectUI-specific field types commonly used in parameter UIs.
61+
* Subset of field types commonly used in action parameter collection UIs.
62+
* Aligned with the field types available in @objectstack/spec ActionParamSchema.
6363
*/
6464
export type ActionParamFieldType =
6565
| 'text'

0 commit comments

Comments
 (0)