Commit 9369d4b
docs(components): document the remaining nine Shadcn divergences — every tracked component now says why it diverges (#3059)
Completes the triage. All 17 locally-modified components now carry a
`localEdits` note; `--check` reports 0 UNDOCUMENTED.
None of the nine are droppable either. Like the first eight, every one is
a deliberate fix or API extension:
command ADR-0054 C4 `contentProps` + the `sr-only` DialogTitle Radix
requires. Upstream drops each addition with its usages, so a
sync deletes ~38 lines and still type-checks — verified.
select Wraps Root to swallow `onValueChange("")`. Radix's hidden
native mirror registers options a commit after the trigger,
so a value arriving mid-hydration echoes back empty and wipes
the field, latching forms whose `visibleWhen` reads it (#2968).
table `containerClassName`, to stop the wrapper becoming a second
height-unbounded scroll container inside DataTable.
chart `block … w-full` instead of `flex justify-center`, or
ResponsiveContainer measures no width and charts draw axes
with no marks (#1634, 9b16317); plus hand-written Recharts
prop types that actually type-check (2e11aa7).
sidebar Tailwind v4 syntax, a `data-collapsible`-always-present
refactor, and an `eslint-disable react-hooks/purity` the
random skeleton width needs.
badge `whitespace-nowrap`, or CJK labels break per-character in a
cramped table cell (objectui#2762 P0-1).
slider Forwards `aria-label` to the Thumb.
sheet `hideOverlay` prop.
calendar Tailwind v4 syntax on `--cell-size`.
Two claims I checked rather than asserted, because both could have
shipped as confident wrong statements:
- Removing sidebar's `eslint-disable` really does fail Lint — it is an
error from `react-hooks/purity`, not a warning, and Lint gates CI.
- `theme(spacing.4)` → `1rem` is **cosmetic**, not a fix. Tailwind 4.3.3
still resolves the v3 dot-notation, and both spellings compile to the
identical `calc(var(--sidebar-width-icon) + 1rem)`. The note says so;
only the `[--var]` → `(--var)` half of that migration is load-bearing.
Also corrects a misleading `--check` label. The counts are set
differences, so a locally-edited line appears on BOTH sides — once as
ours, once as the upstream original it replaced. Calling that "N upstream
line(s) pending" reads as updates waiting to be collected, which is how I
misread sidebar's 21 as reclaimable work; it is mostly the mirror image
of sidebar's own edits. Now "N not matching upstream verbatim". The
`outdated` bucket keeps its wording — there `localOnly` is 0, so the
count genuinely is new upstream work.
Manifest and script only; no component source changes.
Co-authored-by: Jack Zhuang <277994282+os-zhuang@users.noreply.github.com>
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>1 parent 056faa8 commit 9369d4b
2 files changed
Lines changed: 24 additions & 10 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
56 | | - | |
| 56 | + | |
| 57 | + | |
57 | 58 | | |
58 | 59 | | |
59 | 60 | | |
| |||
75 | 76 | | |
76 | 77 | | |
77 | 78 | | |
78 | | - | |
| 79 | + | |
| 80 | + | |
79 | 81 | | |
80 | 82 | | |
81 | 83 | | |
| |||
97 | 99 | | |
98 | 100 | | |
99 | 101 | | |
100 | | - | |
| 102 | + | |
| 103 | + | |
101 | 104 | | |
102 | 105 | | |
103 | 106 | | |
| |||
120 | 123 | | |
121 | 124 | | |
122 | 125 | | |
123 | | - | |
| 126 | + | |
| 127 | + | |
124 | 128 | | |
125 | 129 | | |
126 | 130 | | |
| |||
248 | 252 | | |
249 | 253 | | |
250 | 254 | | |
251 | | - | |
| 255 | + | |
| 256 | + | |
252 | 257 | | |
253 | 258 | | |
254 | 259 | | |
| |||
262 | 267 | | |
263 | 268 | | |
264 | 269 | | |
265 | | - | |
| 270 | + | |
| 271 | + | |
266 | 272 | | |
267 | 273 | | |
268 | 274 | | |
| |||
275 | 281 | | |
276 | 282 | | |
277 | 283 | | |
278 | | - | |
| 284 | + | |
| 285 | + | |
279 | 286 | | |
280 | 287 | | |
281 | 288 | | |
| |||
287 | 294 | | |
288 | 295 | | |
289 | 296 | | |
290 | | - | |
| 297 | + | |
| 298 | + | |
291 | 299 | | |
292 | 300 | | |
293 | 301 | | |
| |||
308 | 316 | | |
309 | 317 | | |
310 | 318 | | |
311 | | - | |
| 319 | + | |
| 320 | + | |
312 | 321 | | |
313 | 322 | | |
314 | 323 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
256 | 256 | | |
257 | 257 | | |
258 | 258 | | |
259 | | - | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
260 | 265 | | |
261 | 266 | | |
262 | 267 | | |
| |||
0 commit comments