Skip to content

Commit 968eb4f

Browse files
Copilothotlong
andcommitted
Address code review: extract shared handleOverlayOpenChange callback
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
1 parent 88716d9 commit 968eb4f

1 file changed

Lines changed: 7 additions & 2 deletions

File tree

packages/plugin-view/src/ObjectView.tsx

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -986,6 +986,11 @@ export const ObjectView: React.FC<ObjectViewProps> = ({
986986
</div>
987987
);
988988

989+
// Shared handler for NavigationOverlay onOpenChange — close form when overlay is dismissed
990+
const handleOverlayOpenChange = useCallback((open: boolean) => {
991+
if (!open) handleFormCancel();
992+
}, [handleFormCancel]);
993+
989994
// For split mode, wrap content inside NavigationOverlay with mainContent
990995
if (formLayout === 'split') {
991996
const objectLabel = (objectSchema?.label as string) || schema.objectName;
@@ -1005,7 +1010,7 @@ export const ObjectView: React.FC<ObjectViewProps> = ({
10051010
selectedRecord={selectedRecord}
10061011
mode="split"
10071012
close={handleFormCancel}
1008-
setIsOpen={(open: boolean) => { if (!open) handleFormCancel(); }}
1013+
setIsOpen={handleOverlayOpenChange}
10091014
width={navigationConfig?.width}
10101015
isOverlay={true}
10111016
title={`${objectLabel} Detail`}
@@ -1055,7 +1060,7 @@ export const ObjectView: React.FC<ObjectViewProps> = ({
10551060
selectedRecord={selectedRecord}
10561061
mode="popover"
10571062
close={handleFormCancel}
1058-
setIsOpen={(open: boolean) => { if (!open) handleFormCancel(); }}
1063+
setIsOpen={handleOverlayOpenChange}
10591064
width={navigationConfig?.width}
10601065
isOverlay={true}
10611066
title={getFormTitle()}

0 commit comments

Comments
 (0)