Fix remaining lint errors in components (static-components, prefer-const), plugin-form (hooks after early returns), and fix MSW test mock handler

Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>

Author: Copilot

packages/components/src/__tests__/view-compliance.test.tsx

@@ -58,7 +58,7 @@ describe('View Component Compliance', () => {
             // Check direct registration or via namespace aliasing
             // ComponentRegistry.get checks namespaces.
             // If registered as { type: 'grid', namespace: 'view' }, fullKey is 'view:grid'.
-            let hasView = ComponentRegistry.getAllConfigs().some(c => c.type === viewKey);
+            const hasView = ComponentRegistry.getAllConfigs().some(c => c.type === viewKey);
 
             if (!hasView) {
                  // Try looking for non-namespaced if it is a view category

packages/components/src/renderers/action/action-menu.tsx

@@ -13,7 +13,7 @@
  * Each menu item triggers the corresponding action via ActionRunner.
  */
 
-import React, { forwardRef, useCallback, useState } from 'react';
+import React, { forwardRef, useCallback, useMemo, useState } from 'react';
 import { ComponentRegistry } from '@object-ui/core';
 import type { ActionSchema } from '@object-ui/types';
 import { useAction } from '@object-ui/react';
@@ -56,7 +56,11 @@ const ActionMenuItem: React.FC<{
   const isVisible = useCondition(action.visible ? `\${${action.visible}}` : undefined);
   const isEnabled = useCondition(action.enabled ? `\${${action.enabled}}` : undefined);
 
-  const Icon = resolveIcon(action.icon);
+  const iconElement = useMemo(() => {
+    const Icon = resolveIcon(action.icon);
+    // eslint-disable-next-line react-hooks/static-components -- Icon is resolved from a stable icon registry
+    return Icon ? <Icon className="mr-2 h-4 w-4" /> : null;
+  }, [action.icon]);
 
   if (action.visible && !isVisible) return null;
 
@@ -72,7 +76,7 @@ const ActionMenuItem: React.FC<{
         action.className,
       )}
     >
-      {Icon && <Icon className="mr-2 h-4 w-4" />}
+      {iconElement}
       <span>{action.label || action.name}</span>
     </DropdownMenuItem>
   );

packages/components/src/renderers/layout/page.tsx

@@ -12,7 +12,7 @@
  * body/children for backward compatibility.
  */
 
-import React from 'react';
+import React, { useMemo } from 'react';
 import type { PageSchema, PageRegion, SchemaNode } from '@object-ui/types';
 import { SchemaRenderer, PageVariablesProvider } from '@object-ui/react';
 import { ComponentRegistry } from '@object-ui/core';
@@ -357,29 +357,25 @@ export const PageRenderer: React.FC<{
   } = props;
 
   // Select the layout variant based on template or page type
-  const TemplateLayout = resolveTemplate(schema);
-  let LayoutVariant: React.FC<{ schema: PageSchema }>;
-
-  if (TemplateLayout) {
-    // Template takes priority over page type
-    LayoutVariant = TemplateLayout;
-  } else {
+  const layoutElement = useMemo(() => {
+    const TemplateLayout = resolveTemplate(schema);
+    if (TemplateLayout) {
+      // Template takes priority over page type
+      // eslint-disable-next-line react-hooks/static-components -- TemplateLayout is resolved from a stable template registry
+      return <TemplateLayout schema={schema} />;
+    }
     switch (pageType) {
       case 'home':
-        LayoutVariant = HomePageLayout;
-        break;
+        return <HomePageLayout schema={schema} />;
       case 'app':
-        LayoutVariant = AppPageLayout;
-        break;
+        return <AppPageLayout schema={schema} />;
       case 'utility':
-        LayoutVariant = UtilityPageLayout;
-        break;
+        return <UtilityPageLayout schema={schema} />;
       case 'record':
       default:
-        LayoutVariant = RecordPageLayout;
-        break;
+        return <RecordPageLayout schema={schema} />;
     }
-  }
+  }, [schema, pageType]);
 
   const pageContent = (
     <div
@@ -409,7 +405,7 @@ export const PageRenderer: React.FC<{
         )}
 
         {/* Page body — type-specific layout */}
-        <LayoutVariant schema={schema} />
+        {layoutElement}
       </div>
     </div>
   );

packages/plugin-form/src/ObjectForm.msw.test.tsx

@@ -85,7 +85,7 @@ const handlers = [
   http.get(`${BASE_URL}/api/v1/data/:object/:id`, ({ params }) => {
     const { object, id } = params;
     if (object === 'contact' && id === '1') {
-      return HttpResponse.json(mockRecord);
+      return HttpResponse.json({ record: mockRecord });
     }
     return new HttpResponse(null, { status: 404 });
   })

packages/plugin-form/src/ObjectForm.tsx

@@ -190,7 +190,17 @@ export const ObjectForm: React.FC<ObjectFormProps> = ({
     );
   }
 
-  // Default: simple form (original implementation below)
+  // Default: simple form
+  return <SimpleObjectForm schema={schema} dataSource={dataSource} />;
+};
+
+/**
+ * SimpleObjectForm — default form variant with auto-generated fields from ObjectQL schema.
+ */
+const SimpleObjectForm: React.FC<ObjectFormProps> = ({
+  schema,
+  dataSource,
+}) => {
 
   const [objectSchema, setObjectSchema] = useState<any>(null);
   const [formFields, setFormFields] = useState<FormField[]>([]);