Merge pull request #827 from objectstack-ai/copilot/audit-definestack-metadata

Author: hotlong

ROADMAP.md

@@ -851,6 +851,7 @@ The `FlowDesigner` is a canvas-based flow editor that bridges the gap between th
 - [x] **P2: Spec Compliance Audit** — Fixed `variant: 'danger'` → `'destructive'` (4 actions), `columns: string` → `number` (33 form sections), added `type: 'dashboard'` to dashboard
 - [x] **P2: Dashboard Widget Spec Alignment** — Added `id`, `title`, `object`, `categoryField`, `valueField`, `aggregate` to all dashboard widgets across CRM, Todo, and Kitchen Sink examples (5 new spec-compliance tests)
 - [x] **P2: i18n (10 locales)** — Full CRM metadata translations for en, zh, ja, ko, de, fr, es, pt, ru, ar — objects, fields, fieldOptions, navigation, actions, views, formSections, dashboard, reports, pages (24 tests)
+- [x] **P2: Full Examples Metadata Audit** — Systematic spec compliance audit across all 4 examples: added `type: 'dashboard'` + `description` to todo/kitchen-sink dashboards, refactored msw-todo to use `ObjectSchema.create` + `Field.*` with snake_case field names, added explicit views to kitchen-sink and msw-todo, added missing `successMessage` on CRM opportunity action, 21 automated compliance tests
 
 ### Ecosystem & Marketplace
 - Plugin marketplace website with search, ratings, and install count

examples/crm/src/actions/account.actions.ts

@@ -33,5 +33,6 @@ export const AccountActions = [
     confirmText: 'Are you sure you want to merge these accounts? This action cannot be undone.',
     variant: 'danger' as const,
     refreshAfter: true,
+    successMessage: 'Accounts merged successfully',
   },
 ];

examples/crm/src/actions/opportunity.actions.ts

@@ -44,5 +44,6 @@ export const OpportunityActions = [
     ],
     confirmText: 'Mark this opportunity as Closed Lost?',
     refreshAfter: true,
+    successMessage: 'Opportunity marked as lost',
   },
 ];

examples/crm/src/dashboards/crm.dashboard.ts

@@ -2,6 +2,7 @@ export const CrmDashboard = {
   type: 'dashboard' as const,
   name: 'crm_dashboard',
   label: 'CRM Overview',
+  description: 'Revenue metrics, pipeline analytics, and deal insights',
   widgets: [
     // --- KPI Row ---
     {

examples/kitchen-sink/objectstack.config.ts

@@ -17,6 +17,43 @@ export default defineStack({
     AccountObject,
     ShowcaseObject
   ],
+  views: [
+    {
+      listViews: {
+        all_fields: {
+          name: 'all_fields',
+          label: 'All Field Types',
+          type: 'grid' as const,
+          data: { provider: 'object' as const, object: 'kitchen_sink' },
+          columns: ['name', 'category', 'amount', 'price', 'percent', 'rating', 'due_date', 'is_active', 'email'],
+          sort: [{ field: 'name', order: 'asc' as const }],
+        },
+      },
+    },
+    {
+      listViews: {
+        all_showcase: {
+          name: 'all_showcase',
+          label: 'All Showcase Items',
+          type: 'grid' as const,
+          data: { provider: 'object' as const, object: 'showcase' },
+          columns: ['title', 'category', 'status', 'priority', 'price', 'start_date', 'owner_email', 'is_featured'],
+          sort: [{ field: 'title', order: 'asc' as const }],
+        },
+        showcase_board: {
+          name: 'showcase_board',
+          label: 'Status Board',
+          type: 'kanban' as const,
+          data: { provider: 'object' as const, object: 'showcase' },
+          columns: ['title', 'priority', 'owner_email', 'start_date'],
+          kanban: {
+            groupByField: 'status',
+            columns: ['title', 'priority', 'owner_email'],
+          },
+        },
+      },
+    },
+  ],
   apps: [
     App.create({
       name: 'analytics_app',
@@ -67,6 +104,7 @@ export default defineStack({
   ],
   dashboards: [
     {
+      type: 'dashboard' as const,
       name: 'showcase_dashboard',
       label: 'Platform Showcase',
       description: 'Demonstrating all dashboard widget types',

examples/msw-todo/README.md

@@ -36,17 +36,18 @@ Create an `objectstack.config.ts` to define your data models and application str
 ```typescript
 // objectstack.config.ts
 import { defineStack } from '@objectstack/spec';
+import { ObjectSchema, Field } from '@objectstack/spec/data';
 import { App } from '@objectstack/spec/ui';
 
-export const TaskObject = {
+export const TaskObject = ObjectSchema.create({
   name: 'task',
   label: 'Task',
   fields: {
-    subject: { type: 'text', required: true },
-    priority: { type: 'number', defaultValue: 1 },
-    isCompleted: { type: 'boolean', defaultValue: false }
-  }
-};
+    subject: Field.text({ label: 'Subject', required: true }),
+    priority: Field.number({ label: 'Priority', defaultValue: 5 }),
+    is_completed: Field.boolean({ label: 'Completed', defaultValue: false }),
+  },
+});
 
 export default defineStack({
   objects: [TaskObject],

examples/msw-todo/objectstack.config.ts

@@ -1,10 +1,11 @@
 import { defineStack } from '@objectstack/spec';
+import { ObjectSchema, Field } from '@objectstack/spec/data';
 import { App } from '@objectstack/spec/ui';
 
 /**
- * Task Object Definition
+ * Task Object Definition — uses ObjectSchema.create + Field.* for spec compliance
  */
-export const TaskObject = {
+export const TaskObject = ObjectSchema.create({
   name: 'task',
   label: 'Task',
   description: 'Task management object',
@@ -18,13 +19,12 @@ export const TaskObject = {
     mru: true,
   },
   fields: {
-    id: { name: 'id', label: 'ID', type: 'text', required: true },
-    subject: { name: 'subject', label: 'Subject', type: 'text', required: true },
-    priority: { name: 'priority', label: 'Priority', type: 'number', defaultValue: 5 },
-    isCompleted: { name: 'isCompleted', label: 'Completed', type: 'boolean', defaultValue: false },
-    createdAt: { name: 'createdAt', label: 'Created At', type: 'datetime' }
-  }
-};
+    subject: Field.text({ label: 'Subject', required: true }),
+    priority: Field.number({ label: 'Priority', defaultValue: 5 }),
+    is_completed: Field.boolean({ label: 'Completed', defaultValue: false }),
+    created_at: Field.datetime({ label: 'Created At', readonly: true }),
+  },
+});
 
 /**
  * App Configuration — Standard ObjectStackDefinition format
@@ -33,6 +33,20 @@ export default defineStack({
   objects: [
     TaskObject
   ],
+  views: [
+    {
+      listViews: {
+        all_tasks: {
+          name: 'all_tasks',
+          label: 'All Tasks',
+          type: 'grid' as const,
+          data: { provider: 'object' as const, object: 'task' },
+          columns: ['subject', 'priority', 'is_completed', 'created_at'],
+          sort: [{ field: 'created_at', order: 'desc' as const }],
+        },
+      },
+    },
+  ],
   apps: [
     App.create({
       name: 'task_app',

examples/todo/objectstack.config.ts

@@ -107,8 +107,10 @@ export default defineStack({
   ],
   dashboards: [
     {
+      type: 'dashboard' as const,
       name: 'task_dashboard',
       label: 'Task Overview',
+      description: 'Task metrics, status distribution, and category breakdown',
       widgets: [
         {
           id: 'todo_total_tasks',