Merge pull request #1279 from objectstack-ai/copilot/update-action-job-configuration-again

Author: hotlong

CHANGELOG.md

@@ -7,6 +7,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Fixed
+
+- **`@object-ui/fields`**: Fixed flaky `RecordPickerDialog` test that asserted
+  `renderGrid` slot props before async data fetch had completed. The test now
+  awaits the final render with populated records before asserting.
+- **`apps/console`**: Removed non-existent `pnpm msw:init` step from Vercel
+  build command that caused deployment failures (exit code 254).
+
 ### Changed
 
 - **`MetadataProvider` now lazy-loads metadata.** Previously the console

apps/console/vercel.json

@@ -1,7 +1,7 @@
 {
   "$schema": "https://openapi.vercel.sh/vercel.json",
   "installCommand": "cd ../.. && pnpm install --frozen-lockfile",
-  "buildCommand": "cd ../.. && pnpm --filter @object-ui/app-shell... build && cd apps/console && pnpm msw:init && NODE_OPTIONS=--max-old-space-size=4096 VITE_USE_MOCK_SERVER=false VITE_BASE_PATH=/ vite build",
+  "buildCommand": "cd ../.. && pnpm --filter @object-ui/app-shell... build && cd apps/console && NODE_OPTIONS=--max-old-space-size=4096 VITE_USE_MOCK_SERVER=false VITE_BASE_PATH=/ vite build",
   "outputDirectory": "dist",
   "framework": "vite",
   "rewrites": [

packages/fields/src/record-picker.test.tsx

@@ -1113,29 +1113,36 @@ describe('RecordPickerDialog — renderGrid slot', () => {
       expect(screen.getByTestId('custom-grid')).toBeInTheDocument();
     });
 
-    // renderGrid should have been called with grid slot props
-    expect(renderGrid).toHaveBeenCalledWith(
-      expect.objectContaining({
-        columns: expect.arrayContaining([
-          expect.objectContaining({ field: 'name' }),
-        ]),
-        records: expect.arrayContaining([
-          expect.objectContaining({ id: '1', name: 'Acme Corp' }),
-        ]),
-        loading: false,
-        totalCount: 1,
-        currentPage: 1,
-        pageSize: 10,
-        sortField: null,
-        sortDirection: 'asc',
-        onSort: expect.any(Function),
-        onPageChange: expect.any(Function),
-        onRowClick: expect.any(Function),
-        isSelected: expect.any(Function),
-        multiple: false,
-        idField: 'id',
-      }),
-    );
+    // Wait for data to load, then check the last renderGrid call has records
+    await waitFor(() => {
+      expect(renderGrid).toHaveBeenLastCalledWith(
+        expect.objectContaining({
+          columns: expect.arrayContaining([
+            expect.objectContaining({ field: 'name' }),
+          ]),
+          records: expect.arrayContaining([
+            expect.objectContaining({ id: '1', name: 'Acme Corp' }),
+          ]),
+          loading: false,
+          totalCount: 1,
+        }),
+      );
+    });
+
+    // Verify all expected props are present in the last call
+    const lastCallArgs = renderGrid.mock.calls[renderGrid.mock.calls.length - 1][0];
+    expect(lastCallArgs).toMatchObject({
+      currentPage: 1,
+      pageSize: 10,
+      sortField: null,
+      sortDirection: 'asc',
+      multiple: false,
+      idField: 'id',
+    });
+    expect(lastCallArgs.onSort).toBeTypeOf('function');
+    expect(lastCallArgs.onPageChange).toBeTypeOf('function');
+    expect(lastCallArgs.onRowClick).toBeTypeOf('function');
+    expect(lastCallArgs.isSelected).toBeTypeOf('function');
   });
 
   it('hides built-in table when renderGrid is provided', async () => {