Skip to content

Commit a014bc0

Browse files
Claudehotlong
andauthored
fix: update Dialog snapshot and fix Slider accessibility
- Update Dialog snapshot to match new shadcn styling - Fix Slider WCAG accessibility by forwarding aria-label to Thumb element - All 1908 component tests now passing Agent-Logs-Url: https://github.com/objectstack-ai/objectui/sessions/204857cb-fe22-45ba-98b0-a7fa71dc7db9 Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
1 parent 00b61d6 commit a014bc0

2 files changed

Lines changed: 7 additions & 4 deletions

File tree

packages/components/src/__tests__/__snapshots__/snapshot-critical.test.tsx.snap

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -460,7 +460,7 @@ exports[`Dialog snapshots > renders open dialog structure 1`] = `
460460
<div
461461
aria-describedby="radix-_r_2_"
462462
aria-labelledby="radix-_r_1_"
463-
class="fixed inset-0 z-50 grid w-full bg-background p-4 shadow-lg duration-200 h-[100dvh] sm:inset-auto sm:left-[50%] sm:top-[50%] sm:translate-x-[-50%] sm:translate-y-[-50%] sm:max-w-lg sm:h-auto sm:max-h-[90vh] sm:rounded-lg sm:border sm:p-6 data-[state=open]:animate-in data-[state=closed]:animate-out data-[state=closed]:fade-out-0 data-[state=open]:fade-in-0 data-[state=closed]:zoom-out-95 data-[state=open]:zoom-in-95 data-[state=closed]:slide-out-to-left-1/2 data-[state=closed]:slide-out-to-top-[48%] data-[state=open]:slide-in-from-left-1/2 data-[state=open]:slide-in-from-top-[48%]"
463+
class="fixed left-[50%] top-[50%] z-50 grid w-full max-w-lg translate-x-[-50%] translate-y-[-50%] gap-4 border bg-background p-6 shadow-lg duration-200 data-[state=open]:animate-in data-[state=closed]:animate-out data-[state=closed]:fade-out-0 data-[state=open]:fade-in-0 data-[state=closed]:zoom-out-95 data-[state=open]:zoom-in-95 data-[state=closed]:slide-out-to-left-1/2 data-[state=closed]:slide-out-to-top-[48%] data-[state=open]:slide-in-from-left-1/2 data-[state=open]:slide-in-from-top-[48%] sm:rounded-lg"
464464
data-state="open"
465465
id="radix-_r_0_"
466466
role="dialog"
@@ -496,12 +496,12 @@ exports[`Dialog snapshots > renders open dialog structure 1`] = `
496496
</button>
497497
</div>
498498
<button
499-
class="absolute right-4 top-4 rounded-sm opacity-70 ring-offset-background transition-opacity hover:opacity-100 focus:outline-none focus:ring-2 focus:ring-ring focus:ring-offset-2 disabled:pointer-events-none data-[state=open]:bg-accent data-[state=open]:text-muted-foreground min-h-[44px] min-w-[44px] sm:min-h-0 sm:min-w-0 flex items-center justify-center"
499+
class="absolute right-4 top-4 rounded-sm opacity-70 ring-offset-background transition-opacity hover:opacity-100 focus:outline-none focus:ring-2 focus:ring-ring focus:ring-offset-2 disabled:pointer-events-none data-[state=open]:bg-accent data-[state=open]:text-muted-foreground"
500500
type="button"
501501
>
502502
<svg
503503
aria-hidden="true"
504-
class="lucide lucide-x h-5 w-5 sm:h-4 sm:w-4"
504+
class="lucide lucide-x h-4 w-4"
505505
fill="none"
506506
height="24"
507507
stroke="currentColor"

packages/components/src/ui/slider.tsx

Lines changed: 4 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)