Skip to content

Commit a0d1320

Browse files
Copilothotlong
andcommitted
fix: address code review feedback - extract constant, fix button title, remove redundant comment
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
1 parent 1fa0847 commit a0d1320

3 files changed

Lines changed: 6 additions & 5 deletions

File tree

packages/collaboration/src/CommentThread.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -514,7 +514,7 @@ export function CommentThread({
514514
onReaction && React.createElement('button', {
515515
style: styles.reactionPicker,
516516
onClick: () => onReaction(comment.id, '👍'),
517-
title: 'Add reaction',
517+
title: 'Add thumbs up',
518518
}, '+'),
519519
),
520520
// Actions

packages/plugin-form/src/EmbeddableForm.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,6 @@ export const EmbeddableForm: React.FC<EmbeddableFormProps> = ({
9494
if (typeof window !== 'undefined') {
9595
const urlParams = new URLSearchParams(window.location.search);
9696
urlParams.forEach((value, key) => {
97-
// Only set if not already set by explicit prefillParams
9897
if (!(key in data)) {
9998
data[key] = value;
10099
}

packages/plugin-kanban/src/KanbanImpl.tsx

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,8 @@ import { Plus } from "lucide-react"
3232
// Utility function to merge class names (inline to avoid external dependency)
3333
const cn = (...classes: (string | undefined)[]) => classes.filter(Boolean).join(' ')
3434

35+
const UNCATEGORIZED_LANE = 'Uncategorized'
36+
3537
export interface KanbanCard {
3638
id: string
3739
title: string
@@ -338,7 +340,7 @@ function KanbanBoardInner({ columns, onCardMove, onCardClick, className, dnd, qu
338340
const laneValues = new Set<string>()
339341
allCards.forEach(card => {
340342
const val = card[swimlaneField]
341-
laneValues.add(val != null ? String(val) : 'Uncategorized')
343+
laneValues.add(val != null ? String(val) : UNCATEGORIZED_LANE)
342344
})
343345
return Array.from(laneValues).sort()
344346
}, [boardColumns, swimlaneField])
@@ -507,7 +509,7 @@ function KanbanBoardInner({ columns, onCardMove, onCardClick, className, dnd, qu
507509
{swimlanes.map(lane => {
508510
const isCollapsed = collapsedLanes.has(lane)
509511
const laneCardCount = boardColumns.reduce((sum, col) =>
510-
sum + col.cards.filter(c => (c[swimlaneField!] != null ? String(c[swimlaneField!]) : 'Uncategorized') === lane).length, 0)
512+
sum + col.cards.filter(c => (c[swimlaneField!] != null ? String(c[swimlaneField!]) : UNCATEGORIZED_LANE) === lane).length, 0)
511513

512514
return (
513515
<div key={lane} className="border rounded-lg bg-muted/10">
@@ -527,7 +529,7 @@ function KanbanBoardInner({ columns, onCardMove, onCardClick, className, dnd, qu
527529
<div className="flex gap-3 sm:gap-4 overflow-x-auto px-2 pb-3 pl-36 sm:pl-44">
528530
{boardColumns.map(col => {
529531
const laneCards = col.cards.filter(c =>
530-
(c[swimlaneField!] != null ? String(c[swimlaneField!]) : 'Uncategorized') === lane
532+
(c[swimlaneField!] != null ? String(c[swimlaneField!]) : UNCATEGORIZED_LANE) === lane
531533
)
532534
return (
533535
<div key={col.id} className="w-[85vw] sm:w-80 flex-shrink-0 min-h-[60px] rounded-md bg-card/20 p-2">

0 commit comments

Comments
 (0)