Skip to content

Commit a69df3f

Browse files
authored
Merge pull request #685 from objectstack-ai/copilot/fix-unused-variable-warnings
2 parents c3b0e36 + 1aac3e6 commit a69df3f

File tree

2 files changed

+1
-10
lines changed

2 files changed

+1
-10
lines changed

apps/console/src/components/ObjectView.tsx

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ import { Button, Empty, EmptyTitle, EmptyDescription, NavigationOverlay, Dropdow
2424
import { Plus, Table as TableIcon, Settings2, Wrench, KanbanSquare, Calendar, LayoutGrid, Activity, GanttChart, MapPin, BarChart3, ChevronRight } from 'lucide-react';
2525
import type { ListViewSchema, ViewNavigationConfig } from '@object-ui/types';
2626
import { MetadataToggle, MetadataPanel, useMetadataInspector } from './MetadataInspector';
27-
import { ViewConfigPanel, type EditorPanelType } from './ViewConfigPanel';
27+
import { ViewConfigPanel } from './ViewConfigPanel';
2828
import { useObjectActions } from '../hooks/useObjectActions';
2929
import { useObjectTranslation } from '@object-ui/i18n';
3030
import { usePermissions } from '@object-ui/permissions';
@@ -89,10 +89,6 @@ export function ObjectView({ dataSource, objects, onEdit, onRowClick }: any) {
8989
}
9090
}, [dataSource, objectName]);
9191

92-
const handleOpenEditor = useCallback((editor: EditorPanelType) => {
93-
console.info('[ViewConfigPanel] Open editor:', editor);
94-
}, []);
95-
9692
// Record count tracking for footer
9793
const [recordCount, setRecordCount] = useState<number | undefined>(undefined);
9894

@@ -536,7 +532,6 @@ export function ObjectView({ dataSource, objects, onEdit, onRowClick }: any) {
536532
activeView={activeView}
537533
objectDef={objectDef}
538534
recordCount={recordCount}
539-
onOpenEditor={handleOpenEditor}
540535
onSave={handleViewConfigSave}
541536
onViewUpdate={handleViewUpdate}
542537
/>

apps/console/src/components/ViewConfigPanel.tsx

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -182,8 +182,6 @@ const VIEW_TYPE_LABELS: Record<string, string> = {
182182
const VIEW_TYPE_OPTIONS = Object.keys(VIEW_TYPE_LABELS);
183183

184184
/** Editor panel types that can be opened from clickable rows */
185-
export type EditorPanelType = 'columns' | 'filters' | 'sort';
186-
187185
export interface ViewConfigPanelProps {
188186
/** Whether the panel is open */
189187
open: boolean;
@@ -219,8 +217,6 @@ export interface ViewConfigPanelProps {
219217
recordCount?: number;
220218
/** Called when any view config field changes (local draft update) */
221219
onViewUpdate?: (field: string, value: any) => void;
222-
/** Called to open a sub-editor panel (columns, filters, sort) */
223-
onOpenEditor?: (editor: EditorPanelType) => void;
224220
/** Called to persist all draft changes */
225221
onSave?: (draft: Record<string, any>) => void;
226222
}

0 commit comments

Comments
 (0)