Commit acf367d
fix: address code review - validate stored width, extract constants, dedupe label resolver
- sidebar.tsx: Validate localStorage width against min/max bounds, handle NaN
- sidebar.tsx: Extract SIDEBAR_DEFAULT_WIDTH_PX and SIDEBAR_CLICK_THRESHOLD_PX constants
- header-bar.tsx: Use shared resolveI18nLabel from @object-ui/react instead of local duplicate
- breadcrumb.tsx: Use shared resolveI18nLabel from @object-ui/react instead of local duplicate
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>1 parent 0486f28 commit acf367d
File tree
3 files changed
+15
-22
lines changed- packages/components/src
- renderers
- data-display
- ui
3 files changed
+15
-22
lines changedLines changed: 3 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
14 | | - | |
15 | | - | |
16 | | - | |
17 | | - | |
18 | | - | |
19 | | - | |
| 13 | + | |
20 | 14 | | |
21 | 15 | | |
22 | 16 | | |
| |||
38 | 32 | | |
39 | 33 | | |
40 | 34 | | |
41 | | - | |
| 35 | + | |
42 | 36 | | |
43 | | - | |
| 37 | + | |
44 | 38 | | |
45 | 39 | | |
46 | 40 | | |
| |||
Lines changed: 3 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| 12 | + | |
12 | 13 | | |
13 | 14 | | |
14 | 15 | | |
| |||
20 | 21 | | |
21 | 22 | | |
22 | 23 | | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | 24 | | |
31 | 25 | | |
32 | 26 | | |
| |||
38 | 32 | | |
39 | 33 | | |
40 | 34 | | |
41 | | - | |
| 35 | + | |
42 | 36 | | |
43 | | - | |
| 37 | + | |
44 | 38 | | |
45 | 39 | | |
46 | 40 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments