Skip to content

Commit af7a4a0

Browse files
Copilothotlong
andcommitted
refactor: address code review comment wording improvements
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com> Agent-Logs-Url: https://github.com/objectstack-ai/objectui/sessions/7998282e-22f9-4b45-aca5-8f86440779c9
1 parent c7a194e commit af7a4a0

3 files changed

Lines changed: 4 additions & 3 deletions

File tree

apps/console/src/__tests__/DuplicateData.test.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ describe('Duplicate Data Prevention', () => {
146146
});
147147

148148
it('should not show duplicate events with wrapped response format', async () => {
149-
// ObjectStack adapter returns { data: [...], total, page, pageSize }
149+
// Test with ObjectStack response format: { data: [...], total, page, pageSize }
150150
mockDataSource.find.mockResolvedValue({
151151
data: records,
152152
total: records.length,

packages/plugin-kanban/src/ObjectKanban.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,8 @@ export const ObjectKanban: React.FC<ObjectKanbanProps> = ({
3737
...props
3838
}) => {
3939
// When a parent (e.g. ListView) pre-fetches data and passes it via the `data` prop,
40-
// we must not trigger a second fetch. Detect external data by checking for an array.
40+
// we must not trigger a second fetch. Detect external data by checking if externalData
41+
// is an array (undefined when not provided by parent).
4142
const hasExternalData = Array.isArray(externalData);
4243

4344
const [fetchedData, setFetchedData] = useState<any[]>([]);

packages/plugin-list/src/__tests__/DataFetch.test.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ describe('ListView Data Fetch', () => {
114114
});
115115

116116
// =========================================================================
117-
// OData { value: [] } response format (duplicate data fix)
117+
// OData { value: [] } response format handling
118118
// =========================================================================
119119
describe('OData value response format', () => {
120120
it('should extract records from { value: [] } OData response', async () => {

0 commit comments

Comments
 (0)