fix(console): preload object/dashboard/report/page in AppContent to avoid hook-order crash

Agent-Logs-Url: https://github.com/objectstack-ai/objectui/sessions/7fce824c-10a5-4953-8cfd-92d1f64f54a3

Co-authored-by: xuyushun441-sys <255036401+xuyushun441-sys@users.noreply.github.com>

Author: Copilot

CHANGELOG.md

@@ -30,6 +30,19 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Fixed
 
+- **"Object Not Found" / React "Rendered more hooks" crash on app entry.**
+  A regression introduced by the lazy `MetadataProvider` refactor above:
+  `useMetadata().objects` started empty while the lazy fetch was in flight,
+  so `ObjectView` hit its `if (!objectDef) return <Empty/>` early return on
+  the first render; once the fetch resolved, the hooks declared below that
+  early return ran and React threw _"Rendered more hooks than during the
+  previous render"_. `AppContent` now preloads the `object`, `dashboard`,
+  `report`, and `page` buckets (via `ensureType`) before rendering the
+  routes under `/apps/:appName/*`, so legacy components that assume
+  metadata is fully loaded by render time continue to work. `/home`,
+  `/login` and `/register` do not go through `AppContent`, so the Phase 1
+  benefit of fetching only the `app` list at boot is preserved.
+
 - **Record detail header** no longer renders two separate "More" (⋯) overflow
   menus when an object defines more `record_header` actions than
   `maxVisible`. The hardcoded `<DropdownMenu>` inside

apps/console/src/App.tsx

@@ -99,9 +99,42 @@ export function AppContent() {
   const navigate = useNavigate();
   const location = useLocation();
   const { appName } = useParams();
-  const { apps, objects: allObjects, loading: metadataLoading } = useMetadata();
+  const { apps, objects: allObjects, loading: metadataLoading, ensureType } = useMetadata();
   const { t } = useObjectTranslation();
   const { objectLabel } = useObjectLabel();
+
+  // Preload the metadata buckets that the routes under /apps/:appName/* assume
+  // are fully loaded by render time. The Phase-1 MetadataProvider refactor
+  // made these buckets lazy (only `app` is eager); without this preload some
+  // legacy consumers (notably `ObjectView`) would mount with `objects=[]`,
+  // hit an `if (!objectDef) return <Empty/>` early-return, then break React's
+  // rules-of-hooks once the lazy fetch resolves and the hooks below the early
+  // return start running. /home and /login don't go through AppContent, so
+  // they keep the Phase-1 benefit of fetching only the `app` list at boot.
+  //
+  // `ensureType` is optional at the destructure site so that the many test
+  // files which provide a partial `useMetadata()` mock continue to work
+  // unchanged; in those environments the preload is a no-op (the mocked
+  // metadata arrays are already populated synchronously).
+  const [scopeMetaReady, setScopeMetaReady] = useState(!ensureType);
+  useEffect(() => {
+    if (!ensureType) {
+      setScopeMetaReady(true);
+      return;
+    }
+    let cancelled = false;
+    Promise.all([
+      ensureType('object'),
+      ensureType('dashboard'),
+      ensureType('report'),
+      ensureType('page'),
+    ]).finally(() => {
+      if (!cancelled) setScopeMetaReady(true);
+    });
+    return () => {
+      cancelled = true;
+    };
+  }, [ensureType]);
 
   // Determine active app based on URL
   const activeApps = apps.filter((a: any) => a.active !== false);
@@ -253,7 +286,7 @@ export function AppContent() {
     [user, activeApp, editingRecord]
   );
 
-  if (!dataSource || metadataLoading) return <LoadingScreen />;
+  if (!dataSource || metadataLoading || !scopeMetaReady) return <LoadingScreen />;
 
   // Allow create-app route even when no active app exists
   const isCreateAppRoute = location.pathname.endsWith('/create-app');