Skip to content

Commit b2b0b41

Browse files
authored
Merge pull request #163 from objectstack-ai/copilot/fix-mobile-display-components
2 parents 464e9c8 + c5fc193 commit b2b0b41

File tree

18 files changed

+54
-47
lines changed

18 files changed

+54
-47
lines changed

.gitignore

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,3 +48,6 @@ docs/.vitepress/cache
4848
apps/site/.next
4949
apps/site/.map.ts
5050
apps/site/.source
51+
52+
# Test artifacts
53+
test-screenshots

packages/components/src/renderers/basic/button-group.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ ComponentRegistry.register('button-group',
2222

2323
return (
2424
<div
25-
className={cn('inline-flex rounded-md shadow-sm', schema.className)}
25+
className={cn('flex flex-wrap sm:inline-flex rounded-md shadow-sm', schema.className)}
2626
role="group"
2727
{...buttonGroupProps}
2828
{...{ 'data-obj-id': dataObjId, 'data-obj-type': dataObjType, style }}

packages/components/src/renderers/basic/div.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ ComponentRegistry.register('div',
4343
{ name: 'className', type: 'string', label: 'CSS Class' }
4444
],
4545
defaultProps: {
46-
className: 'p-4 border border-dashed border-gray-300 rounded min-h-[100px]'
46+
className: 'p-2 sm:p-4 border border-dashed border-gray-300 rounded min-h-[100px]'
4747
}
4848
}
4949
);

packages/components/src/renderers/basic/image.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,9 @@ ComponentRegistry.register('image',
4040
{ name: 'src', type: 'string', label: 'Source URL' },
4141
{ name: 'alt', type: 'string', label: 'Alt Text' },
4242
{ name: 'className', type: 'string', label: 'Classes' }
43-
]
43+
],
44+
defaultProps: {
45+
className: 'max-w-full h-auto'
46+
}
4447
}
4548
);

packages/components/src/renderers/basic/navigation-menu.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ ComponentRegistry.register('navigation-menu',
3333
<>
3434
<NavigationMenuTrigger>{item.label}</NavigationMenuTrigger>
3535
<NavigationMenuContent>
36-
<ul className="grid w-[400px] gap-3 p-4 md:w-[500px] md:grid-cols-2 lg:w-[600px]">
36+
<ul className="grid w-full gap-3 p-4 sm:w-[400px] md:w-[500px] md:grid-cols-2 lg:w-[600px]">
3737
{item.children.map((child, childIdx) => (
3838
<li key={childIdx}>
3939
<NavigationMenuLink asChild>

packages/components/src/renderers/basic/separator.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ ComponentRegistry.register('separator',
5050
],
5151
defaultProps: {
5252
orientation: 'horizontal',
53-
className: 'my-4'
53+
className: 'my-2 sm:my-4'
5454
}
5555
}
5656
);

packages/components/src/renderers/basic/span.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ ComponentRegistry.register('span',
4343
{ name: 'className', type: 'string', label: 'CSS Class' }
4444
],
4545
defaultProps: {
46-
className: 'px-2 py-1'
46+
className: 'px-1.5 py-0.5 sm:px-2 sm:py-1'
4747
},
4848
defaultChildren: [
4949
{ type: 'text', content: 'Inline text' }

packages/components/src/renderers/complex/carousel.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -58,9 +58,9 @@ ComponentRegistry.register('carousel',
5858
orientation: 'horizontal',
5959
showArrows: true,
6060
items: [
61-
[{ type: 'div', className: 'p-8 border rounded bg-slate-50', body: [{ type: 'text', content: 'Slide 1' }] }],
62-
[{ type: 'div', className: 'p-8 border rounded bg-slate-50', body: [{ type: 'text', content: 'Slide 2' }] }],
63-
[{ type: 'div', className: 'p-8 border rounded bg-slate-50', body: [{ type: 'text', content: 'Slide 3' }] }]
61+
[{ type: 'div', className: 'p-4 sm:p-6 md:p-8 border rounded bg-slate-50', body: [{ type: 'text', content: 'Slide 1' }] }],
62+
[{ type: 'div', className: 'p-4 sm:p-6 md:p-8 border rounded bg-slate-50', body: [{ type: 'text', content: 'Slide 2' }] }],
63+
[{ type: 'div', className: 'p-4 sm:p-6 md:p-8 border rounded bg-slate-50', body: [{ type: 'text', content: 'Slide 3' }] }]
6464
],
6565
className: 'w-full max-w-xs'
6666
}

packages/components/src/renderers/data-display/kbd.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ ComponentRegistry.register('kbd',
2222
const keys = Array.isArray(schema.keys) ? schema.keys : [schema.keys || schema.label || 'K'];
2323

2424
return (
25-
<div className={cn('inline-flex gap-1', schema.className)}>
25+
<div className={cn('inline-flex flex-wrap gap-1', schema.className)}>
2626
{keys.map((key, idx) => (
2727
<kbd
2828
key={idx}

packages/components/src/renderers/data-display/statistic.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import { TrendingUp, TrendingDown, Minus } from 'lucide-react';
1414
const StatisticRenderer = ({ schema }: { schema: StatisticSchema }) => {
1515
return (
1616
<div className={cn(
17-
"group relative flex flex-col p-6 rounded-xl border bg-card text-card-foreground shadow-sm",
17+
"group relative flex flex-col p-4 sm:p-5 md:p-6 rounded-xl border bg-card text-card-foreground shadow-sm",
1818
schema.className
1919
)}>
2020
{/* Label */}

0 commit comments

Comments
 (0)