Skip to content

Commit b4c18ee

Browse files
Claudehotlong
andauthored
fix: align NavigationItem and NavigationArea label types with @objectstack/spec v4
Updated NavigationItem.label and NavigationArea.label to use plain string type instead of the legacy i18n object format `{key, defaultValue}`. This aligns our type definitions with @objectstack/spec v4 protocol which requires label fields to be plain strings only. Note: The validation warning from @objectstack/plugin-auth persists because that package's runtime code still transforms string labels into i18n objects. This is an upstream issue in the @objectstack framework. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
1 parent 7c98944 commit b4c18ee

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

packages/types/src/app.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,8 @@ export interface NavigationItem {
5555
/** Navigation item type */
5656
type: NavigationItemType;
5757

58-
/** Display label (plain string or I18nLabel object for internationalization) */
59-
label: string | { key: string; defaultValue?: string; params?: Record<string, any> };
58+
/** Display label (plain string per @objectstack/spec v4 protocol) */
59+
label: string;
6060

6161
/** Icon name (Lucide) */
6262
icon?: string;
@@ -129,8 +129,8 @@ export interface NavigationArea {
129129
/** Unique identifier */
130130
id: string;
131131

132-
/** Display label (plain string or I18nLabel object for internationalization) */
133-
label: string | { key: string; defaultValue?: string; params?: Record<string, any> };
132+
/** Display label (plain string per @objectstack/spec v4 protocol) */
133+
label: string;
134134

135135
/** Icon name (Lucide) */
136136
icon?: string;

0 commit comments

Comments
 (0)