Skip to content

Commit c2da555

Browse files
Copilothotlong
andcommitted
style: format checkbox inputs and remove regex workaround from fieldCount column label
Agent-Logs-Url: https://github.com/objectstack-ai/objectui/sessions/1fc56880-e6fe-4a79-b357-ecc715973306 Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
1 parent 64eb668 commit c2da555

2 files changed

Lines changed: 57 additions & 8 deletions

File tree

packages/plugin-designer/src/FieldDesigner.tsx

Lines changed: 56 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -267,31 +267,80 @@ function FieldEditor({ field, onChange, onClose, readOnly, t }: FieldEditorProps
267267
{/* Boolean toggles */}
268268
<div className="space-y-2">
269269
<label className="flex items-center gap-2">
270-
<input type="checkbox" checked={field.required || false} onChange={(e) => update({ required: e.target.checked })} disabled={readOnly} data-testid="field-editor-required" className="h-3.5 w-3.5 rounded border-gray-300" />
270+
<input
271+
type="checkbox"
272+
checked={field.required || false}
273+
onChange={(e) => update({ required: e.target.checked })}
274+
disabled={readOnly}
275+
data-testid="field-editor-required"
276+
className="h-3.5 w-3.5 rounded border-gray-300"
277+
/>
271278
<span className="text-xs text-gray-700">{t('appDesigner.fieldDesigner.required')}</span>
272279
</label>
273280
<label className="flex items-center gap-2">
274-
<input type="checkbox" checked={field.unique || false} onChange={(e) => update({ unique: e.target.checked })} disabled={readOnly} data-testid="field-editor-unique" className="h-3.5 w-3.5 rounded border-gray-300" />
281+
<input
282+
type="checkbox"
283+
checked={field.unique || false}
284+
onChange={(e) => update({ unique: e.target.checked })}
285+
disabled={readOnly}
286+
data-testid="field-editor-unique"
287+
className="h-3.5 w-3.5 rounded border-gray-300"
288+
/>
275289
<span className="text-xs text-gray-700">{t('appDesigner.fieldDesigner.unique')}</span>
276290
</label>
277291
<label className="flex items-center gap-2">
278-
<input type="checkbox" checked={field.readonly || false} onChange={(e) => update({ readonly: e.target.checked })} disabled={readOnly} data-testid="field-editor-readonly" className="h-3.5 w-3.5 rounded border-gray-300" />
292+
<input
293+
type="checkbox"
294+
checked={field.readonly || false}
295+
onChange={(e) => update({ readonly: e.target.checked })}
296+
disabled={readOnly}
297+
data-testid="field-editor-readonly"
298+
className="h-3.5 w-3.5 rounded border-gray-300"
299+
/>
279300
<span className="text-xs text-gray-700">{t('appDesigner.fieldDesigner.readOnly')}</span>
280301
</label>
281302
<label className="flex items-center gap-2">
282-
<input type="checkbox" checked={field.hidden || false} onChange={(e) => update({ hidden: e.target.checked })} disabled={readOnly} data-testid="field-editor-hidden" className="h-3.5 w-3.5 rounded border-gray-300" />
303+
<input
304+
type="checkbox"
305+
checked={field.hidden || false}
306+
onChange={(e) => update({ hidden: e.target.checked })}
307+
disabled={readOnly}
308+
data-testid="field-editor-hidden"
309+
className="h-3.5 w-3.5 rounded border-gray-300"
310+
/>
283311
<span className="text-xs text-gray-700">{t('appDesigner.fieldDesigner.hidden')}</span>
284312
</label>
285313
<label className="flex items-center gap-2">
286-
<input type="checkbox" checked={field.indexed || false} onChange={(e) => update({ indexed: e.target.checked })} disabled={readOnly} data-testid="field-editor-indexed" className="h-3.5 w-3.5 rounded border-gray-300" />
314+
<input
315+
type="checkbox"
316+
checked={field.indexed || false}
317+
onChange={(e) => update({ indexed: e.target.checked })}
318+
disabled={readOnly}
319+
data-testid="field-editor-indexed"
320+
className="h-3.5 w-3.5 rounded border-gray-300"
321+
/>
287322
<span className="text-xs text-gray-700">{t('appDesigner.fieldDesigner.indexed')}</span>
288323
</label>
289324
<label className="flex items-center gap-2">
290-
<input type="checkbox" checked={field.externalId || false} onChange={(e) => update({ externalId: e.target.checked })} disabled={readOnly} data-testid="field-editor-external-id" className="h-3.5 w-3.5 rounded border-gray-300" />
325+
<input
326+
type="checkbox"
327+
checked={field.externalId || false}
328+
onChange={(e) => update({ externalId: e.target.checked })}
329+
disabled={readOnly}
330+
data-testid="field-editor-external-id"
331+
className="h-3.5 w-3.5 rounded border-gray-300"
332+
/>
291333
<span className="text-xs text-gray-700">{t('appDesigner.fieldDesigner.externalId')}</span>
292334
</label>
293335
<label className="flex items-center gap-2">
294-
<input type="checkbox" checked={field.trackHistory || false} onChange={(e) => update({ trackHistory: e.target.checked })} disabled={readOnly} data-testid="field-editor-track-history" className="h-3.5 w-3.5 rounded border-gray-300" />
336+
<input
337+
type="checkbox"
338+
checked={field.trackHistory || false}
339+
onChange={(e) => update({ trackHistory: e.target.checked })}
340+
disabled={readOnly}
341+
data-testid="field-editor-track-history"
342+
className="h-3.5 w-3.5 rounded border-gray-300"
343+
/>
295344
<span className="text-xs text-gray-700">{t('appDesigner.fieldDesigner.trackHistory')}</span>
296345
</label>
297346
</div>

packages/plugin-designer/src/ObjectManager.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ export function ObjectManager({
107107
{ name: 'name', label: t('appDesigner.objectManager.objectName'), width: 160 },
108108
{ name: 'label', label: t('appDesigner.objectManager.objectLabel'), width: 160 },
109109
{ name: 'group', label: t('appDesigner.objectManager.group'), width: 130 },
110-
{ name: 'fieldCount', label: t('appDesigner.objectManager.fieldCount', { count: '' }).replace(/\s*$/, ''), width: 80 },
110+
{ name: 'fieldCount', label: 'Fields', width: 80 },
111111
{ name: 'enabled', label: t('appDesigner.objectManager.enabled'), width: 80 },
112112
], [t]);
113113

0 commit comments

Comments
 (0)