fix(app-shell): hydrated server history renders Completed + unified 'Assistant' label everywhere (#1657)

Two gaps found in live staging verification of the unified assistant:

1. Stateless tool parts spun forever: server conversations persist
   ModelMessage content whose tool-call entries carry NO UI state;
   contentToParts passes them through verbatim, partToolState's default
   returned undefined, and the chip rendered 'Running' eternally. In
   hydrated history the turn has ended — stateless ≡ completed.

2. The server-side data_chat agent now says 'Assistant' (builtin upsert),
   but three client spots still hardcoded 'Data Assistant' / '数据助手'
   (AiChatPage i18n default, en/zh locale catalogs, ConsoleFloatingChatbot
   fallback map) and overrode it. Now 'Assistant' / '智能助手'.

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

Author: os-zhuang

packages/app-shell/src/console/ai/AiChatPage.tsx

@@ -83,11 +83,18 @@ function partToolState(part: HydratedUIMessagePart): ChatbotEnhancedToolInvocati
     case 'output-denied':
       return state;
     default:
-      return undefined;
+      // No state at all: server-side conversations persist ModelMessage
+      // `tool-call` content entries, which carry no UI state — contentToParts
+      // passes them through as `tool-call` parts verbatim. In hydrated
+      // history that turn has ended too, so stateless ≡ completed; returning
+      // undefined here leaves the invocation state-less and the chip renders
+      // "Running" forever (the live-verified gap left by the first fix).
+      return 'output-available';
   }
 }
 
-function hydratedMessagesToChatMessages(messages: HydratedUIMessage[]): ChatMessage[] {
+/** Exported for tests — maps persisted/cached history to renderable messages. */
+export function hydratedMessagesToChatMessages(messages: HydratedUIMessage[]): ChatMessage[] {
   return messages.map((message) => {
     const toolInvocations: ChatbotEnhancedToolInvocation[] = [];
     const content = message.parts
@@ -130,7 +137,7 @@ function firstUserMessageText(messages: HydratedUIMessage[]): string | undefined
 }
 
 const PLATFORM_AGENT_LABEL_KEYS: Record<string, { key: string; defaultValue: string }> = {
-  data_chat: { key: 'console.ai.agentLabels.dataChat', defaultValue: 'Data Assistant' },
+  data_chat: { key: 'console.ai.agentLabels.dataChat', defaultValue: 'Assistant' },
   metadata_assistant: { key: 'console.ai.agentLabels.metadataAssistant', defaultValue: 'Metadata Assistant' },
 };
 

packages/app-shell/src/console/ai/__tests__/AiChatPage.hydration.test.ts

@@ -0,0 +1,48 @@
+// Copyright (c) 2025 ObjectStack. Licensed under the Apache-2.0 license.
+
+import { describe, it, expect } from 'vitest';
+import { hydratedMessagesToChatMessages } from '../AiChatPage';
+import type { HydratedUIMessage } from '../../../hooks/useChatConversation';
+
+function assistantWith(parts: HydratedUIMessage['parts']): HydratedUIMessage[] {
+  return [{ id: 'm1', role: 'assistant', parts }];
+}
+
+describe('AiChatPage hydration — tool invocation states', () => {
+  it('promotes STATELESS tool parts to output-available (server ModelMessage tool-call entries)', () => {
+    // Server conversations persist ModelMessage content: `tool-call` entries
+    // carry toolName/toolCallId but NO UI state. Hydrated history has ended,
+    // so stateless must render Completed — not an eternal "Running" chip.
+    const [msg] = hydratedMessagesToChatMessages(
+      assistantWith([
+        { type: 'tool-call', toolCallId: 't1', toolName: 'propose_blueprint' },
+      ]),
+    );
+    expect(msg.toolInvocations).toEqual([
+      { toolCallId: 't1', toolName: 'propose_blueprint', state: 'output-available' },
+    ]);
+  });
+
+  it('promotes dangling mid-stream states to output-available', () => {
+    const [msg] = hydratedMessagesToChatMessages(
+      assistantWith([
+        { type: 'tool-add_field', toolCallId: 't1', toolName: 'add_field', state: 'input-available' },
+        { type: 'tool-create_metadata', toolCallId: 't2', toolName: 'create_metadata', state: 'input-streaming' },
+      ]),
+    );
+    expect(msg.toolInvocations?.map((t) => t.state)).toEqual(['output-available', 'output-available']);
+  });
+
+  it('preserves genuine terminal states', () => {
+    const [msg] = hydratedMessagesToChatMessages(
+      assistantWith([
+        { type: 'tool-add_field', toolCallId: 't1', toolName: 'add_field', state: 'output-error', errorText: 'boom' },
+        { type: 'tool-verify_build', toolCallId: 't2', toolName: 'verify_build', state: 'output-denied' },
+      ]),
+    );
+    expect(msg.toolInvocations).toEqual([
+      { toolCallId: 't1', toolName: 'add_field', state: 'output-error', errorText: 'boom' },
+      { toolCallId: 't2', toolName: 'verify_build', state: 'output-denied' },
+    ]);
+  });
+});

packages/app-shell/src/layout/ConsoleFloatingChatbot.tsx

@@ -51,7 +51,7 @@ import { getRuntimeConfig } from '../runtime-config';
  * to whatever label the backend provides.
  */
 const PLATFORM_AGENT_LABELS: Record<string, { zh: string; en: string }> = {
-  data_chat: { zh: '数据助手', en: 'Data Assistant' },
+  data_chat: { zh: '智能助手', en: 'Assistant' },
   metadata_assistant: { zh: '元数据开发助手', en: 'Metadata Assistant' },
 };
 

packages/i18n/src/locales/en.ts

@@ -1029,7 +1029,7 @@ const en = {
       hoursAgo: '{{count}}h ago',
       daysAgo: '{{count}}d ago',
       agentLabels: {
-        dataChat: 'Data Assistant',
+        dataChat: 'Assistant',
         metadataAssistant: 'Metadata Assistant',
       },
       suggestions: {

packages/i18n/src/locales/zh.ts

@@ -1029,7 +1029,7 @@ const zh = {
       hoursAgo: '{{count}} 小时前',
       daysAgo: '{{count}} 天前',
       agentLabels: {
-        dataChat: '数据助手',
+        dataChat: '智能助手',
         metadataAssistant: '元数据开发助手',
       },
       suggestions: {