fix(app-shell): localize the two DeclaredActionsBar strings that bypassed i18n (#2762 P0-3) (#2894)

The declared action labels resolve through `useObjectLabel`, so a zh-CN
workspace got 通过 / 拒绝 buttons — sitting inside a toolbar whose accessible
name was the English literal 'Actions', above decision-output fields whose help
text read "Handed to the flow as a decision output." Both strings are authored
by the bar itself rather than by metadata, and both skipped the locale bundle.

`aria-label` now uses the existing `common.actions` key; a host-supplied
`label` still wins. The help text moves to new `actions.decisionOutput.help` /
`.helpMultiValue` keys, added across all ten shipped locales.

The help text needed fixing even though the runtime localizes action params:
`useConsoleActionRuntime` runs every param through `actionParamText`, but these
params are synthesized from the record's `decision_output_defs`, so their key
path (`outputs.<key>`) is dynamic and no `_actions.<action>.params.*` entry can
ever match. The fallback is not a rare path — it is the only path.

Left alone deliberately: a decision output arriving without a `label` still
renders a title-cased version of its machine key, mirroring the framework's
`humanizeFieldPath` convention. The fix there is the backend declaring the
label; a client bundle cannot key off a dynamic output name.

Tests assert the strings go through `t()` rather than merely being English —
they fail against the previous literals.

Framework half: objectstack-ai/objectstack#3753.

Author: os-zhuang

.changeset/declared-actions-bar-chrome-i18n.md

@@ -0,0 +1,32 @@
+---
+"@object-ui/app-shell": patch
+"@object-ui/i18n": patch
+---
+
+fix(app-shell): localize the two `DeclaredActionsBar` strings that bypassed i18n (objectui#2762 P0-3)
+
+The declared action *labels* resolve through `useObjectLabel`, so a zh-CN
+workspace got 通过 / 拒绝 buttons — sitting inside a toolbar whose accessible
+name was the English literal `'Actions'`, above decision-output fields whose
+help text read `Handed to the flow as a decision output.` Both strings are
+authored by the bar itself rather than by metadata, and both skipped the locale
+bundle entirely.
+
+- `aria-label` now uses the existing `common.actions` key (a host-supplied
+  `label` still wins).
+- The decision-output help text moves to new `actions.decisionOutput.help` /
+  `.helpMultiValue` keys, added across all ten shipped locales.
+
+Worth being precise about why the help text needed fixing at all, since the
+runtime *does* localize action params: `useConsoleActionRuntime` runs every
+param through `actionParamText`, but these params are synthesized here from the
+record's `decision_output_defs`, so their key path (`outputs.<key>`) is dynamic
+and no `_actions.<action>.params.*` bundle entry can ever match it. The
+fallback is not a rare path — it is the only path, which is why the English
+survived.
+
+Not fixed, and deliberately: a decision output that arrives without a `label`
+still renders a title-cased version of its machine key. That derived text
+mirrors the framework's `humanizeFieldPath` convention, and the real fix is the
+backend declaring the label — a client-side bundle cannot key off a dynamic
+output name.

packages/app-shell/src/views/DeclaredActionsBar.tsx

@@ -39,7 +39,7 @@ import {
   toPredicateInput,
 } from '@object-ui/react';
 import type { ActionDef } from '@object-ui/core';
-import { useObjectLabel } from '@object-ui/i18n';
+import { useObjectLabel, useObjectTranslation } from '@object-ui/i18n';
 import { Loader2 } from 'lucide-react';
 import { useConsoleActionRuntime } from '../hooks/useConsoleActionRuntime';
 import { useAdapter } from '../providers/AdapterProvider';
@@ -103,6 +103,13 @@ const DeclaredActionButton: React.FC<{
   // ObjectView/RecordDetailView do for their toolbars. The param dialog's
   // labels localize downstream in useConsoleActionRuntime.
   const { actionLabel, actionConfirm, actionSuccess } = useObjectLabel();
+  // Chrome strings the bar itself authors — as opposed to the declared metadata
+  // above — go through the normal locale bundle. The decision-output params are
+  // synthesized here from `decision_output_defs`, so their key path is dynamic
+  // and no `_actions.<action>.params.*` entry can ever exist for them; the
+  // literal IS what renders, which is how English help text survived in a zh-CN
+  // workspace (objectui#2762 P0-3).
+  const { t } = useObjectTranslation();
 
   const recordData = record != null && typeof record === 'object' ? (record as Record<string, any>) : {};
   // `visible` fails CLOSED on a throwing predicate — mirrors action:button and
@@ -160,19 +167,19 @@ const DeclaredActionButton: React.FC<{
         if (d.type === 'user') {
           return {
             ...base, type: 'user', multiple: d.multiple === true,
-            helpText: 'Handed to the flow as a decision output.',
+            helpText: t('actions.decisionOutput.help'),
           };
         }
         const lookupObject = d.type ? OUTPUT_LOOKUP_OBJECTS[d.type] : undefined;
         if (lookupObject) {
           return {
             ...base, type: 'lookup', referenceTo: lookupObject, multiple: d.multiple === true,
-            helpText: 'Handed to the flow as a decision output.',
+            helpText: t('actions.decisionOutput.help'),
           };
         }
         return {
           ...base, type: 'text',
-          helpText: 'Handed to the flow as a decision output. Comma-separate multiple values.',
+          helpText: t('actions.decisionOutput.helpMultiValue'),
         };
       });
       const dispatch: any = {
@@ -201,7 +208,7 @@ const DeclaredActionButton: React.FC<{
     } finally {
       setLoading(false);
     }
-  }, [action, execute, loading, objectName, record, actionLabel, actionConfirm, actionSuccess]);
+  }, [action, execute, loading, objectName, record, actionLabel, actionConfirm, actionSuccess, t]);
 
   if ((action as any).visible && !isVisible) return null;
 
@@ -252,6 +259,7 @@ export function DeclaredActionsBar({
   label,
 }: DeclaredActionsBarProps) {
   const dataSource = useAdapter();
+  const { t } = useObjectTranslation();
   // Fetch the object def (and its declared actions) unless the host passed
   // them in. `useMetadataItem` no-ops when `name` is undefined.
   const { item: objectDef } = useMetadataItem('object', actionsProp ? undefined : objectName);
@@ -299,7 +307,7 @@ export function DeclaredActionsBar({
             <div className="text-xs font-medium text-muted-foreground">{label}</div>
           </>
         )}
-        <div role="toolbar" aria-label={label || 'Actions'} className="flex flex-row flex-wrap items-center gap-2">
+        <div role="toolbar" aria-label={label || t('common.actions')} className="flex flex-row flex-wrap items-center gap-2">
           {located.map((action) => (
             <DeclaredActionButton
               key={action.name}

packages/app-shell/src/views/__tests__/DeclaredActionsBar.test.tsx

@@ -41,6 +41,19 @@ vi.mock('../../providers/MetadataProvider', () => ({
 
 vi.mock('../../utils/getIcon', () => ({ getIcon: () => () => null }));
 
+// Declared metadata resolves through `useObjectLabel` (falling back to the
+// authored literal, which is what the render assertions below expect); the
+// bar's OWN chrome resolves through `t`. Marking `t` output makes it visible
+// whether a string went through the locale bundle or was baked in English.
+vi.mock('@object-ui/i18n', () => ({
+  useObjectLabel: () => ({
+    actionLabel: (_o: unknown, _n: unknown, fallback: string) => fallback,
+    actionConfirm: (_o: unknown, _n: unknown, fallback?: string) => fallback,
+    actionSuccess: (_o: unknown, _n: unknown, fallback?: string) => fallback,
+  }),
+  useObjectTranslation: () => ({ t: (key: string) => `t:${key}` }),
+}));
+
 vi.mock('@object-ui/components', () => ({
   Button: ({ children, onClick, ...props }: any) => (
     <button onClick={onClick} {...props}>{children}</button>
@@ -219,3 +232,75 @@ describe('DeclaredActionsBar', () => {
     expect(empty.firstChild).toBeNull();
   });
 });
+
+// objectui#2762 P0-3. The declared action LABELS localize via `useObjectLabel`,
+// but two strings the bar authors itself were baked in English and bypassed
+// i18n entirely — so a zh-CN workspace got 通过 / 拒绝 buttons sitting inside an
+// "Actions" toolbar, with English help text under the decision-output fields.
+//
+// The help text is the subtler one: those params are synthesized here from the
+// record's `decision_output_defs`, so their key path (`outputs.<key>`) is
+// dynamic and no `_actions.<action>.params.*` bundle entry can ever match it.
+// The runtime's `actionParamText` pass therefore always falls through to the
+// literal — the literal IS what renders, every time.
+describe('DeclaredActionsBar chrome localization (objectui#2762)', () => {
+  it('localizes the toolbar aria-label instead of hardcoding "Actions"', () => {
+    render(
+      <DeclaredActionsBar
+        objectName="sys_approval_request"
+        record={REQUEST}
+        location="record_section"
+        actions={ACTIONS as any}
+      />,
+    );
+    expect(screen.getByRole('toolbar')).toHaveAttribute('aria-label', 't:common.actions');
+  });
+
+  it('still prefers a host-supplied label over the translated default', () => {
+    render(
+      <DeclaredActionsBar
+        objectName="sys_approval_request"
+        record={REQUEST}
+        location="record_section"
+        label="决策"
+        actions={ACTIONS as any}
+      />,
+    );
+    expect(screen.getByRole('toolbar')).toHaveAttribute('aria-label', '决策');
+  });
+
+  it('localizes the decision-output help text', async () => {
+    const decideAction = {
+      name: 'approval_approve',
+      type: 'api',
+      label: 'Approve',
+      target: '/api/v1/approvals/requests/{id}/approve',
+      locations: ['record_section'],
+    };
+    render(
+      <DeclaredActionsBar
+        objectName="sys_approval_request"
+        record={{
+          ...REQUEST,
+          decision_output_defs: [
+            { key: 'reviewer', type: 'user' },
+            { key: 'owning_team', type: 'team' },
+            { key: 'notes' },
+          ],
+        }}
+        location="record_section"
+        actions={[decideAction] as any}
+      />,
+    );
+
+    fireEvent.click(screen.getByText('Approve'));
+    await waitFor(() => expect(executeSpy).toHaveBeenCalled());
+
+    const params = executeSpy.mock.calls[0][0].actionParams as Array<Record<string, unknown>>;
+    const byName = Object.fromEntries(params.map((p) => [p.name, p]));
+    expect(byName['outputs.reviewer'].helpText).toBe('t:actions.decisionOutput.help');
+    expect(byName['outputs.owning_team'].helpText).toBe('t:actions.decisionOutput.help');
+    // The free-text variant carries the extra comma-separation sentence.
+    expect(byName['outputs.notes'].helpText).toBe('t:actions.decisionOutput.helpMultiValue');
+  });
+});

packages/i18n/src/locales/ar.ts

@@ -74,6 +74,10 @@ const ar = {
     package: "الحزمة",
   },
   actions: {
+    decisionOutput: {
+      help: 'يُمرَّر إلى التدفق كمخرج للقرار.',
+      helpMultiValue: 'يُمرَّر إلى التدفق كمخرج للقرار. افصل بين القيم المتعددة بفواصل.',
+    },
     resultDialog: {
       defaultTitle: 'احفظ هذه القيمة الآن',
       acknowledge: 'لقد حفظتها',

packages/i18n/src/locales/de.ts

@@ -74,6 +74,10 @@ const de = {
     package: "Paket",
   },
   actions: {
+    decisionOutput: {
+      help: 'Wird dem Flow als Entscheidungsausgabe übergeben.',
+      helpMultiValue: 'Wird dem Flow als Entscheidungsausgabe übergeben. Mehrere Werte durch Komma trennen.',
+    },
     resultDialog: {
       defaultTitle: 'Diesen Wert jetzt speichern',
       acknowledge: 'Ich habe ihn gespeichert',

packages/i18n/src/locales/en.ts

@@ -89,6 +89,10 @@ const en = {
     package: 'Package',
   },
   actions: {
+    decisionOutput: {
+      help: 'Handed to the flow as a decision output.',
+      helpMultiValue: 'Handed to the flow as a decision output. Comma-separate multiple values.',
+    },
     resultDialog: {
       defaultTitle: 'Save this value now',
       acknowledge: 'I have saved this',

packages/i18n/src/locales/es.ts

@@ -74,6 +74,10 @@ const es = {
     package: "Paquete",
   },
   actions: {
+    decisionOutput: {
+      help: 'Se transfiere al flujo como salida de la decisión.',
+      helpMultiValue: 'Se transfiere al flujo como salida de la decisión. Separe varios valores con comas.',
+    },
     resultDialog: {
       defaultTitle: 'Guarda este valor ahora',
       acknowledge: 'Lo he guardado',

packages/i18n/src/locales/fr.ts

@@ -74,6 +74,10 @@ const fr = {
     package: "Package",
   },
   actions: {
+    decisionOutput: {
+      help: 'Transmis au flux comme sortie de décision.',
+      helpMultiValue: 'Transmis au flux comme sortie de décision. Séparez les valeurs multiples par des virgules.',
+    },
     resultDialog: {
       defaultTitle: 'Enregistrez cette valeur maintenant',
       acknowledge: 'Je l\'ai enregistrée',

packages/i18n/src/locales/ja.ts

@@ -74,6 +74,10 @@ const ja = {
     package: "パッケージ",
   },
   actions: {
+    decisionOutput: {
+      help: '決定の出力としてフローに渡されます。',
+      helpMultiValue: '決定の出力としてフローに渡されます。複数の値はカンマで区切ってください。',
+    },
     resultDialog: {
       defaultTitle: 'この値を今すぐ保存してください',
       acknowledge: '保存しました',

packages/i18n/src/locales/ko.ts

@@ -74,6 +74,10 @@ const ko = {
     package: "패키지",
   },
   actions: {
+    decisionOutput: {
+      help: '결정 출력으로 플로우에 전달됩니다.',
+      helpMultiValue: '결정 출력으로 플로우에 전달됩니다. 여러 값은 쉼표로 구분하세요.',
+    },
     resultDialog: {
       defaultTitle: '이 값을 지금 저장하세요',
       acknowledge: '저장했습니다',