fix: address PR review comments — license header, tests, deprecated re-export, ROADMAP

- Add standard ObjectUI MIT license header to merge-views-into-objects.ts
- Add 6 unit tests for mergeViewsIntoObjects helper
- Add deprecated composeStacks re-export from @objectstack/spec in core index
- Reword ROADMAP to clarify removed test suite lives upstream in @objectstack/spec

Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>

Author: Copilot

ROADMAP.md

@@ -1188,11 +1188,10 @@ Plugin architecture refactoring to support true modular development, plugin isol
 - [x] Remove duplicate `mergeActionsIntoObjects()` from root config and console shared config
 - [x] Remove duplicate `mergeViewsIntoObjects()` from root config and console shared config (moved into `composeStacks`)
 - [x] Refactor root `objectstack.config.ts` and `apps/console/objectstack.shared.ts` to use `composeStacks()`
-- [x] Unit tests for `composeStacks()` (15 tests covering merging, dedup, views, actions, cross-stack, conflict detection)
 - [x] Eliminate `defineStack()` double-pass hack — single `composeStacks()` call produces final config with runtime properties (listViews, actions) preserved. `defineStack()` Zod validation stripped these fields, requiring a second `composeStacks` pass to restore them.
 - [x] Use `composed.apps` unified flow in console shared config — replaced manual `[...crmApps, ...(todoConfig.apps || []), ...]` spreading with CRM navigation patch applied to composed output
 - [x] Use `composed.reports` in console shared config — replaced `...(crmConfig.reports || [])` with `...(composed.reports || [])` to include reports from all stacks
-- [x] **composeStacks unified to `@objectstack/spec`:** Removed `@object-ui/core` composeStacks implementation. All config composition now uses `composeStacks` from `@objectstack/spec` (protocol-level: object dedup, array concatenation, actions→objects mapping, manifest selection, i18n). Runtime-specific `mergeViewsIntoObjects` adapter applied inline at call sites until the runtime/provider layer handles it natively.
+- [x] **composeStacks unified to `@objectstack/spec`:** Removed `@object-ui/core` composeStacks implementation and its 15-test suite (coverage now lives upstream in `@objectstack/spec`). All config composition now uses `composeStacks` from `@objectstack/spec` (protocol-level: object dedup, array concatenation, actions→objects mapping, manifest selection, i18n). Runtime-specific `mergeViewsIntoObjects` adapter extracted to `@object-ui/core` and applied post-composition at call sites. A deprecated re-export of `composeStacks` is kept in `@object-ui/core` for backward compatibility.
 
 **Phase 2 — Dynamic Plugin Loading (Planned)**
 - [ ] Hot-reload / lazy loading of plugins for development

packages/core/src/index.ts

@@ -28,3 +28,11 @@ export * from './utils/debug.js';
 export * from './utils/debug-collector.js';
 export * from './utils/merge-views-into-objects.js';
 export * from './protocols/index.js';
+
+/**
+ * @deprecated Import `composeStacks` from `@objectstack/spec` instead.
+ *
+ * This re-export is kept only for backward compatibility and will be removed
+ * in the next major version of `@object-ui/core`.
+ */
+export { composeStacks } from '@objectstack/spec';

packages/core/src/utils/__tests__/merge-views-into-objects.test.ts

@@ -0,0 +1,110 @@
+/**
+ * ObjectUI
+ * Copyright (c) 2024-present ObjectStack Inc.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+import { describe, it, expect } from 'vitest';
+import { mergeViewsIntoObjects } from '../merge-views-into-objects';
+
+describe('mergeViewsIntoObjects', () => {
+  it('should merge listViews from views into corresponding objects', () => {
+    const objects = [{ name: 'account', label: 'Account', fields: {} }];
+    const views = [
+      {
+        listViews: {
+          all_accounts: {
+            name: 'all_accounts',
+            label: 'All Accounts',
+            type: 'grid',
+            data: { provider: 'object', object: 'account' },
+          },
+        },
+      },
+    ];
+
+    const result = mergeViewsIntoObjects(objects, views);
+    expect(result[0].listViews.all_accounts).toBeDefined();
+    expect(result[0].listViews.all_accounts.label).toBe('All Accounts');
+  });
+
+  it('should preserve existing listViews on objects', () => {
+    const objects = [
+      {
+        name: 'todo_task',
+        label: 'Task',
+        fields: {},
+        listViews: {
+          existing: { name: 'existing', label: 'Existing View', type: 'grid', data: { provider: 'object', object: 'todo_task' } },
+        },
+      },
+    ];
+    const views = [
+      {
+        listViews: {
+          new_view: {
+            name: 'new_view',
+            label: 'New View',
+            type: 'grid',
+            data: { provider: 'object', object: 'todo_task' },
+          },
+        },
+      },
+    ];
+
+    const result = mergeViewsIntoObjects(objects, views);
+    const task = result[0];
+    expect(task.listViews.existing).toBeDefined();
+    expect(task.listViews.new_view).toBeDefined();
+  });
+
+  it('should ignore listViews without data.object', () => {
+    const objects = [{ name: 'account', label: 'Account', fields: {} }];
+    const views = [
+      {
+        listViews: {
+          orphan: { name: 'orphan', label: 'Orphan View', type: 'grid' },
+        },
+      },
+    ];
+
+    const result = mergeViewsIntoObjects(objects, views);
+    expect(result[0].listViews).toBeUndefined();
+  });
+
+  it('should return objects unchanged when views is empty', () => {
+    const objects = [{ name: 'account', label: 'Account', fields: {} }];
+
+    const result = mergeViewsIntoObjects(objects, []);
+    expect(result).toEqual(objects);
+  });
+
+  it('should ignore views without listViews property', () => {
+    const objects = [{ name: 'account', label: 'Account', fields: {} }];
+    const views = [{ someOtherProp: true }];
+
+    const result = mergeViewsIntoObjects(objects, views);
+    expect(result).toEqual(objects);
+  });
+
+  it('should merge views from multiple view entries into different objects', () => {
+    const objects = [
+      { name: 'account', label: 'Account', fields: {} },
+      { name: 'contact', label: 'Contact', fields: {} },
+    ];
+    const views = [
+      {
+        listViews: {
+          all_accounts: { name: 'all_accounts', label: 'All Accounts', type: 'grid', data: { provider: 'object', object: 'account' } },
+          all_contacts: { name: 'all_contacts', label: 'All Contacts', type: 'grid', data: { provider: 'object', object: 'contact' } },
+        },
+      },
+    ];
+
+    const result = mergeViewsIntoObjects(objects, views);
+    expect(result[0].listViews.all_accounts).toBeDefined();
+    expect(result[1].listViews.all_contacts).toBeDefined();
+  });
+});

packages/core/src/utils/merge-views-into-objects.ts

@@ -1,3 +1,11 @@
+/**
+ * ObjectUI
+ * Copyright (c) 2024-present ObjectStack Inc.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
 /**
  * Adapter: merge stack-level views into object definitions.
  *