Skip to content

Commit ca3495a

Browse files
Copilothuangyiirene
andcommitted
Address code review feedback: update release workflow and improve button test
Co-authored-by: huangyiirene <7665279+huangyiirene@users.noreply.github.com>
1 parent 93ca7d8 commit ca3495a

2 files changed

Lines changed: 6 additions & 4 deletions

File tree

.github/workflows/release.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,12 +45,12 @@ jobs:
4545
run: echo "VERSION=${GITHUB_REF#refs/tags/v}" >> $GITHUB_OUTPUT
4646

4747
- name: Create GitHub Release
48-
uses: actions/create-release@v1
48+
uses: softprops/action-gh-release@v1
4949
env:
5050
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
5151
with:
5252
tag_name: ${{ github.ref }}
53-
release_name: Release ${{ steps.get_version.outputs.VERSION }}
53+
name: Release ${{ steps.get_version.outputs.VERSION }}
5454
body: |
5555
Release version ${{ steps.get_version.outputs.VERSION }}
5656

packages/ui/src/__tests__/button.test.tsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import { describe, it, expect, vi } from 'vitest';
22
import React from 'react';
33
import { render, screen } from '@testing-library/react';
4+
import userEvent from '@testing-library/user-event';
45
import { Button } from '../components/ui/button';
56

67
describe('@object-ui/ui - Button', () => {
@@ -62,10 +63,11 @@ describe('@object-ui/ui - Button', () => {
6263
expect(screen.getByText('Disabled')).toBeDisabled();
6364
});
6465

65-
it('should handle onClick events', () => {
66+
it('should handle onClick events', async () => {
6667
const handleClick = vi.fn();
68+
const user = userEvent.setup();
6769
render(<Button onClick={handleClick}>Click me</Button>);
68-
screen.getByText('Click me').click();
70+
await user.click(screen.getByText('Click me'));
6971
expect(handleClick).toHaveBeenCalledOnce();
7072
});
7173
});

0 commit comments

Comments
 (0)