refactor: address code review feedback

- Add documentation for discovery property access in ObjectStackAdapter
- Import and use DiscoveryInfo type in ConditionalAuthWrapper for type safety
- Add comment explaining empty baseUrl in ConditionalAuthWrapper

Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>

Author: Copilot

apps/console/src/components/ConditionalAuthWrapper.tsx

@@ -9,6 +9,7 @@ import { useState, useEffect, ReactNode } from 'react';
 import { ObjectStackAdapter } from './dataSource';
 import { AuthProvider } from '@object-ui/auth';
 import { LoadingScreen } from './components/LoadingScreen';
+import type { DiscoveryInfo } from '@object-ui/react';
 
 interface ConditionalAuthWrapperProps {
   children: ReactNode;
@@ -35,18 +36,20 @@ export function ConditionalAuthWrapper({ children, authUrl }: ConditionalAuthWra
     async function checkAuthStatus() {
       try {
         // Create a temporary adapter to fetch discovery
+        // Empty baseUrl allows the adapter to use browser-relative paths
+        // This works because the console app is served from the same origin as the API
         const adapter = new ObjectStackAdapter({
           baseUrl: '',
           autoReconnect: false,
         });
 
         await adapter.connect();
-        const discovery = await adapter.getDiscovery();
+        const discovery = await adapter.getDiscovery() as DiscoveryInfo | null;
 
         if (!cancelled) {
           // Check if auth is enabled in discovery
           // Default to true if discovery doesn't provide this information
-          const isAuthEnabled = (discovery as any)?.services?.auth?.enabled ?? true;
+          const isAuthEnabled = discovery?.services?.auth?.enabled ?? true;
           setAuthEnabled(isAuthEnabled);
         }
       } catch (error) {

packages/data-objectstack/src/index.ts

@@ -588,6 +588,9 @@ export class ObjectStackAdapter<T = unknown> implements DataSource<T> {
    * Get the discovery information from the connected server.
    * Returns the capabilities and service status of the ObjectStack server.
    * 
+   * Note: This accesses an internal property of the ObjectStackClient.
+   * The discovery data is populated during client.connect() and cached.
+   * 
    * @returns Promise resolving to discovery data, or null if not connected
    */
   async getDiscovery(): Promise<unknown | null> {
@@ -596,7 +599,9 @@ export class ObjectStackAdapter<T = unknown> implements DataSource<T> {
       await this.connect();
 
       // Access discovery data from the client
-      // @ts-expect-error - Accessing internal property
+      // The ObjectStackClient caches discovery during connect()
+      // This is an internal property, but documented for this use case
+      // @ts-expect-error - Accessing internal discovery property
       return this.client.discovery || null;
     } catch {
       return null;