Skip to content

Commit d16f2bd

Browse files
Merge pull request #1202 from objectstack-ai/claude/fix-ci-build-and-test-errors
Fix CI build and test errors
2 parents 299c30e + 7a384be commit d16f2bd

File tree

2 files changed

+17
-18
lines changed

2 files changed

+17
-18
lines changed

apps/console/src/__tests__/MetadataDetailPage.test.tsx

Lines changed: 16 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -70,23 +70,22 @@ vi.mock('react-router-dom', async () => {
7070
});
7171

7272
// Register mock widget components for PageSchema rendering in tests
73-
beforeEach(() => {
74-
const mockWidget = (name: string) => (props: any) => (
75-
<div data-testid={`mock-${name}`} data-object-name={props?.schema?.objectName || props?.objectName}>
76-
{name}
77-
</div>
78-
);
79-
80-
ComponentRegistry.register('object-detail-tabs', mockWidget('object-detail-tabs'));
81-
ComponentRegistry.register('object-properties', mockWidget('object-properties'));
82-
ComponentRegistry.register('object-relationships', mockWidget('object-relationships'));
83-
ComponentRegistry.register('object-keys', mockWidget('object-keys'));
84-
ComponentRegistry.register('object-data-experience', mockWidget('object-data-experience'));
85-
ComponentRegistry.register('object-data-preview', mockWidget('object-data-preview'));
86-
ComponentRegistry.register('object-field-designer', mockWidget('object-field-designer'));
87-
});
88-
89-
// Import after mocks
73+
// IMPORTANT: Register at module level (before import) to ensure components are available
74+
const mockWidget = (name: string) => (props: any) => (
75+
<div data-testid={`mock-${name}`} data-object-name={props?.schema?.objectName || props?.objectName}>
76+
{name}
77+
</div>
78+
);
79+
80+
ComponentRegistry.register('object-detail-tabs', mockWidget('object-detail-tabs'));
81+
ComponentRegistry.register('object-properties', mockWidget('object-properties'));
82+
ComponentRegistry.register('object-relationships', mockWidget('object-relationships'));
83+
ComponentRegistry.register('object-keys', mockWidget('object-keys'));
84+
ComponentRegistry.register('object-data-experience', mockWidget('object-data-experience'));
85+
ComponentRegistry.register('object-data-preview', mockWidget('object-data-preview'));
86+
ComponentRegistry.register('object-field-designer', mockWidget('object-field-designer'));
87+
88+
// Import after registering mock components
9089
import { MetadataDetailPage } from '../pages/system/MetadataDetailPage';
9190

9291
function renderWithRoute(metadataType: string, itemName: string) {

apps/console/src/components/schema/objectDetailWidgets.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ export function ObjectRelationshipsWidget({ schema }: { schema: ObjectWidgetSche
161161
</h3>
162162
{hasRelationships ? (
163163
<div className="space-y-3">
164-
{(object.relationships ?? []).map((rel, i) => (
164+
{object.relationships?.map((rel, i) => (
165165
<div
166166
key={i}
167167
className="flex items-start gap-4 p-4 rounded-lg border bg-card hover:bg-accent/50 transition-colors"

0 commit comments

Comments
 (0)