fix: address code review feedback — type safety, deps, unused import

Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>

Author: Copilot

apps/console/src/App.tsx

@@ -150,7 +150,7 @@ export function AppContent() {
         type: 'report',
       });
     }
-  }, [location.pathname]); // eslint-disable-line react-hooks/exhaustive-deps
+  }, [location.pathname, activeApp, allObjects, objectNameFromPath, cleanParts, addRecentItem]);
 
   const handleEdit = (record: any) => {
     setEditingRecord(record);

apps/console/src/__tests__/SkeletonComponents.test.tsx

@@ -2,7 +2,7 @@
  * Tests for skeleton loading components
  */
 import { describe, it, expect } from 'vitest';
-import { render, screen } from '@testing-library/react';
+import { render } from '@testing-library/react';
 import '@testing-library/jest-dom';
 import { SkeletonGrid } from '../components/skeletons/SkeletonGrid';
 import { SkeletonDashboard } from '../components/skeletons/SkeletonDashboard';

apps/console/src/components/DashboardView.tsx

@@ -18,9 +18,10 @@ export function DashboardView({ dataSource }: { dataSource?: any }) {
   const [isLoading, setIsLoading] = useState(true);
 
   useEffect(() => {
-    // Simulate initial data load; real implementation would await dataSource readiness
-    const timer = setTimeout(() => setIsLoading(false), 0);
-    return () => clearTimeout(timer);
+    // Reset loading on navigation; the actual DashboardRenderer handles data fetching
+    setIsLoading(true);
+    // Use microtask to let React render the skeleton before the heavy dashboard
+    queueMicrotask(() => setIsLoading(false));
   }, [dashboardName]);
 
   // Find dashboard definition in config

apps/console/src/components/RecordDetailView.tsx

@@ -27,9 +27,9 @@ export function RecordDetailView({ dataSource, objects, onEdit }: RecordDetailVi
   const objectDef = objects.find((o: any) => o.name === objectName);
 
   useEffect(() => {
+    // Reset loading on navigation; the actual DetailView handles data fetching
     setIsLoading(true);
-    const timer = setTimeout(() => setIsLoading(false), 0);
-    return () => clearTimeout(timer);
+    queueMicrotask(() => setIsLoading(false));
   }, [objectName, recordId]);
 
   if (isLoading) {

packages/data-objectstack/src/index.ts

@@ -96,6 +96,8 @@ export class ObjectStackAdapter<T = unknown> implements DataSource<T> {
   private maxReconnectAttempts: number;
   private reconnectDelay: number;
   private reconnectAttempts: number = 0;
+  private baseUrl: string;
+  private token?: string;
 
   constructor(config: {
     baseUrl: string;
@@ -114,6 +116,8 @@ export class ObjectStackAdapter<T = unknown> implements DataSource<T> {
     this.autoReconnect = config.autoReconnect ?? true;
     this.maxReconnectAttempts = config.maxReconnectAttempts ?? 3;
     this.reconnectDelay = config.reconnectDelay ?? 1000;
+    this.baseUrl = config.baseUrl;
+    this.token = config.token;
   }
 
   /**
@@ -720,8 +724,7 @@ export class ObjectStackAdapter<T = unknown> implements DataSource<T> {
       formData.append('metadata', JSON.stringify(options.metadata));
     }
 
-    const baseUrl = (this.client as any).baseUrl || '';
-    const url = `${baseUrl}/api/data/${encodeURIComponent(resource)}/upload`;
+    const url = `${this.baseUrl}/api/data/${encodeURIComponent(resource)}/upload`;
 
     const response = await fetch(url, {
       method: 'POST',
@@ -779,8 +782,7 @@ export class ObjectStackAdapter<T = unknown> implements DataSource<T> {
       formData.append('metadata', JSON.stringify(options.metadata));
     }
 
-    const baseUrl = (this.client as any).baseUrl || '';
-    const url = `${baseUrl}/api/data/${encodeURIComponent(resource)}/upload`;
+    const url = `${this.baseUrl}/api/data/${encodeURIComponent(resource)}/upload`;
 
     const response = await fetch(url, {
       method: 'POST',
@@ -803,14 +805,12 @@ export class ObjectStackAdapter<T = unknown> implements DataSource<T> {
   }
 
   /**
-   * Get authorization headers from the underlying client (if any).
+   * Get authorization headers from the adapter config.
    */
   private getAuthHeaders(): Record<string, string> {
     const headers: Record<string, string> = {};
-    // Access token from client config if available
-    const token = (this.client as any).token || (this.client as any).config?.token;
-    if (token) {
-      headers['Authorization'] = `Bearer ${token}`;
+    if (this.token) {
+      headers['Authorization'] = `Bearer ${this.token}`;
     }
     return headers;
   }