fix(plugin-aggrid): Address all PR review feedback

- Fix handleExportCSV to guard on gridRef.current?.api (issue #1)
- Add dedicated onContextMenuAction callback instead of overloading onCellClicked (issue #2)
- Remove icon property from customItems to prevent HTML injection (issue #3)
- Remove validation claim from README - only basic AG Grid editing (issue #4)
- Add test assertions for all new inputs (editable, exportConfig, etc.) (issue #5)
- Fix onExport type to only support 'csv' format (issue #6)
- Remove unused ColumnConfig properties (autoSize, groupable) (issue #9)
- Type schema props with proper interfaces instead of 'any' (issue #10)
- Update export description to only mention CSV (issue #11)
- Add AG Grid Community vs Enterprise section to docs (issue #8)
- Update README and docs with new callback and clarifications

All tests pass (8/8), lint clean (0 errors)

Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>

Author: Copilot

content/docs/plugins/plugin-aggrid.mdx

@@ -365,10 +365,14 @@ Note: `ag-grid-community` and `ag-grid-react` are peer dependencies and must be
     },
     height: 450
   }}
-  title="Enterprise Features"
-  description="Full-featured grid with editing, export, status bar, context menu, and more"
+  title="Advanced Features"
+  description="Full-featured grid with editing, export, status bar, context menu, and more (AG Grid Community)"
 />
 
+## AG Grid Community vs Enterprise
+
+This plugin uses **AG Grid Community Edition** which is free and open source. All features shown in the examples above work with the Community edition. Some advanced features like integrated charting (`enableCharts`) may require AG Grid Enterprise (commercial license). See [AG Grid Pricing](https://www.ag-grid.com/license-pricing/) for details.
+
 ## Features
 
 - **Lazy Loading**: AG Grid libraries are loaded on-demand for optimal performance

packages/plugin-aggrid/README.md

@@ -9,7 +9,7 @@ A lazy-loaded data grid component for Object UI based on AG Grid Community Editi
 - **Automatic Registration**: Components auto-register with the ComponentRegistry
 - **Skeleton Loading**: Shows a skeleton while AG Grid loads
 - **Full AG Grid Features**: Sorting, filtering, pagination, cell rendering, and more
-- **Cell & Row Editing**: Inline editing with validation support
+- **Cell & Row Editing**: Inline editing using AG Grid's built-in editors
 - **CSV Export**: Built-in data export functionality
 - **Event Callbacks**: Handle cell clicks, selection changes, and value updates
 - **Status Bar**: Display aggregations (count, sum, avg, min, max)
@@ -19,6 +19,10 @@ A lazy-loaded data grid component for Object UI based on AG Grid Community Editi
 - **Multiple Themes**: Support for Quartz, Alpine, Balham, and Material themes
 - **Customizable**: Full access to AG Grid's GridOptions for advanced configuration
 
+## AG Grid Community vs Enterprise
+
+This plugin uses **AG Grid Community Edition** which is free and open source. Most features (sorting, filtering, editing, CSV export, basic context menu) work with the Community edition. Some advanced features like integrated charting may require AG Grid Enterprise (commercial license). See [AG Grid Pricing](https://www.ag-grid.com/license-pricing/) for details.
+
 ## Installation
 
 ```bash
@@ -160,7 +164,8 @@ const schema: AgGridSchema = {
     onRowClicked?: (event) => void,             // Row click handler
     onSelectionChanged?: (event) => void,       // Selection change handler
     onCellValueChanged?: (event) => void,       // Cell value change handler
-    onExport?: (data, format) => void           // Export handler
+    onExport?: (data, format) => void,          // Export handler (CSV only)
+    onContextMenuAction?: (action, rowData) => void  // Context menu action handler
   },
 
   // Column Configuration
@@ -363,15 +368,24 @@ const schema = {
       {
         name: 'Delete Row',
         action: 'delete',
-        icon: '🗑️',
         disabled: false
       },
       {
         name: 'View Details',
-        action: 'view',
-        icon: '👁️'
+        action: 'view'
       }
     ]
+  },
+  callbacks: {
+    onContextMenuAction: (action, rowData) => {
+      console.log(`Action: ${action}`, rowData);
+      // Handle custom menu actions
+      if (action === 'delete') {
+        deleteRow(rowData);
+      } else if (action === 'view') {
+        viewDetails(rowData);
+      }
+    }
   }
 };
 ```

packages/plugin-aggrid/src/AgGridImpl.tsx

@@ -94,7 +94,7 @@ export default function AgGridImpl({
 
   // CSV Export handler
   const handleExportCSV = useCallback(() => {
-    if (!gridRef.current) return;
+    if (!gridRef.current?.api) return;
 
     const params = {
       fileName: exportConfig?.fileName || 'export.csv',
@@ -158,17 +158,11 @@ export default function AgGridImpl({
       contextMenu.customItems.forEach(customItem => {
         items.push({
           name: customItem.name,
-          icon: customItem.icon,
           disabled: customItem.disabled,
           action: () => {
-            // Trigger callback if defined
-            if (callbacks?.onCellClicked) {
-              // Invoke with the menu item action and row data
-              const syntheticEvent = {
-                ...params,
-                customAction: customItem.action,
-              } as any;
-              callbacks.onCellClicked(syntheticEvent);
+            // Trigger dedicated context menu action callback
+            if (callbacks?.onContextMenuAction) {
+              callbacks.onContextMenuAction(customItem.action, params.node?.data);
             }
           },
         });

packages/plugin-aggrid/src/index.test.ts

@@ -35,6 +35,7 @@ describe('Plugin AgGrid', () => {
       const config = ComponentRegistry.getConfig('aggrid');
       const inputNames = config?.inputs?.map((input: any) => input.name) || [];
 
+      // Original inputs
       expect(inputNames).toContain('rowData');
       expect(inputNames).toContain('columnDefs');
       expect(inputNames).toContain('pagination');
@@ -46,6 +47,17 @@ describe('Plugin AgGrid', () => {
       expect(inputNames).toContain('animateRows');
       expect(inputNames).toContain('gridOptions');
       expect(inputNames).toContain('className');
+      
+      // New inputs for enterprise features
+      expect(inputNames).toContain('editable');
+      expect(inputNames).toContain('singleClickEdit');
+      expect(inputNames).toContain('exportConfig');
+      expect(inputNames).toContain('statusBar');
+      expect(inputNames).toContain('callbacks');
+      expect(inputNames).toContain('columnConfig');
+      expect(inputNames).toContain('enableRangeSelection');
+      expect(inputNames).toContain('enableCharts');
+      expect(inputNames).toContain('contextMenu');
     });
 
     it('should have rowData and columnDefs as required inputs', () => {

packages/plugin-aggrid/src/index.tsx

@@ -21,6 +21,8 @@ import 'ag-grid-community/styles/ag-theme-material.css';
 // Export types for external use
 export type { AgGridSchema, SimpleColumnDef, AgGridCallbacks, ExportConfig, StatusBarConfig, ColumnConfig, ContextMenuConfig } from './types';
 
+import type { AgGridCallbacks, ExportConfig, StatusBarConfig, ColumnConfig, ContextMenuConfig } from './types';
+
 // 🚀 Lazy load the implementation file
 // This ensures AG Grid is only loaded when the component is actually rendered
 const LazyAgGrid = React.lazy(() => import('./AgGridImpl'));
@@ -44,13 +46,13 @@ export interface AgGridRendererProps {
     editType?: 'fullRow';
     singleClickEdit?: boolean;
     stopEditingWhenCellsLoseFocus?: boolean;
-    exportConfig?: any;
-    statusBar?: any;
-    callbacks?: any;
-    columnConfig?: any;
+    exportConfig?: ExportConfig;
+    statusBar?: StatusBarConfig;
+    callbacks?: AgGridCallbacks;
+    columnConfig?: ColumnConfig;
     enableRangeSelection?: boolean;
     enableCharts?: boolean;
-    contextMenu?: any;
+    contextMenu?: ContextMenuConfig;
   };
 }
 
@@ -194,7 +196,7 @@ ComponentRegistry.register(
         name: 'exportConfig', 
         type: 'code', 
         label: 'Export Config (JSON)',
-        description: 'Configure CSV/Excel export: { enabled: true, fileName: "data.csv" }',
+        description: 'Configure CSV export: { enabled: true, fileName: "data.csv" }',
         advanced: true
       },
       { 

packages/plugin-aggrid/src/types.ts

@@ -16,7 +16,8 @@ export interface AgGridCallbacks {
   onRowClicked?: (event: RowClickedEvent) => void;
   onSelectionChanged?: (event: SelectionChangedEvent) => void;
   onCellValueChanged?: (event: CellValueChangedEvent) => void;
-  onExport?: (data: any[], format: 'csv' | 'excel') => void;
+  onExport?: (data: any[], format: 'csv') => void;
+  onContextMenuAction?: (action: string, rowData: any) => void;
 }
 
 /**
@@ -42,11 +43,9 @@ export interface StatusBarConfig {
  * Column configuration enhancements
  */
 export interface ColumnConfig {
-  autoSize?: boolean;
   resizable?: boolean;
   sortable?: boolean;
   filterable?: boolean;
-  groupable?: boolean;
 }
 
 /**
@@ -58,7 +57,6 @@ export interface ContextMenuConfig {
   customItems?: Array<{
     name: string;
     action: string;
-    icon?: string;
     disabled?: boolean;
   }>;
 }