Merge pull request #789 from objectstack-ai/copilot/fix-build-errors-in-crm

Author: hotlong

examples/crm/src/__tests__/crm-metadata.test.ts

@@ -100,11 +100,11 @@ describe('CRM Metadata Spec Compliance', () => {
       }
     });
 
-    it('form section columns are numbers, not strings', () => {
+    it('form section columns are valid string enum values', () => {
       for (const view of allViews) {
         for (const section of view.form.sections) {
           if (section.columns !== undefined) {
-            expect(typeof section.columns).toBe('number');
+            expect(['1', '2', '3', '4']).toContain(section.columns);
           }
         }
       }
@@ -133,18 +133,17 @@ describe('CRM Metadata Spec Compliance', () => {
       }
     });
 
-    it('no action uses variant: "danger" (must use "destructive")', () => {
+    it('action variants use @objectstack/spec allowed values', () => {
       for (const action of allActions) {
         if ('variant' in action) {
-          expect(action.variant).not.toBe('danger');
-          expect(['default', 'primary', 'secondary', 'destructive', 'outline', 'ghost']).toContain(action.variant);
+          expect(['primary', 'secondary', 'danger', 'ghost', 'link']).toContain(action.variant);
         }
       }
     });
 
-    it('destructive actions have confirmText', () => {
+    it('danger actions have confirmText', () => {
       for (const action of allActions) {
-        if ('variant' in action && action.variant === 'destructive') {
+        if ('variant' in action && action.variant === 'danger') {
           expect(action).toHaveProperty('confirmText');
         }
       }

examples/crm/src/actions/account.actions.ts

@@ -31,7 +31,7 @@ export const AccountActions = [
     type: 'api' as const,
     locations: ['record_more' as const],
     confirmText: 'Are you sure you want to merge these accounts? This action cannot be undone.',
-    variant: 'destructive' as const,
+    variant: 'danger' as const,
     refreshAfter: true,
   },
 ];

examples/crm/src/actions/event.actions.ts

@@ -26,7 +26,7 @@ export const EventActions = [
     icon: 'x-circle',
     type: 'api' as const,
     locations: ['record_more' as const],
-    variant: 'destructive' as const,
+    variant: 'danger' as const,
     params: [
       { name: 'cancel_reason', label: 'Cancellation Reason', type: 'text' as const },
       { name: 'notify_participants', label: 'Notify Participants', type: 'boolean' as const },

examples/crm/src/actions/opportunity.actions.ts

@@ -38,7 +38,7 @@ export const OpportunityActions = [
     icon: 'x-circle',
     type: 'api' as const,
     locations: ['record_more' as const],
-    variant: 'destructive' as const,
+    variant: 'danger' as const,
     params: [
       { name: 'loss_reason', label: 'Reason for Loss', type: 'text' as const, required: true },
     ],

examples/crm/src/actions/user.actions.ts

@@ -14,7 +14,7 @@ export const UserActions = [
     icon: 'user-x',
     type: 'api' as const,
     locations: ['record_more' as const],
-    variant: 'destructive' as const,
+    variant: 'danger' as const,
     confirmText: 'Are you sure you want to deactivate this user?',
     refreshAfter: true,
     successMessage: 'User deactivated',

examples/crm/src/views/account.view.ts

@@ -23,22 +23,22 @@ export const AccountView = {
     sections: [
       {
         label: 'Basic Information',
-        columns: 2,
+        columns: '2' as const,
         fields: ['name', 'industry', 'type', 'rating', 'website', 'phone', 'employees', 'owner'],
       },
       {
         label: 'Financial',
-        columns: 2,
+        columns: '2' as const,
         fields: ['annual_revenue', 'tags'],
       },
       {
         label: 'Address',
-        columns: 2,
+        columns: '2' as const,
         fields: ['billing_address', 'shipping_address', 'latitude', 'longitude'],
       },
       {
         label: 'Additional Details',
-        columns: 1,
+        columns: '1' as const,
         collapsible: true,
         fields: ['linkedin_url', 'founded_date', 'description', 'created_at'],
       },

examples/crm/src/views/contact.view.ts

@@ -22,22 +22,22 @@ export const ContactView = {
     sections: [
       {
         label: 'Personal Information',
-        columns: 2,
+        columns: '2' as const,
         fields: ['avatar', 'name', 'email', 'phone', 'title', 'department', 'company'],
       },
       {
         label: 'Account & Status',
-        columns: 2,
+        columns: '2' as const,
         fields: ['account', 'status', 'priority', 'lead_source', 'is_active', 'do_not_call'],
       },
       {
         label: 'Address & Social',
-        columns: 2,
+        columns: '2' as const,
         fields: ['address', 'linkedin', 'birthdate', 'latitude', 'longitude'],
       },
       {
         label: 'Notes',
-        columns: 1,
+        columns: '1' as const,
         collapsible: true,
         fields: ['notes'],
       },

examples/crm/src/views/event.view.ts

@@ -35,22 +35,22 @@ export const EventView = {
     sections: [
       {
         label: 'Event Details',
-        columns: 2,
+        columns: '2' as const,
         fields: ['subject', 'type', 'status', 'location', 'is_all_day', 'is_private'],
       },
       {
         label: 'Schedule',
-        columns: 2,
+        columns: '2' as const,
         fields: ['start', 'end', 'reminder'],
       },
       {
         label: 'Participants',
-        columns: 2,
+        columns: '2' as const,
         fields: ['organizer', 'participants'],
       },
       {
         label: 'Description',
-        columns: 1,
+        columns: '1' as const,
         collapsible: true,
         fields: ['description'],
       },

examples/crm/src/views/opportunity.view.ts

@@ -33,22 +33,22 @@ export const OpportunityView = {
     sections: [
       {
         label: 'Deal Information',
-        columns: 2,
+        columns: '2' as const,
         fields: ['name', 'account', 'contacts', 'type', 'lead_source', 'campaign_source'],
       },
       {
         label: 'Financials & Stage',
-        columns: 2,
+        columns: '2' as const,
         fields: ['amount', 'expected_revenue', 'probability', 'stage', 'forecast_category'],
       },
       {
         label: 'Timeline',
-        columns: 2,
+        columns: '2' as const,
         fields: ['close_date', 'next_step'],
       },
       {
         label: 'Description',
-        columns: 1,
+        columns: '1' as const,
         collapsible: true,
         fields: ['description'],
       },

examples/crm/src/views/opportunity_contact.view.ts

@@ -14,7 +14,7 @@ export const OpportunityContactView = {
     sections: [
       {
         label: 'Relationship',
-        columns: 2,
+        columns: '2' as const,
         fields: ['name', 'opportunity', 'contact', 'role', 'is_primary'],
       },
     ],