Skip to content

Commit e05bf39

Browse files
authored
Merge pull request #1226 from objectstack-ai/copilot/restrict-storybook-tests-on-push
CI: Run Storybook tests only on `main` pushes
2 parents 1ce682d + 26539b8 commit e05bf39

File tree

2 files changed

+9
-20
lines changed

2 files changed

+9
-20
lines changed

.github/workflows/storybook-tests.yml

Lines changed: 7 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,14 @@
11
name: Storybook Tests
22
on:
33
push:
4-
branches: [main, develop]
4+
branches: [main]
55
paths:
6-
- 'packages/**'
7-
- '.storybook/**'
8-
- 'pnpm-lock.yaml'
9-
pull_request:
10-
branches: [main, develop]
11-
paths:
12-
- 'packages/**'
13-
- '.storybook/**'
14-
- 'pnpm-lock.yaml'
6+
- "packages/**"
7+
- ".storybook/**"
8+
- "pnpm-lock.yaml"
159

1610
concurrency:
17-
group: storybook-tests-${{ github.event.pull_request.number || github.ref }}
11+
group: storybook-tests-${{ github.ref }}
1812
cancel-in-progress: true
1913

2014
permissions:
@@ -39,8 +33,8 @@ jobs:
3933

4034
- uses: actions/setup-node@v6
4135
with:
42-
node-version: '20'
43-
cache: 'pnpm'
36+
node-version: "20"
37+
cache: "pnpm"
4438

4539
- name: Turbo Cache
4640
uses: actions/cache@v5
@@ -80,10 +74,3 @@ jobs:
8074

8175
- name: Run Storybook tests
8276
run: pnpm storybook:ci
83-
84-
- name: Run visual regression tests
85-
if: github.event_name == 'pull_request'
86-
run: |
87-
concurrently -k -s first \
88-
"pnpm storybook --no-open" \
89-
"wait-on tcp:6006 && pnpm storybook:test:snapshot"

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
2323

2424
### Changed
2525

26+
- **Storybook CI scope reduced** (`ci`): Updated `.github/workflows/storybook-tests.yml` to run only on `push` to `main` (removed `pull_request` and `develop` triggers) and removed the PR-only visual regression step to reduce heavy CI load on contributor PRs.
27+
2628
- **Merged ObjectManagerPage into MetadataManagerPage pipeline** (`@object-ui/console`): Removed the standalone `ObjectManagerPage` component. Object management is now fully handled by the generic `MetadataManagerPage` (list view) and `MetadataDetailPage` (detail view) pipeline. The object type config in `metadataTypeRegistry` uses `listComponent: ObjectManagerListAdapter` for the custom list UI and `pageSchemaFactory: buildObjectDetailPageSchema` for the detail page, eliminating redundant page code and centralizing all metadata management through a single architecture.
2729

2830
- **`listComponent` extension point on MetadataTypeConfig** (`@object-ui/console`): New optional `listComponent` field allows metadata types to inject a fully custom list component into `MetadataManagerPage`, replacing the default card/grid rendering. The page shell (header, back button, title) is still rendered by the generic manager. `MetadataListComponentProps` interface provides `config`, `basePath`, `metadataType`, and `isAdmin` to the custom component.

0 commit comments

Comments
 (0)