Skip to content

Commit e76e805

Browse files
fix: improve error messages and placeholder naming per review feedback
Agent-Logs-Url: https://github.com/objectstack-ai/objectui/sessions/c72f47f2-b9dd-4364-b613-535fb3b9d405 Co-authored-by: xuyushun441-sys <255036401+xuyushun441-sys@users.noreply.github.com>
1 parent f91c312 commit e76e805

3 files changed

Lines changed: 5 additions & 5 deletions

File tree

apps/console/src/config/metadataTypeRegistry.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@ export const METADATA_TYPES: MetadataTypeConfig[] = [
175175
{ key: 'description', label: 'Description' },
176176
],
177177
formFields: [
178-
{ key: 'name', label: 'Name', required: true, placeholder: 'my_dashboard', disabledOnEdit: true },
178+
{ key: 'name', label: 'Name', required: true, placeholder: 'dashboard_name', disabledOnEdit: true },
179179
{ key: 'label', label: 'Label', required: true, placeholder: 'My Dashboard' },
180180
{ key: 'description', label: 'Description', type: 'textarea', placeholder: 'Brief description' },
181181
],
@@ -192,7 +192,7 @@ export const METADATA_TYPES: MetadataTypeConfig[] = [
192192
{ key: 'description', label: 'Description' },
193193
],
194194
formFields: [
195-
{ key: 'name', label: 'Name', required: true, placeholder: 'my_page', disabledOnEdit: true },
195+
{ key: 'name', label: 'Name', required: true, placeholder: 'page_name', disabledOnEdit: true },
196196
{ key: 'label', label: 'Label', required: true, placeholder: 'My Page' },
197197
{ key: 'description', label: 'Description', type: 'textarea', placeholder: 'Brief description' },
198198
],
@@ -209,7 +209,7 @@ export const METADATA_TYPES: MetadataTypeConfig[] = [
209209
{ key: 'description', label: 'Description' },
210210
],
211211
formFields: [
212-
{ key: 'name', label: 'Name', required: true, placeholder: 'my_report', disabledOnEdit: true },
212+
{ key: 'name', label: 'Name', required: true, placeholder: 'report_name', disabledOnEdit: true },
213213
{ key: 'label', label: 'Label', required: true, placeholder: 'My Report' },
214214
{ key: 'description', label: 'Description', type: 'textarea', placeholder: 'Brief description' },
215215
],

apps/console/src/pages/system/MetadataDetailPage.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ export function MetadataDetailPage() {
110110
toast.success(`${config?.label ?? 'Item'} "${itemName}" updated`);
111111
} catch {
112112
toast.error(`Failed to update "${itemName}"`);
113-
throw new Error('save failed');
113+
throw new Error(`Failed to save ${config?.label ?? 'item'} "${itemName}"`);
114114
} finally {
115115
setSaving(false);
116116
}

apps/console/src/pages/system/MetadataManagerPage.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@ export function MetadataManagerPage() {
174174
? `Failed to update "${name}"`
175175
: `Failed to create "${name}"`,
176176
);
177-
throw new Error('save failed');
177+
throw new Error(`Failed to save ${config?.label ?? 'item'} "${name}"`);
178178
} finally {
179179
setSaving(false);
180180
}

0 commit comments

Comments
 (0)