Commit fd45313
test(app-shell): make field-rule 'non-CEL dialect' fixture forward-compatible (#2696)
The 'skips non-CEL dialect envelopes' test used `{ dialect: 'js', source: '!!!' }`.
framework#3278 (spec PR #3291) retires the `js` expression dialect from
`ExpressionDialect` (now `cel|cron|template`), which will make that envelope
shape-invalid once objectui bumps to the narrowed spec, breaking the
`.toEqual([])` assertion via a spec-Zod issue at `fields.status.visibleWhen`.
Swap to `{ dialect: 'template', source: '!!!' }` — a well-typed NON-CEL dialect
that survives the narrowing. It must stay non-CEL: `predicateSource` only lints
`dialect: undefined | 'cel'`, so `dialect: 'cel'` would make the lint OWN the
garbage source and flag it, flipping the assertion. Behavior-neutral against the
current spec (15.1.1, `js` still present) and the future narrowed spec alike.
Co-authored-by: Jack Zhuang <277994282+os-zhuang@users.noreply.github.com>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>1 parent ce86822 commit fd45313
1 file changed
Lines changed: 6 additions & 1 deletion
Lines changed: 6 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
76 | 76 | | |
77 | 77 | | |
78 | 78 | | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
79 | 84 | | |
80 | 85 | | |
81 | | - | |
| 86 | + | |
82 | 87 | | |
83 | 88 | | |
84 | 89 | | |
| |||
0 commit comments