fix: align NavigationItem and NavigationArea label types with @objectstack/spec v4#1225
Merged
fix: align NavigationItem and NavigationArea label types with @objectstack/spec v4#1225
Conversation
Updated pnpm-lock.yaml via clean install to ensure all @objectstack packages are on consistent 4.0.3 versions. Note: There's a validation warning from @objectstack/spec@4.0.3 regarding Setup app navigation labels, but this is an upstream issue and doesn't affect functionality. The dev server starts and runs successfully. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
…stack/spec v4
Updated NavigationItem.label and NavigationArea.label to use plain string type instead of the legacy i18n object format `{key, defaultValue}`.
This aligns our type definitions with @objectstack/spec v4 protocol which requires label fields to be plain strings only.
Note: The validation warning from @objectstack/plugin-auth persists because that package's runtime code still transforms string labels into i18n objects. This is an upstream issue in the @objectstack framework.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Claude created this pull request from a session on behalf of
hotlong
April 14, 2026 02:48
View session
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
Contributor
There was a problem hiding this comment.
Pull request overview
Aligns ObjectUI’s unified navigation type definitions with @objectstack/spec v4 by enforcing label fields as plain strings, eliminating legacy i18n-object typing that caused dev-time validation/type inconsistencies.
Changes:
- Update
NavigationItem.labeltype from a string-or-i18n-object union tostring. - Update
NavigationArea.labeltype from a string-or-i18n-object union tostring. - Adjust inline documentation comments to reflect the spec v4 requirement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
@objectstack/spec v4 changed the protocol to require
labelfields as plain strings, but ObjectUI type definitions still allowed the legacy i18n object format{key, defaultValue, params}, causing validation warnings during development.Changes
Type Definition Updates
NavigationItem.label:string | {key, defaultValue, params}→stringNavigationArea.label:string | {key, defaultValue, params}→stringBackward Compatibility Preserved
resolveI18nLabel(),resolveLabel()) still handle both formats for data coming from external sources or legacy configurationsNote
Validation warnings from
@objectstack/plugin-authpersist due to upstream runtime transformations in the ObjectStack framework itself - the plugin's TypeScript source uses plain strings but runtime code transforms them to i18n objects. This is an upstream issue outside ObjectUI's scope.