feat: ADR-0047 implementation (objectui) — spec tabs render, visualization switcher, interface pages

packages/app-shell/src/views/InterfaceListPage.tsx

@@ -0,0 +1,188 @@
+/**
+ * Interface List Page — ADR-0047 interface mode.
+ *
+ * Renders a page whose `interfaceConfig` binds a single source view into an
+ * author-curated list surface. Where ObjectView (data mode) shows ALL of an
+ * object's list views as switcher tabs and lets users create views, this
+ * surface is deliberately closed:
+ *
+ *   • the page REFERENCES one view (`interfaceConfig.sourceView`) — columns,
+ *     base filter and sort are inherited, never restated (the iron rule);
+ *   • end users get exactly the `userFilters` the author enabled;
+ *   • the visualization comes from `appearance.allowedVisualizations`
+ *     (a single entry renders no switcher);
+ *   • `userActions` toggles map onto the toolbar — advanced filtering and
+ *     view management are absent by default.
+ */
+
+import * as React from 'react';
+import { ListView } from '@object-ui/plugin-list';
+import { useAdapter } from '@object-ui/react';
+import { Empty, EmptyTitle, EmptyDescription } from '@object-ui/components';
+import { Database } from 'lucide-react';
+import { useObjectTranslation } from '@object-ui/i18n';
+import { useMetadata } from '../providers/MetadataProvider';
+
+interface InterfaceListPageProps {
+  page: any;
+  className?: string;
+}
+
+/**
+ * Resolve the source list view from the merged object definition.
+ * Views merged from ADR-0017 ViewItems are keyed `<object>.<key>`;
+ * the page author writes the bare key (`sourceView: 'default'`).
+ */
+function resolveSourceView(objectDef: any, sourceView?: string): any | undefined {
+  const views: Record<string, any> = objectDef?.listViews || objectDef?.list_views || {};
+  // ADR-0017 expansion can serve a default-view item with an empty config
+  // while the full body lives on `objectDef.list` — prefer candidates that
+  // actually carry columns over hollow name matches.
+  const candidates = sourceView
+    ? [
+        views[`${objectDef?.name}.${sourceView}`],
+        views[sourceView],
+        ...(sourceView === 'default' || sourceView === 'list' ? [objectDef?.list] : []),
+      ]
+    : [objectDef?.list, ...Object.values(views)];
+  const present = candidates.filter(Boolean);
+  return present.find((v: any) => v?.columns) ?? present[0];
+}
+
+export function InterfaceListPage({ page, className }: InterfaceListPageProps) {
+  const { t } = useObjectTranslation();
+  const { objects } = useMetadata();
+  const dataSource = useAdapter();
+
+  const cfg = page?.interfaceConfig || {};
+  const objectDef = React.useMemo(
+    () => (objects || []).find((o: any) => o.name === cfg.source),
+    [objects, cfg.source],
+  );
+  const resolvedView = React.useMemo(
+    () => resolveSourceView(objectDef, cfg.sourceView),
+    [objectDef, cfg.sourceView],
+  );
+
+  // The view list endpoint can serve hollow expansion items (no columns);
+  // the full body lives behind the per-view overlay API — the same
+  // hydration ObjectView performs. Only fetch when the resolution came up
+  // hollow.
+  const [hydratedView, setHydratedView] = React.useState<any>(null);
+  React.useEffect(() => {
+    let cancelled = false;
+    setHydratedView(null);
+    if (!objectDef || !cfg.source || resolvedView?.columns) return;
+    const viewKey = resolvedView?.name
+      ?? (cfg.sourceView ? `${cfg.source}.${cfg.sourceView}` : undefined);
+    if (!viewKey) return;
+    (async () => {
+      try {
+        const ds: any = dataSource;
+        let full: any = null;
+        if (typeof ds?.listViewOverrides === 'function') {
+          const all = await ds.listViewOverrides(cfg.source);
+          full = all?.[viewKey] ?? null;
+        }
+        if (!full?.columns && typeof ds?.getView === 'function') {
+          full = await ds.getView(cfg.source, viewKey);
+        }
+        if (!cancelled && full && typeof full === 'object') setHydratedView(full);
+      } catch { /* hollow view stays hollow — renderer falls back to defaults */ }
+    })();
+    return () => { cancelled = true; };
+  }, [objectDef, cfg.source, cfg.sourceView, resolvedView, dataSource]);
+
+  const viewDef = React.useMemo(
+    () => (hydratedView ? { ...resolvedView, ...hydratedView } : resolvedView),
+    [resolvedView, hydratedView],
+  );
+
+  const schema = React.useMemo(() => {
+    if (!objectDef) return undefined;
+    const view = viewDef || {};
+    const appearance = cfg.appearance ?? view.appearance;
+    const allowed: string[] = appearance?.allowedVisualizations || [];
+    const userActions = cfg.userActions || {};
+
+    // Inherited data semantics (the iron rule: all from the view) + the
+    // page's own always-on criteria (`filterBy`).
+    const filters = [
+      ...(Array.isArray(view.filter) ? view.filter : []),
+      ...(Array.isArray(cfg.filterBy) ? cfg.filterBy : []),
+    ];
+
+    return {
+      type: 'list-view' as const,
+      objectName: objectDef.name,
+      viewType: (allowed[0] ?? view.type ?? 'grid'),
+      fields: view.columns,
+      ...(filters.length ? { filters } : {}),
+      ...(view.sort?.length ? { sort: view.sort } : {}),
+      grouping: view.grouping,
+      rowColor: view.rowColor,
+      pagination: view.pagination,
+      searchableFields: view.searchableFields,
+      emptyState: view.emptyState,
+      kanban: view.kanban,
+      calendar: view.calendar,
+      gallery: view.gallery,
+      timeline: view.timeline,
+      gantt: view.gantt,
+
+      // Presentation policy — the page layer (ADR-0047).
+      userFilters: cfg.userFilters ?? view.userFilters,
+      appearance,
+      showViewSwitcher: allowed.length > 1,
+      showRecordCount: cfg.showRecordCount,
+
+      // userActions toggles → toolbar flags. Interface mode is closed by
+      // default: the advanced filter builder and view-management tools are
+      // only present when the author opted in.
+      showSearch: userActions.search !== false,
+      showSort: userActions.sort !== false,
+      showFilters: userActions.filter === true,
+      showDensity: userActions.rowHeight === true,
+      showHideFields: false,
+      showGroup: false,
+      showColor: false,
+      allowExport: false,
+      inlineEdit: false,
+    };
+  }, [objectDef, viewDef, cfg]);
+
+  if (!objectDef || !schema) {
+    return (
+      <div className="h-full flex items-center justify-center p-8">
+        <Empty>
+          <div className="mx-auto mb-4 flex h-12 w-12 items-center justify-center rounded-full bg-muted">
+            <Database className="h-6 w-6 text-muted-foreground" />
+          </div>
+          <EmptyTitle>{t('empty.objectNotFound', { defaultValue: 'Source object not found' })}</EmptyTitle>
+          <EmptyDescription>
+            {t('empty.interfacePageSourceMissing', {
+              defaultValue: 'This interface page references "{{name}}", which is not available.',
+              name: cfg.source || '?',
+            })}
+          </EmptyDescription>
+        </Empty>
+      </div>
+    );
+  }
+
+  return (
+    <div className={className ?? 'h-full flex flex-col'} data-testid="interface-list-page">
+      <div className="px-4 pt-4 pb-2 shrink-0">
+        <h1 className="text-lg font-semibold leading-tight">
+          {typeof page.label === 'string' ? page.label : page.name}
+        </h1>
+        {typeof page.description === 'string' && page.description && (
+          <p className="text-sm text-muted-foreground mt-0.5">{page.description}</p>
+        )}
+      </div>
+      <div className="flex-1 min-h-0 overflow-auto">
+        <ListView schema={schema} dataSource={dataSource} />
+      </div>
+    </div>
+  );
+}

packages/app-shell/src/views/ObjectView.tsx

@@ -1122,9 +1122,21 @@ function ObjectViewInner({ dataSource, objects, onEdit, externalRefreshKey }: an
                 persistViewPatch(viewDef.id, viewDef, { columnState: state });
             },
             inlineEdit: viewDef.inlineEdit ?? viewDef.editRecordsInline ?? listSchema.inlineEdit,
-            appearance: viewDef.showDescription != null
-                ? { showDescription: viewDef.showDescription }
-                : listSchema.appearance,
+            // ADR-0047 — spec `appearance` (incl. allowedVisualizations, the
+            // runtime visualization whitelist) flows from the view metadata;
+            // the legacy bare `showDescription` flag is folded in on top.
+            appearance: viewDef.appearance
+                ? (viewDef.showDescription != null
+                    ? { ...viewDef.appearance, showDescription: viewDef.showDescription }
+                    : viewDef.appearance)
+                : (viewDef.showDescription != null
+                    ? { showDescription: viewDef.showDescription }
+                    : listSchema.appearance),
+            // Offer the visualization switcher only when the author
+            // whitelisted more than one type; ListView intersects the
+            // whitelist with capability-resolvable types.
+            showViewSwitcher:
+                ((viewDef.appearance ?? listSchema.appearance)?.allowedVisualizations?.length ?? 0) > 1,
             // Propagate toolbar/display flags for all view types
             showSearch: viewDef.showSearch ?? listSchema.showSearch,
             showSort: viewDef.showSort ?? listSchema.showSort,
@@ -1202,7 +1214,11 @@ function ObjectViewInner({ dataSource, objects, onEdit, externalRefreshKey }: an
                         ?? resolveManagedByEmptyState((objectDef as any)?.managedBy, t),
                 ),
             aria: viewDef.aria ?? listSchema.aria,
-            tabs: listSchema.tabs,
+            // ADR-0047 — per-view filter tabs from metadata (ViewTab presets)
+            // take precedence over schema-level tabs. Dropping viewDef.tabs
+            // here was the one-line gap that kept spec tab metadata from
+            // ever reaching the TabBar.
+            tabs: viewDef.tabs ?? listSchema.tabs,
             // Propagate filter/sort as default filters/sort for data flow
             ...((() => {
                 const combined = [

packages/app-shell/src/views/PageView.tsx

@@ -19,6 +19,7 @@ import { useAuth } from '@object-ui/auth';
 import { MetadataPanel, useMetadataInspector } from './MetadataInspector';
 import { useMetadata } from '../providers/MetadataProvider';
 import { ConsoleActionRuntimeProvider } from '../hooks/useConsoleActionRuntime';
+import { InterfaceListPage } from './InterfaceListPage';
 
 export function PageView() {
   const { t } = useObjectTranslation();
@@ -91,14 +92,20 @@ export function PageView() {
               {t('common.editInStudio', { defaultValue: 'Edit in studio' })}
             </button>
           )}
-          <SchemaRenderer
-            key={refreshKey}
-            schema={{
-              ...page,
-              type: (page as any).type || 'page',
-              context: { ...(page as any).context, params, refreshKey },
-            }}
-          />
+          {(page as any).interfaceConfig?.source ? (
+            // ADR-0047 interface mode: the page binds a source view into a
+            // curated list surface — rendered directly, not via regions.
+            <InterfaceListPage key={refreshKey} page={page} />
+          ) : (
+            <SchemaRenderer
+              key={refreshKey}
+              schema={{
+                ...page,
+                type: (page as any).type || 'page',
+                context: { ...(page as any).context, params, refreshKey },
+              }}
+            />
+          )}
         </div>
         <MetadataPanel
           open={showDebug}

packages/data-objectstack/src/index.ts

@@ -1379,8 +1379,10 @@ export class ObjectStackAdapter<T = unknown> implements DataSource<T> {
     try {
       const cacheKey = `view:${objectName}:${viewId}`;
       return await this.metadataCache.get(cacheKey, async () => {
-        // Try meta.getItem for view metadata
-        const result: any = await this.client.meta.getItem(objectName, viewId);
+        // Views are an independent metadata type (ADR-0017) — the first
+        // getItem argument is the metadata TYPE, not the object name.
+        // (Passing objectName here hit /meta/<object>/<view> and always 404ed.)
+        const result: any = await this.client.meta.getItem('view', viewId);
         if (result && result.item) return result.item;
         return result ?? null;
       });