feat(console): DocPage resolves docs package-scoped (ADR-0048 — prefix optional)#1701
Merged
Merged
Conversation
…x optional)
DocPage now passes the route's package (`/apps/:appName/docs/:name`, where
:appName is the package id) to `meta.getItem('doc', name, { packageId })`. The
client SDK already sends `?package=`; the framework REST endpoint now honors it
(objectstack-ai/objectstack#1816), resolving the single doc package-scoped
(prefer-local) — so doc names no longer need a namespace prefix for uniqueness.
Legacy top-level /docs/:name (no :appName) stays context-free.
Browser-verified: /apps/com.example.showcase/docs/showcase_index issues
GET …/meta/doc/showcase_index?package=com.example.showcase → 200 and renders.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pairs with framework objectstack-ai/objectstack#1816. Makes the doc namespace prefix optional.
What
DocPagepasses the route's package (/apps/:appName/docs/:name, where:appNameis the package id) tometa.getItem('doc', name, { packageId }). The client SDK already emits?package=; with the framework endpoint now honoring it, the single doc resolves package-scoped (prefer-local) while keeping its content. Legacy top-level/docs/:name(no:appName) stays context-free.Result
Doc names no longer need a namespace prefix for uniqueness — two packages can ship the same bare doc name, each resolving within its own package, exactly like page/dashboard/report.
Verified (browser, live backend)
/apps/com.example.showcase/docs/showcase_index→GET …/meta/doc/showcase_index?package=com.example.showcase → 200→ renders the doc. Console typecheck clean.🤖 Generated with Claude Code