fix(share): correct public share link URL + ShareDialog audiences#1784
Merged
Conversation
Offer only link_only + signed_in (the audiences needing no extra input and allowed by ai_conversations); drop workspace/email_allowlist which the framework ShareLinkService rejects. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
SharedRecordPage lives under the console SPA basename (/_console/s/:token),
so ShareDialog's default ${origin}/s/:token produced links that 404'd for
recipients. AiChatPage now passes publicBaseUrl derived from the injected
<base href> (matching App.tsx resolveBasename), so copied links resolve.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes so the prebuilt share-conversation UI works against the cloud backend (framework objectstack-ai/objectstack#1986 + cloud per-env wiring):
SharedRecordPageis served under the console SPA basename (/_console/s/:token), butShareDialogdefaulted to${origin}/s/:token→ recipient links 404'd.AiChatPagenow passespublicBaseUrlderived from the injected<base href>(matchingApp.tsxresolveBasename).ShareDialognow offers onlylink_only+signed_in(the values that need no extra input and thatai_conversations.publicSharing.allowedAudiencespermits), aligned to the frameworkShareLinkAudiencecontract; droppedworkspace/email_allowlistwhich the service rejects.Verified browser-E2E: dialog opens with no HTTP 404, creates a link, and the copied
/_console/s/<token>link renders the conversation read-only with no login.🤖 Generated with Claude Code