fix(layout): responsive page regions + grid columns on mobile#1816
Merged
Conversation
Mobile-mode QA found two foundational responsiveness gaps that made every composed page render poorly on phones. 1. Region layouts kept sidebar + main SIDE-BY-SIDE at all widths — on a 390px phone the sidebar squeezed the main column to an unreadable sliver. The RegionLayout, header-sidebar-main, and three-column templates now use `flex flex-col md:flex-row`, and sidebars are `w-full` on mobile (fixed width only at md+ via a new getSidebarWidthClass returning LITERAL responsive strings so Tailwind's JIT emits them). Rails now stack above/below main on phones and restore side-by-side on desktop. 2. The layout `grid` rendered a bare numeric `columns: N` as `grid-cols-N` at ALL widths — a 4-up KPI row became 4 unreadable slivers on mobile. A bare numeric columns (no explicit responsive object / sm/md/lg/xlColumns) now ramps mobile-first: `grid-cols-1 sm:grid-cols-2 md:grid-cols-N`. Authors with explicit responsive config keep full control. Browser-verified at 390×844 AND 1440×900: the showcase home, My Work, dashboard, lists, and record pages all read well on mobile and are unchanged on desktop. components layout tests pass (1203). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mobile-mode QA (390×844) found two foundational responsiveness gaps that made every composed page render poorly on phones.
1 — Region layouts didn't stack
Sidebar + main stayed side-by-side at all widths — on a phone the sidebar squeezed main to an unreadable sliver.
RegionLayout,header-sidebar-main, and three-column templates now useflex flex-col md:flex-row, and sidebars arew-fullon mobile (fixed width only atmd+, via a newgetSidebarWidthClassthat returns literal responsive strings so Tailwind's JIT emits them). Rails stack above/below main on phones, restore side-by-side on desktop.2 — Layout grid didn't collapse
A bare numeric
columns: Nrenderedgrid-cols-Nat all widths — a 4-up KPI row became 4 slivers on mobile. A bare numeric columns (no explicit responsive object /sm/md/lg/xlColumns) now ramps mobile-first:grid-cols-1 sm:grid-cols-2 md:grid-cols-N. Explicit responsive configs keep full control.Verified
Browser-tested at 390×844 and 1440×900: showcase home, My Work, dashboard, list/table, and record pages all read well on mobile and are unchanged on desktop.
componentslayout tests pass (1203).🤖 Generated with Claude Code