fix(marketplace): add missing sample-data i18n keys; surface reseed errors#1881
Merged
Conversation
…rrors The package-detail "more options" dropdown rendered raw i18n keys (`marketplace.detail.addSampleData`, `…purgeSampleData`, …) because those keys were never added to any locale bundle. `t()` returns the key string on a miss (truthy), so the `t(...) || 'fallback'` pattern never fired — the menu showed `marketplace.detail.addSamp…` instead of "Add sample data". Only `uninstallFromRuntime` (which existed) rendered correctly. - Add the 10 missing `marketplace.detail.*` keys to all 10 locales (en/zh/ja/ko/ar/de/es/fr/pt/ru) with native translations: addSampleData, reseedAgain, purgeSampleData, purgeConfirm, purgeSuccess, purgeNoData, reseedQueued, reseedLocalSuccess, updateAvailable, reseedPartialErrors. - Local reseed: when the server reports rows landed but some errored (partial), show the failure count instead of a plain success toast. Hard failures (server now returns 422 on 0 rows — framework fix/reseed-honest-result) already surface via the existing catch. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The marketplace package-detail "more options" dropdown rendered raw i18n keys —
marketplace.detail.addSampleData,…purgeSampleData,…reseedLocalSuccess(success banner), etc.Root cause: those keys were never added to any locale bundle. This
t()returns the key string itself on a miss (which is truthy), so the codebase'st('…') || 'English fallback'pattern never fires — the menu showedmarketplace.detail.addSamp…instead of "Add sample data". OnlyuninstallFromRuntime(which existed in the bundles) rendered correctly.marketplace.detail.addSamp…marketplace.detail.reseedLocalSuccessFix
marketplace.detail.*keys to all 10 locales (en/zh/ja/ko/ar/de/es/fr/pt/ru), with native translations:addSampleData,reseedAgain,purgeSampleData,purgeConfirm,purgeSuccess,purgeNoData,reseedQueued,reseedLocalSuccess,updateAvailable,reseedPartialErrors.422on zero rows) already surface through the existingcatch.Verification
@object-ui/i18nand@object-ui/app-shelltype-checkboth pass (0 errors); all 10 locales parse; key counts consistent across locales.Pairs with framework PR objectstack-ai/objectstack#2172 (server stops reporting fake success).
🤖 Generated with Claude Code